From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Thu, 20 Jun 2019 07:41:50 -0700 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 08C882F8BE1; Thu, 20 Jun 2019 14:41:34 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-117-226.ams2.redhat.com [10.36.117.226]) by smtp.corp.redhat.com (Postfix) with ESMTP id 332EA60BCC; Thu, 20 Jun 2019 14:41:32 +0000 (UTC) Subject: Re: [edk2-devel] [edk2] [PATCH] OvmfPkg: QemuVideoDxe: Int10h stub for Windows 2008 R2 SP1 (stdvga, QXL) To: devel@edk2.groups.io, dwmw2@infradead.org, Mike Maslenkin References: <1399571116-26442-1-git-send-email-lersek@redhat.com> <5370CA20.1030504@redhat.com> <1399911663.21359.36.camel@mg-think.sw.ru> <5bb64abf34399bae00b678d0cd8b5df1ac81871b.camel@infradead.org> <475c5196ba3901dc30f80c567524c27be52d00e0.camel@infradead.org> From: "Laszlo Ersek" Message-ID: <920cf69f-8ec8-616a-4a07-9e93e88f81b6@redhat.com> Date: Thu, 20 Jun 2019 16:41:32 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <475c5196ba3901dc30f80c567524c27be52d00e0.camel@infradead.org> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Thu, 20 Jun 2019 14:41:34 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 06/20/19 10:59, David Woodhouse wrote: > On Wed, 2019-06-19 at 23:57 +0200, Laszlo Ersek wrote: >> In 2013, you submitted the following patch: >> >> OvmfPkg: Don't build in QemuVideoDxe when we have CSM >> >> The thread starts here: >> >> https://www.mail-archive.com/edk2-devel@lists.sourceforge.net/msg01871.html >> >> After an update: >> >> http://mid.mail-archive.com/1360493281.7383.26.camel@shinybook.infradead.org >> >> I had given my R-b: >> >> http://mid.mail-archive.com/511816AD.9000603@redhat.com >> >> But, the patch was never merged. >> >> The commit hash referenced in those messages still works (pointing into your personal repo): >> >> http://git.infradead.org/users/dwmw2/edk2.git/commitdiff/22253c949e5 >> >> Can you resubmit that patch please? > > > Makes sense. I've pushed it to > http://git.infradead.org/users/dwmw2/edk2.git/shortlog/refs/heads/csm Thanks -- it looks good to me (a09db38a866a). Reviewed-by: Laszlo Ersek Still, can you please post the patch to the list, for review? We've never merged pull requests before, but I remember that you prefer those (because you dislike an edk2 subsys maintainer rebasing your branch from your original fork-off point). So I'm not asking for the patch email because I insist on using "git-am". I'm asking for it because we'd like to review every patch on the list, for now. Once you get the proper feedback tags (R-b and so on) on the list, you can do the rebase / rewording yourself, and then you could submit a pull request (*not* github pull request, but from "git-request-pull", in email). We've never exercised that in the past, so our workflow is totally immature on that. But I understand you insist on pull reqs, and I think we should accommodate that (again, *not* github pull reqs). The following QEMU wiki article could be the starting point for such a pullreq workflow in edk2: https://wiki.qemu.org/Contribute/SubmitAPullRequest That said, in case you were OK with git-am in this case, that would likely expedite me applying your patch. Thanks! Laszlo