From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id BF2C19414FF for ; Thu, 21 Dec 2023 13:56:41 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=r1f1PrGO+m5YIeeyVlat0lwDSarwVZP6vNgBNRMExuE=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Received-SPF:ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Authentication-Results-Original:Message-ID:Date:User-Agent:Subject:To:Cc:References:From:In-Reply-To:MIME-Version:NoDisclaimer:Original-Authentication-Results:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1703167000; v=1; b=rjA263p2Y/IjTmIKxlpb3/iLco8KE8it6GLS8v5TrLA/w7pixHnwfLWtZQtb3e6JPjcXmvQ0 hTh+GaWlbDuty5htsgk1yrd8KHFf3em9QOHthjiSDbSxntziN0kdD5n28pOxSkDtSsY4ePBuwwx TBRZ7JdqnToL1ZTBuOEHeySY= X-Received: by 127.0.0.2 with SMTP id CojuYY7687511xsglZNpHV0Q; Thu, 21 Dec 2023 05:56:40 -0800 X-Received: from EUR05-VI1-obe.outbound.protection.outlook.com (EUR05-VI1-obe.outbound.protection.outlook.com [40.107.21.47]) by mx.groups.io with SMTP id smtpd.web11.51145.1703166999544593491 for ; Thu, 21 Dec 2023 05:56:40 -0800 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=V22FSzdNAuR75SC+tmvzBLvDJ3B/T2H3RmhmENZ8cxGPS9IxGrPON9pGzqTUdcWGt9Avjr6FfuZcGo4/8PTBuWYsY4/VaKAuwGSLz9YASmuXFpwQBu4NTSTNzyY0wFEbJNPy5xwdl0lIfzcv4PYbDATcXGYC70uP2RBrqjbHqUgmwrqzizER/nRGiW1hpt34l9+o4wHb/r4ahOrEIsSTN2nXZrRyUmy2a/rj6AB9XegxZQj0Fyesu6WwVndcDnMRCqqqQFn+p98TmTluwQdLpSM7pBTY4JVVQE1FU/rUSQ8lBNxEDJ/i3Q9mmECxZJhC1ZQFTVSbfcV7r2aZXfJLIg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jfYuSTPFNxaT1jHuVJ+xUl0oUdq794fyjOmRQRu6Yys=; b=cfbmkL2TbI8F2y9fALG0KAEm8nmcl0m51FlOoRVY++u7OOGedggUfLa7NyzVJoCRvpJThg5DvN7cgAMPJxAr0rFi/1Y/8Z2fFvQgFz3XejtfGe3HHFmF0XPI3Q56Lg05LNjHPXQ41oekJcZnMU6uxQnJRbMz3CGT8UR5PxHmI3hryUCbC56VomFeMUbOdmC2cQEyLiS3mujzZhLeVJgNOjXtZbHP0ySJm6XbFrqZxaEzhfHOZJZ1lkZunzb8Elidg6HFPihCV9thIjwBvT806yOyVgpIZ1xh6niwMT1pDHX4oLywaDg4m4QLJPtjcs8q5zNIBz1IeufwIW/Ywa0HQA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) X-Received: from AM6PR08CA0006.eurprd08.prod.outlook.com (2603:10a6:20b:b2::18) by PR3PR08MB5628.eurprd08.prod.outlook.com (2603:10a6:102:8e::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7113.21; Thu, 21 Dec 2023 13:56:35 +0000 X-Received: from AMS0EPF00000194.eurprd05.prod.outlook.com (2603:10a6:20b:b2:cafe::13) by AM6PR08CA0006.outlook.office365.com (2603:10a6:20b:b2::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7113.19 via Frontend Transport; Thu, 21 Dec 2023 13:56:35 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AMS0EPF00000194.mail.protection.outlook.com (10.167.16.214) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7113.14 via Frontend Transport; Thu, 21 Dec 2023 13:56:34 +0000 X-Received: ("Tessian outbound 5d213238733f:v228"); Thu, 21 Dec 2023 13:56:34 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 3bc336268ffdbe59 X-CR-MTA-TID: 64aa7808 X-Received: from 2b6604bc7d09.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 50F11328-8CF3-480A-8B1C-86AC32FF9470.1; Thu, 21 Dec 2023 13:56:28 +0000 X-Received: from EUR03-AM7-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 2b6604bc7d09.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 21 Dec 2023 13:56:28 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mwH8RuqADtYvn03aRZ76J481MRN2SpedTwO6efLXNkHHVGstNhdRjneVsX95a84GA5Es557gaJQz+FylevA3Es/9W1F+00CMh8agGLm3rU2lABztyDyahdiXWyLYApUYTkq+bGWC/9La3816QHLFZy4BlNUAunJwJdJpN82LSDFEW9ijWcAhn2DRTs5RiHK36cOPeT8+7GP1G+FQeHg4c8Vv/mWZezwez07mqIGwcQaz27HnsZafYF7fMZiD10lxf6S6YnkFAHJS5qb1VHwbvnw8rg4vh6eylDWbWD5VxvPPgl2T6Ifv/MVgn86RAgnANqKJALycJMhMsjMAvt42tQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jfYuSTPFNxaT1jHuVJ+xUl0oUdq794fyjOmRQRu6Yys=; b=NJRTsrkT+upnl7zUwxSXHPVt/i+1f/Mglwq0s3Lj2VSwhOdcmgYPFbY4evSyBJNdb3IuAb0VguNX/lbCit04iuW0BBnxyjnEN5Vp9tJuCnjVRbBoNUzoUOEgi9IPNTIR8zZyvIQI1GUgiDDyV9DhO9G/MtHF6L8m3/sHyfVGXOyJfYkhDUYpKPz4M6DivJUjmvTovD6kPwqaP0LJvz8RrvDltChnMiYNo/LhqU67XxjEyTSldxOL6S7dLQDHn74fFB27KkjdPtJZBKo8JmWOe8Ya8HUOy9nq3veWwECIbBf/9k+XoELdWCpkYvTnv/s5MCFxZJjPB2H5Ab9+2RU0FA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by DU0PR08MB10367.eurprd08.prod.outlook.com (2603:10a6:10:409::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7113.18; Thu, 21 Dec 2023 13:56:25 +0000 X-Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::f36e:3882:2fce:d775]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::f36e:3882:2fce:d775%4]) with mapi id 15.20.7113.019; Thu, 21 Dec 2023 13:56:25 +0000 Message-ID: <921a980f-1967-4033-8048-b228a2c82769@arm.com> Date: Thu, 21 Dec 2023 13:56:24 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [Resend PATCH v5 0/4] DynamicTablesPkg: Adds WordIO and method invocation ability To: Abdul Lateef Attar , devel@edk2.groups.io Cc: Abdul Lateef Attar , Pierre Gondois , "nd@arm.com" References: From: "Sami Mujawar" In-Reply-To: X-ClientProxiedBy: LO4P123CA0369.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18e::14) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: AS8PR08MB6806:EE_|DU0PR08MB10367:EE_|AMS0EPF00000194:EE_|PR3PR08MB5628:EE_ X-MS-Office365-Filtering-Correlation-Id: c52845bf-eb27-4792-402d-08dc022ca4f0 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: Db00sPkUBAggwGftqOU7qlXQjvP0etXp8YXdWMGmY5RPl4PgTh68jlo7H5J7v7f4a1xZiNrMwiG2mVmC0e+70aCTECBfSvJHs4Q0pGXQ8AxaKHwBqfNltej3CGQ72V5+vYWBfW2h6AsGXzsMZ6MfM1HgAlPfpAr1LpYv3q3SvzJgIF10/t1nkYQamGcYNI02XRuvw9t+InZ7i6oXvQy67Lqc3cK2YlR9YXWbv+rxnhBxa2XmcKgHUnVi8zkmOiVESzOwVG5b/tS/9FQJfBCgGVOyWgyglF7N0acJJVZSlZ9YACcG/m9Ywn6wGiH2GfyTRXyLjXlZHhjKJgVoJQWSHARpw/TFOQb50n9iAPYMDALG+dvT1jG0O8bdBcESn2d65xDIUjxNo2rRITtHyG8jJn7L1qxWgIZVnSDFJSovk0cotFtcQgHLNGlWfzwqjjmRfmAiGh5erpvYS1mK0sLzVBlmla97SL9wCrPmKxPPnBAZ77hMAGWkw0ZU77ilkyamCQNjYcPSY9ia5Ma2hu9KCu5OvL931Rvj22dqzxYtRjGp9vSEslZjRsFwpDfpEEGMTCPZxazDaWplB7bsosZWBfQmU1/s1AUTNNOOus0CvsdHHd/N820thY0y8uz7rIbLUjrKQzOPHpWgKoRlnOAWwQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376002)(136003)(346002)(39860400002)(366004)(396003)(230922051799003)(186009)(64100799003)(451199024)(1800799012)(31686004)(41300700001)(38100700002)(66556008)(2906002)(5660300002)(8936002)(66476007)(4326008)(8676002)(54906003)(316002)(66946007)(44832011)(31696002)(26005)(86362001)(966005)(6512007)(36756003)(83380400001)(6506007)(6486002)(2616005)(478600001)(53546011)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB10367 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AMS0EPF00000194.eurprd05.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 5c7836f6-e329-452a-4b1d-08dc022c9f06 X-Microsoft-Antispam-Message-Info: XW7osgba8lrp1szHrnA2NOt7Pc/4FHaC8HGplsEKt2H7suBrj5VGu/pwUz+ZxBI7HpQ4jI4kDCY9Vrr1e7vKOY7Uy0Z2u1BaJ7z5bpIEK26tfce38GiGEmK/VVtgO/QIsQuWAh1AGsc8jUVFLIIwxAvjZqsEhn31DP5HS07FMOwoezkYJNvaJSXqrDXx1idadh2I+LrtctvSjWA1yycUM8MtfJEfPE3aP4WCViqw1Kw5gxDFDFgNnCC2dL5Rx71/klHHsQQI5fVt41kNVyPRrNtZBFXNXwSm9xCv7cHgsKJYArIjetrTQJRoMwzFoDHv1dPt8UlcT7y9INQAY+NGpEVfjYVZp1OGsW4IrXy6ZXh/98GPrzh/7SsKUEhcObYOt0tV92SD6MGDudoVJ4pYuf3jtM4gKUVluSMutjgH0O+HHqxh4LInbnIbv/qecIpoC+X76g8tkLdtgZ6YToXuSaC98wkTDp6hu2euybXXSKjsra8pvBNex22Sepo6VotULGUmtLBwTVr7RIjT0ObSgeXOfC31PsQgfTRC4/iqBG1pZFfdnRyh+uAWQpxlQEewUytvyKdTEv9CpnaCh95zHkQutzhkFddfpUQNceSBcAWTGVHDXZv3q5kmVFHMBc+7EpZ5nSk30lpsKVNMtqYokMdaqcLyxwzqywnPIgEQa492THwR7C53hA+aSgRhBM60naUxDRTQWq8cAbh7yU7gQWTgdRuyxTWGwbFZ1g49PO0LONaTwTBZKo46YlAbq1kW+fkpp9Y8pReikyRCcaTAUQ== X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Dec 2023 13:56:34.8167 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c52845bf-eb27-4792-402d-08dc022ca4f0 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AMS0EPF00000194.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR08MB5628 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sami.mujawar@arm.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: osGOGwDyPPZsVTcL2l427EcJx7686176AA= Content-Language: en-GB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=rjA263p2; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=arm.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi Abdul, Glad to see your contribution to the Dynamic Tables Framework. It would=20 be great to hear how you are using this package. I have some minor comments for the last patch 4/4. If you can reply=20 back, I will try to get the changes merged before the end of this week. Regards, Sami Mujawar On 20/12/2023 09:38 am, Abdul Lateef Attar wrote: > From: Abdul Lateef Attar > > PR: https://github.com/tianocore/edk2/pull/5171/ > > V5: delta changes > Addressed review comments. > V4: > Address Pierre's review comments. > Merged patch 4 & patch 5. > Also added parameter logic suggested by Pierre. > V3: delta changes > CI fix and error handling for > DynamicTablesPkg: Adds API to generate a method with ArgN. > Added new patch "DynamicTablesPkg: Adds wrapper API AmlCodeGenMethodIn= vokeMethodArgn" > V2: > Added new API to generate a method which > invokes another method with argument. > V1: > Code changes to > Add API to generate word I/O ranges. > Correct the parameter to generate word bus number. > Corrects the function pointer typedef > > Cc: Pierre Gondois > Cc: Sami Mujawar > Cc: Abdul Lateef Attar > > Abdul Lateef Attar (4): > DynamicTablesPkg: AML Code generation for word I/O ranges > DynamicTablesPkg: Corrects AmlCodeGenRdWordBusNumber parameters > DynamicTablesPkg: Corrects function pointer typedef of > AML_PARSE_FUNCTION > DynamicTablesPkg: AML Code generation to invoke a method > > .../Include/Library/AmlLib/AmlLib.h | 187 +++++++++++++- > .../Common/AmlLib/CodeGen/AmlCodeGen.c | 235 +++++++++++++++++- > .../AmlLib/CodeGen/AmlResourceDataCodeGen.c | 98 +++++++- > .../Library/Common/AmlLib/Parser/AmlParser.c | 3 +- > 4 files changed, 510 insertions(+), 13 deletions(-) > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112818): https://edk2.groups.io/g/devel/message/112818 Mute This Topic: https://groups.io/mt/103278517/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-