Re: [edk2-devel] [PATCH v1 0/1] ArmPkg/Smbios: Changing default uni values to ""

["Nhi Pham via groups.io" <nhi=os.amperecomputing.com@groups.io>]

Hi Sami,

On 9/9/2024 3:00 PM, Sami Mujawar via groups.io wrote:
> Hi Nhi, Sam,
> 
> Apologies, this slipped off the radar.
> 
> The changes look good to me.
> Is it possible to submit a pull request, please?

I've integrated Sam's patch and changed the default uni values to "Not
Set".

https://github.com/tianocore/edk2/pull/6181

Regards,
Nhi

> 
> Regards,
> 
> Sami Mujawar
> 
> From: Nhi Pham OS <nhi@os.amperecomputing.com>
> Date: Friday 6 September 2024 at 18:38
> To: "devel@edk2.groups.io" <devel@edk2.groups.io>, Sam Kaynor <Sam.Kaynor@arm.com>, "rebecca@bsdio.com" <rebecca@bsdio.com>
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>, Ard Biesheuvel <ardb+tianocore@kernel.org>, Sami Mujawar <Sami.Mujawar@arm.com>
> Subject: Re: [edk2-devel] [PATCH v1 0/1] ArmPkg/Smbios: Changing default uni values to ""
> 
> Hi,
> 
> It seems that this patch has been left unattended.
> 
> The empty string "" may be ambiguous, as it could imply that the string is valid but contains no characters, or it has not been filled. On Ampere platforms, I utilize "Not Set" to avoid this confusion, which is effective for FWTS.
> 
> Regards,
> Nhi
> 
> ________________________________
> From: devel@edk2.groups.io <devel@edk2.groups.io> on behalf of Sam Kaynor via groups.io <sam.kaynor=arm.com@groups.io>
> Sent: Wednesday, November 9, 2022 10:10 PM
> To: devel@edk2.groups.io <devel@edk2.groups.io>
> Cc: Sam Kaynor <sam.kaynor@arm.com>; Leif Lindholm <quic_llindhol@quicinc.com>; Ard Biesheuvel <ardb+tianocore@kernel.org>; Sami Mujawar <sami.mujawar@arm.com>
> Subject: [edk2-devel] [PATCH v1 0/1] ArmPkg/Smbios: Changing default uni values to ""
> 
> Current default values in uni files are set to "Not Specified". This
> value causes errors in DMI tables when running FWTS tests. To avoid
> these errors and align more closely with the SMBIOS spec, the default
> value is changed from "Not Specified" to empty string "".
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4066
> 
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Signed-off-by: Sam Kaynor <sam.kaynor@arm.com>
> 
> Sam Kaynor (1):
>   ArmPkg: Smbios: UNI file default values
> 
>  ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClassStrings.uni  | 12 ++++++------
>  ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendor.uni            |  8 ++++----
>  ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturer.uni    | 12 ++++++------
>  ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturer.uni | 14 +++++++-------
>  ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturer.uni   | 10 +++++-----
>  5 files changed, 28 insertions(+), 28 deletions(-)
> 
> --
> 2.34.1
> 
> 
> 
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#96133): https://edk2.groups.io/g/devel/message/96133
> Mute This Topic: https://groups.io/mt/94914657/5228573
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub [nhi@os.amperecomputing.com]
> -=-=-=-=-=-=
> 
> 
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120536): https://edk2.groups.io/g/devel/message/120536
Mute This Topic: https://groups.io/mt/94914657/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-