From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id BF390D804EA for ; Tue, 10 Sep 2024 00:08:15 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=rT9F5FUfH8mHlvB/pp+2uZcof7kHtfzadrV25op+90s=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:User-Agent:Subject:To:Cc:References:From:In-Reply-To:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240830; t=1725926895; v=1; x=1726186094; b=FM9QmLcfNHW9OJVfvF0IvKjA5JMF4bIqHc/IPDmdAJAkTxJzXossechoEcYydMLZ/XU6lDRS k7zQVNuL+xoQ3F8aGPXYyKTQ4HtbvrX28VjnXWXMwoxRyAWt6yCF/nG9WaZEVzJT4C03lDx8Jos uhl19j23Ih1maGn03WTh0+NvEYyVvgiqSb3hQNnE2ySsR86ylDDCmluZj1qRHeS+0b9vH2xqwma 8M5iL+WNYFsIZMx8/hT75Kog2ojApOkvoEc7RGXn/Icf6K6t3ywQIK5ArT9E+5jh5vHvzQ6oyS/ 0LUDCafiD21L0t+yZGGxvNmZQF0sjzUKxXnLVnlF85Ivw== X-Received: by 127.0.0.2 with SMTP id gs7VYY7687511xDlxLKhcr61; Mon, 09 Sep 2024 17:08:14 -0700 X-Received: from SN4PR2101CU001.outbound.protection.outlook.com (SN4PR2101CU001.outbound.protection.outlook.com [40.93.195.90]) by mx.groups.io with SMTP id smtpd.web10.11341.1725926893540521271 for ; Mon, 09 Sep 2024 17:08:13 -0700 X-Received: from PH0PR01MB7287.prod.exchangelabs.com (2603:10b6:510:10a::21) by DS7PR01MB7879.prod.exchangelabs.com (2603:10b6:8:82::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7918.27; Tue, 10 Sep 2024 00:08:08 +0000 X-Received: from PH0PR01MB7287.prod.exchangelabs.com ([fe80::fc79:e629:93aa:8b8f]) by PH0PR01MB7287.prod.exchangelabs.com ([fe80::fc79:e629:93aa:8b8f%4]) with mapi id 15.20.7939.022; Tue, 10 Sep 2024 00:08:08 +0000 Message-ID: <9224816d-1dd3-457c-a50e-0df55d1cc21d@os.amperecomputing.com> Date: Tue, 10 Sep 2024 07:08:01 +0700 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH v1 0/1] ArmPkg/Smbios: Changing default uni values to "" To: devel@edk2.groups.io, sami.mujawar@arm.com, Sam Kaynor , "rebecca@bsdio.com" Cc: Leif Lindholm , Ard Biesheuvel , nd References: <20221109151036.2164337-1-sam.kaynor@arm.com> From: "Nhi Pham via groups.io" In-Reply-To: X-ClientProxiedBy: BYAPR01CA0072.prod.exchangelabs.com (2603:10b6:a03:94::49) To PH0PR01MB7287.prod.exchangelabs.com (2603:10b6:510:10a::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR01MB7287:EE_|DS7PR01MB7879:EE_ X-MS-Office365-Filtering-Correlation-Id: 8d4e0be1-66d3-4b09-182c-08dcd12ca5f4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: =?utf-8?B?eWFTWjl3a2dtL0VFNFBoUnAvalk2bUtiVE9hb3dRZWY0TkRaVEMzeit0eWNm?= =?utf-8?B?MEpDdzRjQ2UrNytSNmtNZWQyRUVnMkpIVWVQQnE1L3NWSC9pUEZQVWRvNjZD?= =?utf-8?B?Qy9GdzNHSVhUNjF2U2Q2Q1ZFSHU1alpONUpmZmJpN3BXbmZVOWJwblFyVkgz?= =?utf-8?B?dFdpNjhmVlFOSkVXcmMrNjdhdlBKRGpyNHh0K1BBVWczSnQ5Y2ZLTHBqQ010?= =?utf-8?B?dVdvMUpueXMzVnpKVFZVRjlHOUlXOEY4a21zTmVsVit6cnlINHdsTWpLV2Q1?= =?utf-8?B?MWhmZTF4YlRGb3FLaGZINFVhZHdLNE03TEt1Vm16VWJtRHg2K29hVDltdXRz?= =?utf-8?B?bGJURjc1d3R5dTRsMG0yQnZOYnphVGNrb2pIcWNkOGlBYUxaYU9UeWVXRDlq?= =?utf-8?B?TXAzUHFvNkYvTjFtSlAyd3ZtTElwMklOOU92Z0EzZGYvWTFtUDZuZktXVWk4?= =?utf-8?B?TnZ6NzFsZ0NjL05YekpESERmZEltMm5Ta2xKejBZTmxKU005a3ROaVZuTnAw?= =?utf-8?B?TlRBUU5xOUViQ2wvMzhrdW9XR2FvbkQyT3F6T0kwWHZMZzFINWpxMFhrdkIy?= =?utf-8?B?bVRkL2lIRmEyWExDVlZRemVaOHg1QVQvNldUUFBBWUY3cG1IQldzdjlEcEJu?= =?utf-8?B?TTdqT1dKNGJZNmttV2Y2Ym1vTTFtd1BXZHZaUEExc1g0OStJeUdNNTlESExv?= =?utf-8?B?Z1ZCUFp6MnFtRzlWanFtNVJNckJMMDFIcnlDczczQS96ZmZiMllYVTRxcTdB?= =?utf-8?B?SE5ob202UWZab1RqcVhLY2dlMzRnM3NFbjUyNE84Z0J3aVhpall2dW9Ld3VB?= =?utf-8?B?cWZMYjdXOEV3K2k4Skx0WklmdXpEZjF5NndqRHdSTm9CbEJFR1dOUitQSElC?= =?utf-8?B?TVhuK1ZtTXlkUHpzUFBXTEZLZE8xaS9BWWczQ2V1ckZMdGVGUlZBSVRYTjl5?= =?utf-8?B?T3dzWGlkSi9VVFZWUnBKRUVrbEpRbHZzN1VidXppK1Z5WU1zYlpnWk1SeGZk?= =?utf-8?B?YjFMaVk2YzVaeTJXZkVqc0VYQTNKT3J6YkUwanRLUzZiNWhYTjcvSXQ5cGhK?= =?utf-8?B?cmNuMGg5VWlaN3FtVGd4MVdlbnVkL1ByTGRENFU4QjB6ajY5aEpPMnNQQW5C?= =?utf-8?B?Nk9jTWtoOTVKVHVUeU4vL2xUQkV3KzFpZk1oRUplcVpLNXZENHVqKzJORUwr?= =?utf-8?B?Q1dsN3RNaUlidVhVenoybCtReWptQXZmdHJoZjRQNmRwaUtyVlhqeFY3RHpt?= =?utf-8?B?SW9rTmNKcHdUWllqMDJFVlh2RWlCVmVZYll4VUp2ZEFzQnZrYnRUeTJwZWFp?= =?utf-8?B?S0JHdTUvL3p6THUzcEQ1WkJ6VzI5N2VaelBpTElCZWd1VUl2aXpTYzVyTEsy?= =?utf-8?B?eVRxaVdGRmgweW1wL01QRW9Ua3YzU0gyTm1KWUhCQ2RSc1Bvc1FBNmg4WTRx?= =?utf-8?B?a0FBcFpPWnN5YUtWL2pzS3Qyck9HWGZlMGl2clhaVllzTitqemdScU5lcVM3?= =?utf-8?B?c1lxS1RwY3FTL0dUTHF5bEJ3dnNxd3drNDNyZU1vZ29IS2ROSDZwNjR1aUQx?= =?utf-8?B?MU8vMGNsWnVIQXljN0tqNkt4T3NuVDViWDlKdFA2VmRHMERlc3pTK25LT3cy?= =?utf-8?B?TTh0eU1qbVJxVHlBa3RHK3JBNFEvdE9xUFo0Wm80a0Yvd2t1YVdaSEZLcmRC?= =?utf-8?B?YmQwdGE5WHNKcWhnVTFBYVRGdkoyRXRJZW9SODdnZkJYdDlsK0ZoY09wYVdh?= =?utf-8?Q?CYEw0EQmJK67pOGJPQ=3D?= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VThJSm90L2FKL0ViTWtTL1pTcWRWV1JjOWo4U21iRlJlSjhiR0pJWjBFdEYr?= =?utf-8?B?WjlQQi84Mi9JYVh1WERXampialJvUnlzRC9aMTdlbUd3T2paYU1CM21VajZk?= =?utf-8?B?UWU0MDBVcXFINldVK0VYeWM4dWpuWmFZK3hmYXFJRlBPckhtUk1rUUgwajM0?= =?utf-8?B?RXRqTllCUVpqajZYS21CbklDZkZ0MVRNb3grUzgwOTY5NG9QU3VWazR3UmtN?= =?utf-8?B?WHlsdDdPWmtsc2x3YWdxSGhhNGZmK3F0RkU3ZGVQMVMzUUM1R2hZajgwaFhz?= =?utf-8?B?MXVjVlUxcDRmTjNYWm1Ud09SV2dKeXlTeHVuQ0hvQjdiVDNKUzBkRW4vME8x?= =?utf-8?B?YnRJRHhWNnVoZzJUVVlkdlM4bDZDVkpYdkxDWktnMzBTM1AzNmFFOGJUaDZq?= =?utf-8?B?SUd3QVNGRUJRZWluK3UyTnBXYlppVW1jS3pnQ24yYzV6a240Tk1zczVmWXpO?= =?utf-8?B?Qm1oazEzcFJvY3Rza1lFS0tmYXpVS0Q5YTFsM2dvMVdNcEozb2xUVzNIVkpJ?= =?utf-8?B?Ny9RTEVKV0h2aUNrNEQ4aHdkcnNUalhLS1UzVkZwR2RnOUJQWVZMaVlySVNt?= =?utf-8?B?RWR4K3FqekVjTHVCMjBobHNVa2xzUFRhVUdVaUxZdnhvTkhNUEhrRnlLOHA5?= =?utf-8?B?aWczNkFielRBQjk0dEFFVEFQcytQMHk2dEloMTgzYWVja1E2OHhJSFY4U3hF?= =?utf-8?B?eGE4czRvZUw4K1R3ZzFaaDRubGl2UkJYcFJ2WGlHT2JFMmhSdUwxME54WnhO?= =?utf-8?B?blY1MDRxeTdVVVh1REN1V0ZuWFZWVE1Kakpjcm03dnZBU2s0R1NreCt6K2p3?= =?utf-8?B?NXhKWWExTTFxbUFKN25wY1F6SVFmbjZINUhEaGpSK1hFaTQrbUZsckNkNkx1?= =?utf-8?B?akh1T0ZFV0p5eVZqZnNEK3kwWjAxdEVTdkFuS3BLSmNaQ3FYQ3lYUzZWMmlW?= =?utf-8?B?NmtqWENKenMyR0tTckQyeE10d2JuWWtSTStKSUZIOW9YbjVqczQrcWVqVUIx?= =?utf-8?B?V0FOV0xBWFJyNHQ1WHJSUW9BaHNTdDlYNVJ6UVZobU1XSzdpbW5WbmdRSUI0?= =?utf-8?B?Q3VVc1BnTGdpME1zd2NTQW0yeEUvcTNCM29PN1FOT21mVlQzVVA4OHJmcXhh?= =?utf-8?B?bHlndmFtRHFhVlBQd2tZcWUvdU1Jc2tJalRzSTlYbVRuUFdYZGc2dVp2Y1dD?= =?utf-8?B?dmlmVnVWMDlHMjI0MU9INkV3TlJMcXd2R2UrcUF3SEU5emdGckx0SjRQQkFF?= =?utf-8?B?dStDQjhYeDZZV01RaGtXdmZRc085OXRQS005Q2plRzhXME55aXlheHBRTXJh?= =?utf-8?B?TStWd2tpTVQrL1g1ZDdSYzhhWVU2MGhsVm80RFJOd01yL01IcHZ6eU1BL0hX?= =?utf-8?B?N3Z3cW1XUm1ncjZBaEwxM1Zyb2FVaDE4YStsajl5bDVMMjFzczVqZnUwYkVq?= =?utf-8?B?UStRaFpLZ0owZTVuMUxKK0s3ZE8weTR4ZWkxd0xLQlhuQ2xoUVFLRzZML3JD?= =?utf-8?B?enNwaVBGUkZRZzNxWFAreUFPSnNUK05JZ05OaWVXdW5peVAzQm1ZUFRWWThN?= =?utf-8?B?cFhkMkJBYVY3TmROZXY4anBsSkNLbmVWNW1ES2ExdWxzeXVkUnJBVGJSQ3Bz?= =?utf-8?B?dkNPdDhuWEI2UHgyK3RSd3JXeXgvWjV3T2c5emRKRFIvUzI1THJpSW9TZmVF?= =?utf-8?B?TU5DU0VreTFNSlhwRFhmU3VVT2RqVVdYYkROZE1pREJDcHphQldOVW14NGtt?= =?utf-8?B?ZmRZcU5UVHlYSzN4MzhHMnZlWVh6eTlsb1JNeENMWDc4a1BkTk00d3ZkTzIw?= =?utf-8?B?dDk3YXI4Q3htWVpFUjU3eVJMQUZWdG5aVytQSWRoME5HZnFWbWdreE1PY2VR?= =?utf-8?B?ZU5iSnp4RFltMEVzYm9GYmFXd1RoWWdDZDFycVQ0MXNjOXRMbTF1TzV6c2Vs?= =?utf-8?B?cEd0OFZnTVNZTGRGaVIxMzNId1BmRmZwakw0aFJSVWhqa2pIRnc4eklqOEdS?= =?utf-8?B?dzdjWWljVjdiZFAzbGxzWmRzZDE1Rnp4WWwwN3dsNzhlQ2tNQ3JJaW12U1Ni?= =?utf-8?B?MTF0NTdVTVlReEVKMGJRWEdwQ1d3WjBVTThuT0lieDV5dHJORjViOE1QSUJt?= =?utf-8?B?SjZlSXhGaGNzRjhyVmJ2Wjhmc2Z0R1poVFBPQ2svUit0cDdxWXlxZWQydWxs?= =?utf-8?Q?mTHMxLQ+VtuQdGkKY8p25Qw=3D?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8d4e0be1-66d3-4b09-182c-08dcd12ca5f4 X-MS-Exchange-CrossTenant-AuthSource: PH0PR01MB7287.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Sep 2024 00:08:07.8894 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: q9RAyoQJHSvQ58KaS4bbfKUSoGVnzVGPa73U3KWoxFwWrge3d0iWauapXU/lObjOVpoNHDpWha0WaziZ6u8jp77khhSz60mpGyf+f6yMFfk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR01MB7879 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Mon, 09 Sep 2024 17:08:13 -0700 Resent-From: nhi@os.amperecomputing.com Reply-To: devel@edk2.groups.io,nhi@os.amperecomputing.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: vcYcYgs7alJjoolAithjIFU7x7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240830 header.b=FM9QmLcf; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=pass (policy=none) header.from=groups.io Hi Sami, On 9/9/2024 3:00 PM, Sami Mujawar via groups.io wrote: > Hi Nhi, Sam, >=20 > Apologies, this slipped off the radar. >=20 > The changes look good to me. > Is it possible to submit a pull request, please? I've integrated Sam's patch and changed the default uni values to "Not Set". https://github.com/tianocore/edk2/pull/6181 Regards, Nhi >=20 > Regards, >=20 > Sami Mujawar >=20 > From: Nhi Pham OS > Date: Friday 6 September 2024 at 18:38 > To: "devel@edk2.groups.io" , Sam Kaynor , "rebecca@bsdio.com" > Cc: Leif Lindholm , Ard Biesheuvel , Sami Mujawar > Subject: Re: [edk2-devel] [PATCH v1 0/1] ArmPkg/Smbios: Changing default = uni values to "" >=20 > Hi, >=20 > It seems that this patch has been left unattended. >=20 > The empty string "" may be ambiguous, as it could imply that the string i= s valid but contains no characters, or it has not been filled. On Ampere pl= atforms, I utilize "Not Set" to avoid this confusion, which is effective fo= r FWTS. >=20 > Regards, > Nhi >=20 > ________________________________ > From: devel@edk2.groups.io on behalf of Sam Kaynor= via groups.io > Sent: Wednesday, November 9, 2022 10:10 PM > To: devel@edk2.groups.io > Cc: Sam Kaynor ; Leif Lindholm ; Ard Biesheuvel ; Sami Mujawar > Subject: [edk2-devel] [PATCH v1 0/1] ArmPkg/Smbios: Changing default uni = values to "" >=20 > Current default values in uni files are set to "Not Specified". This > value causes errors in DMI tables when running FWTS tests. To avoid > these errors and align more closely with the SMBIOS spec, the default > value is changed from "Not Specified" to empty string "". >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4066 >=20 > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Cc: Sami Mujawar > Signed-off-by: Sam Kaynor >=20 > Sam Kaynor (1): > ArmPkg: Smbios: UNI file default values >=20 > ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClassStrings.un= i | 12 ++++++------ > ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendor.uni = | 8 ++++---- > ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturer.uni = | 12 ++++++------ > ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturer.u= ni | 14 +++++++------- > ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturer.uni= | 10 +++++----- > 5 files changed, 28 insertions(+), 28 deletions(-) >=20 > -- > 2.34.1 >=20 >=20 >=20 > -=3D-=3D-=3D-=3D-=3D-=3D > Groups.io Links: You receive all messages sent to this group. > View/Reply Online (#96133): https://edk2.groups.io/g/devel/message/96133 > Mute This Topic: https://groups.io/mt/94914657/5228573 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub [nhi@os.amperecomputing= .com] > -=3D-=3D-=3D-=3D-=3D-=3D >=20 >=20 >=20 >=20 >=20 >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#120536): https://edk2.groups.io/g/devel/message/120536 Mute This Topic: https://groups.io/mt/94914657/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-