From: "Laszlo Ersek" <lersek@redhat.com>
To: Dandan Bi <dandan.bi@intel.com>, devel@edk2.groups.io
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>,
Leif Lindholm <leif@nuviainc.com>
Subject: Re: [patch 04/28] ArmVirtPkg: Consume RegisterFilterLibNull instance
Date: Tue, 16 Mar 2021 17:38:03 +0100 [thread overview]
Message-ID: <92269a47-54aa-8458-9ceb-912789559447@redhat.com> (raw)
In-Reply-To: <20210315035844.32756-5-dandan.bi@intel.com>
Hi Dandan,
On 03/15/21 04:58, Dandan Bi wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246
>
> Add RegisterFilterLibNull in dsc which will be consumed
> by IoLib and BaseLib.
>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> ---
> ArmVirtPkg/ArmVirt.dsc.inc | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc
> index d9abadbe70..4d4ebc5f0c 100644
> --- a/ArmVirtPkg/ArmVirt.dsc.inc
> +++ b/ArmVirtPkg/ArmVirt.dsc.inc
> @@ -51,10 +51,11 @@
> PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/BasePeCoffGetEntryPointLib.inf
> PeCoffLib|MdePkg/Library/BasePeCoffLib/BasePeCoffLib.inf
> IoLib|MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsicArmVirt.inf
> UefiDecompressLib|MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLib.inf
> CpuLib|MdePkg/Library/BaseCpuLib/BaseCpuLib.inf
> + RegisterFilterLib|MdePkg/Library/RegisterFilterLibNull/RegisterFilterLibNull.inf
>
> UefiLib|MdePkg/Library/UefiLib/UefiLib.inf
> HobLib|ArmVirtPkg/Library/ArmVirtDxeHobLib/ArmVirtDxeHobLib.inf
> UefiRuntimeServicesTableLib|MdePkg/Library/UefiRuntimeServicesTableLib/UefiRuntimeServicesTableLib.inf
> DevicePathLib|MdePkg/Library/UefiDevicePathLibDevicePathProtocol/UefiDevicePathLibDevicePathProtocol.inf
>
your git setup does not include the setting for formatting the @@ hunk
headers into the patches. This makes it more difficult for me to
determine which [LibraryClasses] section is being modified. If you run
SetupGit.py, that should take care of the setting. Please fix this.
Anyway, it appears that [LibraryClasses.common] is the section being
modified, so that should be OK.
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Thanks
Laszlo
next prev parent reply other threads:[~2021-03-16 16:38 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-15 3:58 [patch 00/28] Add a new library class RegisterFilterLib in edk2 to filter/trace port IO/MMIO/MSR access Dandan Bi
2021-03-15 3:58 ` [patch 01/28] MdePkg: Add RegisterFilterLib class and NULL instance Dandan Bi
2021-03-15 5:21 ` [edk2-devel] " Abner Chang
2021-03-15 12:03 ` Dandan Bi
2021-03-15 3:58 ` [patch 02/28] ArmPkg: Consume RegisterFilterLibNull instance Dandan Bi
2021-03-15 3:58 ` [patch 03/28] ArmPlatformPkg: " Dandan Bi
2021-03-15 3:58 ` [patch 04/28] ArmVirtPkg: " Dandan Bi
2021-03-16 16:38 ` Laszlo Ersek [this message]
2021-03-15 3:58 ` [patch 05/28] CryptoPkg: " Dandan Bi
2021-03-15 3:58 ` [patch 06/28] DynamicTablesPkg: " Dandan Bi
2021-03-15 3:58 ` [patch 07/28] EmbeddedPkg: " Dandan Bi
2021-03-15 3:58 ` [patch 08/28] EmulatorPkg: " Dandan Bi
2021-03-15 3:58 ` [patch 09/28] FatPkg: " Dandan Bi
2021-03-15 3:58 ` [patch 10/28] FmpDevicePkg: " Dandan Bi
2021-03-15 3:58 ` [patch 11/28] IntelFsp2Pkg: " Dandan Bi
2021-03-15 4:09 ` Chiu, Chasel
2021-03-15 3:58 ` [patch 12/28] IntelFsp2WrapperPkg: " Dandan Bi
2021-03-15 4:09 ` Chiu, Chasel
2021-03-15 3:58 ` [patch 13/28] MdeModulePkg: " Dandan Bi
2021-03-15 6:02 ` Wu, Hao A
2021-03-15 3:58 ` [patch 14/28] MdePkg: " Dandan Bi
2021-03-15 3:58 ` [patch 15/28] NetworkPkg: " Dandan Bi
2021-03-15 3:58 ` [patch 16/28] OvmfPkg: " Dandan Bi
2021-03-16 16:42 ` Laszlo Ersek
2021-03-15 3:58 ` [patch 17/28] PcAtChipsetPkg: " Dandan Bi
2021-03-15 3:58 ` [patch 18/28] RedfishPkg: " Dandan Bi
2021-03-15 5:21 ` Abner Chang
2021-03-15 5:27 ` Nickle Wang
2021-03-15 3:58 ` [patch 19/28] SecurityPkg: " Dandan Bi
2021-03-15 3:58 ` [patch 20/28] ShellPkg: " Dandan Bi
2021-03-16 8:08 ` Gao, Zhichao
2021-03-15 3:58 ` [patch 21/28] SignedCapsulePkg: " Dandan Bi
2021-03-15 3:58 ` [patch 22/28] SourceLevelDebugPkg: " Dandan Bi
2021-03-15 6:03 ` Wu, Hao A
2021-03-15 3:58 ` [patch 23/28] StandaloneMmPkg: " Dandan Bi
2021-03-15 3:58 ` [patch 24/28] UefiCpuPkg: " Dandan Bi
2021-03-16 16:42 ` Laszlo Ersek
2021-03-15 3:58 ` [patch 25/28] UefiPayloadPkg: " Dandan Bi
2021-03-15 16:06 ` Ma, Maurice
2021-03-15 3:58 ` [patch 26/28] UnitTestFrameworkPkg: " Dandan Bi
2021-03-15 3:58 ` [patch 27/28] MdePkg/IoLib: Filter/trace port IO/MMIO access Dandan Bi
2021-03-15 3:58 ` [patch 28/28] MdePkg/Baseib: Filter/trace MSR access for IA32/X64 Dandan Bi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=92269a47-54aa-8458-9ceb-912789559447@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox