From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.groups.io with SMTP id smtpd.web08.1920.1615912698969981470 for ; Tue, 16 Mar 2021 09:38:19 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Yj3g9Eo0; spf=pass (domain: redhat.com, ip: 63.128.21.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1615912693; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Yd22vS1WtpbP2YfrGKG3N74YmcGbML9Mu/8AfuA86lw=; b=Yj3g9Eo027i4FeIiIwqYq34JnCQCGlp19NF2+GaI/kCjP1yp4dVc2JTUj+RuX+ChQwrIFQ VzEN9SCRgEKbNTND3Z9ZIM3WR4iRCyaa9xL8x6CkQX8YReNqi6SIOB7IUHQFJHvHMpgPHZ SYkp9ZHUmGQP0tuhC81KQiyLw2edKDs= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-588-QmZcaRh9O0GtV8AflBCNqg-1; Tue, 16 Mar 2021 12:38:06 -0400 X-MC-Unique: QmZcaRh9O0GtV8AflBCNqg-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 19EAA760C1; Tue, 16 Mar 2021 16:38:05 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-114-138.ams2.redhat.com [10.36.114.138]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1234460CCC; Tue, 16 Mar 2021 16:38:03 +0000 (UTC) Subject: Re: [patch 04/28] ArmVirtPkg: Consume RegisterFilterLibNull instance To: Dandan Bi , devel@edk2.groups.io Cc: Ard Biesheuvel , Leif Lindholm References: <20210315035844.32756-1-dandan.bi@intel.com> <20210315035844.32756-5-dandan.bi@intel.com> From: "Laszlo Ersek" Message-ID: <92269a47-54aa-8458-9ceb-912789559447@redhat.com> Date: Tue, 16 Mar 2021 17:38:03 +0100 MIME-Version: 1.0 In-Reply-To: <20210315035844.32756-5-dandan.bi@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Hi Dandan, On 03/15/21 04:58, Dandan Bi wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 > > Add RegisterFilterLibNull in dsc which will be consumed > by IoLib and BaseLib. > > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: Leif Lindholm > Signed-off-by: Dandan Bi > --- > ArmVirtPkg/ArmVirt.dsc.inc | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc > index d9abadbe70..4d4ebc5f0c 100644 > --- a/ArmVirtPkg/ArmVirt.dsc.inc > +++ b/ArmVirtPkg/ArmVirt.dsc.inc > @@ -51,10 +51,11 @@ > PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/BasePeCoffGetEntryPointLib.inf > PeCoffLib|MdePkg/Library/BasePeCoffLib/BasePeCoffLib.inf > IoLib|MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsicArmVirt.inf > UefiDecompressLib|MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLib.inf > CpuLib|MdePkg/Library/BaseCpuLib/BaseCpuLib.inf > + RegisterFilterLib|MdePkg/Library/RegisterFilterLibNull/RegisterFilterLibNull.inf > > UefiLib|MdePkg/Library/UefiLib/UefiLib.inf > HobLib|ArmVirtPkg/Library/ArmVirtDxeHobLib/ArmVirtDxeHobLib.inf > UefiRuntimeServicesTableLib|MdePkg/Library/UefiRuntimeServicesTableLib/UefiRuntimeServicesTableLib.inf > DevicePathLib|MdePkg/Library/UefiDevicePathLibDevicePathProtocol/UefiDevicePathLibDevicePathProtocol.inf > your git setup does not include the setting for formatting the @@ hunk headers into the patches. This makes it more difficult for me to determine which [LibraryClasses] section is being modified. If you run SetupGit.py, that should take care of the setting. Please fix this. Anyway, it appears that [LibraryClasses.common] is the section being modified, so that should be OK. Reviewed-by: Laszlo Ersek Thanks Laszlo