From: "Xiaoyu Lu" <xiaoyux.lu@intel.com>
To: Abner Chang <abner.chang@hpe.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: Daniel Schaefer <daniel.schaefer@hpe.com>,
"Wang, Jian J" <jian.j.wang@intel.com>,
Leif Lindholm <leif@nuviainc.com>,
Gilbert Chen <gilbert.chen@hpe.com>
Subject: Re: [edk2/master PATCH RISC-V CI Code Changes v1 05/11] CryptoPkg: Add RISC-V architecture for EDK2 CI.
Date: Tue, 17 Mar 2020 09:19:35 +0000 [thread overview]
Message-ID: <92382c01f37f43eeacc2386ff7717554@intel.com> (raw)
In-Reply-To: <20200306053620.12131-6-abner.chang@hpe.com>
Reviewed-by: Xiaoyu Lu <xiaoyux.lu@intel.com>
> -----Original Message-----
> From: Abner Chang [mailto:abner.chang@hpe.com]
> Sent: Friday, March 6, 2020 1:36 PM
> To: devel@edk2.groups.io
> Cc: abner.chang@hpe.com; Daniel Schaefer <daniel.schaefer@hpe.com>;
> Wang, Jian J <jian.j.wang@intel.com>; Lu, XiaoyuX <xiaoyux.lu@intel.com>;
> Leif Lindholm <leif@nuviainc.com>; Gilbert Chen <gilbert.chen@hpe.com>
> Subject: [edk2/master PATCH RISC-V CI Code Changes v1 05/11] CryptoPkg:
> Add RISC-V architecture for EDK2 CI.
>
> Add RISC-V architecture for EDK2 CI testing.
>
> BZ:2562:
> https://bugzilla.tianocore.org/show_bug.cgi?id=2562
>
> Signed-off-by: Abner Chang <abner.chang@hpe.com>
> Co-authored-by: Daniel Schaefer <daniel.schaefer@hpe.com>
>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Xiaoyu Lu <xiaoyux.lu@intel.com>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Gilbert Chen <gilbert.chen@hpe.com>
> ---
> CryptoPkg/CryptoPkg.dsc | 3 ++-
> CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf | 6 +++++-
> CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf | 4 ++++
> CryptoPkg/Library/BaseCryptLibNull/BaseCryptLibNull.inf | 3 ++-
> CryptoPkg/Library/BaseCryptLibOnProtocolPpi/DxeCryptLib.inf | 3 ++-
> CryptoPkg/Library/BaseCryptLibOnProtocolPpi/PeiCryptLib.inf | 3 ++-
> CryptoPkg/Library/OpensslLib/OpensslLib.inf | 2 ++
> CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf | 2 ++
> CryptoPkg/Library/TlsLib/TlsLib.inf | 4 ++--
> CryptoPkg/Library/TlsLibNull/TlsLibNull.inf | 4 ++--
> CryptoPkg/Library/Include/CrtLibSupport.h | 3 ++-
> 11 files changed, 27 insertions(+), 10 deletions(-)
>
> diff --git a/CryptoPkg/CryptoPkg.dsc b/CryptoPkg/CryptoPkg.dsc
> index 4cb37b1349..f79ff331cf 100644
> --- a/CryptoPkg/CryptoPkg.dsc
> +++ b/CryptoPkg/CryptoPkg.dsc
> @@ -3,6 +3,7 @@
> # PEIM, DXE Driver, and SMM Driver with all crypto services enabled.
>
> #
>
> # Copyright (c) 2009 - 2020, Intel Corporation. All rights reserved.<BR>
>
> +# Copyright (c) 2020, Hewlett Packard Enterprise Development LP. All rights
> reserved.<BR>
>
> # SPDX-License-Identifier: BSD-2-Clause-Patent
>
> #
>
> ##
>
> @@ -18,7 +19,7 @@
> PLATFORM_VERSION = 0.98
>
> DSC_SPECIFICATION = 0x00010005
>
> OUTPUT_DIRECTORY = Build/CryptoPkg
>
> - SUPPORTED_ARCHITECTURES = IA32|X64|ARM|AARCH64
>
> + SUPPORTED_ARCHITECTURES = IA32|X64|ARM|AARCH64|RISCV64
>
> BUILD_TARGETS = DEBUG|RELEASE|NOOPT
>
> SKUID_IDENTIFIER = DEFAULT
>
>
>
> diff --git a/CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf
> b/CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf
> index 1bbe4f435a..a63ad66b4f 100644
> --- a/CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf
> +++ b/CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf
> @@ -7,6 +7,7 @@
> # buffer overflow or integer overflow.
>
> #
>
> # Copyright (c) 2009 - 2019, Intel Corporation. All rights reserved.<BR>
>
> +# Copyright (c) 2020, Hewlett Packard Enterprise Development LP. All rights
> reserved.<BR>
>
> # SPDX-License-Identifier: BSD-2-Clause-Patent
>
> #
>
> ##
>
> @@ -23,7 +24,7 @@
> #
>
> # The following information is for reference only and not required by the
> build tools.
>
> #
>
> -# VALID_ARCHITECTURES = IA32 X64 ARM AARCH64
>
> +# VALID_ARCHITECTURES = IA32 X64 ARM AARCH64 RISCV64
>
> #
>
>
>
> [Sources]
>
> @@ -72,6 +73,9 @@
> [Sources.AARCH64]
>
> Rand/CryptRand.c
>
>
>
> +[Sources.RISCV64]
>
> + Rand/CryptRand.c
>
> +
>
> [Packages]
>
> MdePkg/MdePkg.dec
>
> CryptoPkg/CryptoPkg.dec
>
> diff --git a/CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf
> b/CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf
> index bff308a4f5..e5b8ececc1 100644
> --- a/CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf
> +++ b/CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf
> @@ -12,6 +12,7 @@
> # authenticode signature verification functions are not supported in this
> instance.
>
> #
>
> # Copyright (c) 2009 - 2019, Intel Corporation. All rights reserved.<BR>
>
> +# Copyright (c) 2020, Hewlett Packard Enterprise Development LP. All rights
> reserved.<BR>
>
> # SPDX-License-Identifier: BSD-2-Clause-Patent
>
> #
>
> ##
>
> @@ -77,6 +78,9 @@
> [Sources.AARCH64]
>
> Rand/CryptRand.c
>
>
>
> +[Sources.RISCV64]
>
> + Rand/CryptRand.c
>
> +
>
> [Packages]
>
> MdePkg/MdePkg.dec
>
> CryptoPkg/CryptoPkg.dec
>
> diff --git a/CryptoPkg/Library/BaseCryptLibNull/BaseCryptLibNull.inf
> b/CryptoPkg/Library/BaseCryptLibNull/BaseCryptLibNull.inf
> index 8f53b0dfd0..9b4991cbb0 100644
> --- a/CryptoPkg/Library/BaseCryptLibNull/BaseCryptLibNull.inf
> +++ b/CryptoPkg/Library/BaseCryptLibNull/BaseCryptLibNull.inf
> @@ -7,6 +7,7 @@
> # buffer overflow or integer overflow.
>
> #
>
> # Copyright (c) 2009 - 2020, Intel Corporation. All rights reserved.<BR>
>
> +# Copyright (c) 2020, Hewlett Packard Enterprise Development LP. All rights
> reserved.<BR>
>
> # SPDX-License-Identifier: BSD-2-Clause-Patent
>
> #
>
> ##
>
> @@ -23,7 +24,7 @@
> #
>
> # The following information is for reference only and not required by the
> build tools.
>
> #
>
> -# VALID_ARCHITECTURES = IA32 X64 ARM AARCH64
>
> +# VALID_ARCHITECTURES = IA32 X64 ARM AARCH64 RISCV64
>
> #
>
>
>
> [Sources]
>
> diff --git a/CryptoPkg/Library/BaseCryptLibOnProtocolPpi/DxeCryptLib.inf
> b/CryptoPkg/Library/BaseCryptLibOnProtocolPpi/DxeCryptLib.inf
> index 9282b0fd6b..baa4433cbe 100644
> --- a/CryptoPkg/Library/BaseCryptLibOnProtocolPpi/DxeCryptLib.inf
> +++ b/CryptoPkg/Library/BaseCryptLibOnProtocolPpi/DxeCryptLib.inf
> @@ -3,6 +3,7 @@
> # Protocol.
>
> #
>
> # Copyright (C) Microsoft Corporation. All rights reserved.
>
> +# Copyright (c) 2020, Hewlett Packard Enterprise Development LP. All rights
> reserved.<BR>
>
> # SPDX-License-Identifier: BSD-2-Clause-Patent
>
> #
>
> ##
>
> @@ -21,7 +22,7 @@
> #
>
> # The following information is for reference only and not required by the
> build tools.
>
> #
>
> -# VALID_ARCHITECTURES = IA32 X64 ARM AARCH64
>
> +# VALID_ARCHITECTURES = IA32 X64 ARM AARCH64 RISCV64
>
> #
>
>
>
> [Packages]
>
> diff --git a/CryptoPkg/Library/BaseCryptLibOnProtocolPpi/PeiCryptLib.inf
> b/CryptoPkg/Library/BaseCryptLibOnProtocolPpi/PeiCryptLib.inf
> index 5c56e3320e..038ca71890 100644
> --- a/CryptoPkg/Library/BaseCryptLibOnProtocolPpi/PeiCryptLib.inf
> +++ b/CryptoPkg/Library/BaseCryptLibOnProtocolPpi/PeiCryptLib.inf
> @@ -3,6 +3,7 @@
> # PPI.
>
> #
>
> # Copyright (C) Microsoft Corporation. All rights reserved.
>
> +# Copyright (c) 2020, Hewlett Packard Enterprise Development LP. All rights
> reserved.<BR>
>
> # SPDX-License-Identifier: BSD-2-Clause-Patent
>
> #
>
> ##
>
> @@ -20,7 +21,7 @@
> #
>
> # The following information is for reference only and not required by the
> build tools.
>
> #
>
> -# VALID_ARCHITECTURES = IA32 X64 ARM AARCH64
>
> +# VALID_ARCHITECTURES = IA32 X64 ARM AARCH64 RISCV64
>
> #
>
>
>
> [Packages]
>
> diff --git a/CryptoPkg/Library/OpensslLib/OpensslLib.inf
> b/CryptoPkg/Library/OpensslLib/OpensslLib.inf
> index 3fa52f5543..01ee665183 100644
> --- a/CryptoPkg/Library/OpensslLib/OpensslLib.inf
> +++ b/CryptoPkg/Library/OpensslLib/OpensslLib.inf
> @@ -2,6 +2,7 @@
> # This module provides OpenSSL Library implementation.
>
> #
>
> # Copyright (c) 2010 - 2019, Intel Corporation. All rights reserved.<BR>
>
> +# (C) Copyright 2020 Hewlett Packard Enterprise Development LP<BR>
>
> # SPDX-License-Identifier: BSD-2-Clause-Patent
>
> #
>
> ##
>
> @@ -661,6 +662,7 @@
> GCC:*_*_X64_CC_FLAGS = -U_WIN32 -U_WIN64 $(OPENSSL_FLAGS) -
> Wno-error=maybe-uninitialized -Wno-error=format -Wno-format -Wno-
> error=unused-but-set-variable -DNO_MSABI_VA_FUNCS
>
> GCC:*_*_ARM_CC_FLAGS = $(OPENSSL_FLAGS) -Wno-error=maybe-
> uninitialized -Wno-error=unused-but-set-variable
>
> GCC:*_*_AARCH64_CC_FLAGS = $(OPENSSL_FLAGS) -Wno-error=maybe-
> uninitialized -Wno-format -Wno-error=unused-but-set-variable
>
> + GCC:*_*_RISCV64_CC_FLAGS = $(OPENSSL_FLAGS) -Wno-error=format -
> Wno-error=maybe-uninitialized -Wno-format -Wno-error=unused-but-set-
> variable
>
> GCC:*_CLANG35_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized
>
> GCC:*_CLANG38_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized
>
> GCC:*_CLANGPDB_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized -
> Wno-error=incompatible-pointer-types -Wno-error=pointer-sign -Wno-
> error=implicit-function-declaration -Wno-error=ignored-pragma-optimize
>
> diff --git a/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf
> b/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf
> index f1f9fbb938..5c2206f6fb 100644
> --- a/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf
> +++ b/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf
> @@ -2,6 +2,7 @@
> # This module provides OpenSSL Library implementation.
>
> #
>
> # Copyright (c) 2010 - 2019, Intel Corporation. All rights reserved.<BR>
>
> +# (C) Copyright 2020 Hewlett Packard Enterprise Development LP<BR>
>
> # SPDX-License-Identifier: BSD-2-Clause-Patent
>
> #
>
> ##
>
> @@ -610,6 +611,7 @@
> GCC:*_*_X64_CC_FLAGS = -U_WIN32 -U_WIN64 $(OPENSSL_FLAGS) -
> Wno-error=maybe-uninitialized -Wno-error=format -Wno-format -Wno-
> error=unused-but-set-variable -DNO_MSABI_VA_FUNCS
>
> GCC:*_*_ARM_CC_FLAGS = $(OPENSSL_FLAGS) -Wno-error=maybe-
> uninitialized -Wno-error=unused-but-set-variable
>
> GCC:*_*_AARCH64_CC_FLAGS = $(OPENSSL_FLAGS) -Wno-error=maybe-
> uninitialized -Wno-format -Wno-error=unused-but-set-variable
>
> + GCC:*_*_RISCV64_CC_FLAGS = $(OPENSSL_FLAGS) -Wno-error=maybe-
> uninitialized -Wno-format -Wno-error=unused-but-set-variable
>
> GCC:*_CLANG35_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized
>
> GCC:*_CLANG38_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized
>
> GCC:*_CLANGPDB_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized -
> Wno-error=incompatible-pointer-types -Wno-error=pointer-sign -Wno-
> error=implicit-function-declaration -Wno-error=ignored-pragma-optimize
>
> diff --git a/CryptoPkg/Library/TlsLib/TlsLib.inf
> b/CryptoPkg/Library/TlsLib/TlsLib.inf
> index 2f3ce695c3..27209f4d7f 100644
> --- a/CryptoPkg/Library/TlsLib/TlsLib.inf
> +++ b/CryptoPkg/Library/TlsLib/TlsLib.inf
> @@ -2,7 +2,7 @@
> # SSL/TLS Wrapper Library Instance based on OpenSSL.
>
> #
>
> # Copyright (c) 2016 - 2018, Intel Corporation. All rights reserved.<BR>
>
> -# (C) Copyright 2016 Hewlett Packard Enterprise Development LP<BR>
>
> +# (C) Copyright 2016-2020 Hewlett Packard Enterprise Development LP<BR>
>
> # SPDX-License-Identifier: BSD-2-Clause-Patent
>
> #
>
> ##
>
> @@ -19,7 +19,7 @@
> #
>
> # The following information is for reference only and not required by the
> build tools.
>
> #
>
> -# VALID_ARCHITECTURES = IA32 X64 ARM AARCH64
>
> +# VALID_ARCHITECTURES = IA32 X64 ARM AARCH64 RISCV64
>
> #
>
>
>
> [Sources]
>
> diff --git a/CryptoPkg/Library/TlsLibNull/TlsLibNull.inf
> b/CryptoPkg/Library/TlsLibNull/TlsLibNull.inf
> index 33f0e7493f..b2920ddacf 100644
> --- a/CryptoPkg/Library/TlsLibNull/TlsLibNull.inf
> +++ b/CryptoPkg/Library/TlsLibNull/TlsLibNull.inf
> @@ -2,7 +2,7 @@
> # SSL/TLS Wrapper Null Library Instance.
>
> #
>
> # Copyright (c) 2016 - 2018, Intel Corporation. All rights reserved.<BR>
>
> -# (C) Copyright 2016 Hewlett Packard Enterprise Development LP<BR>
>
> +# (C) Copyright 2016-2020 Hewlett Packard Enterprise Development LP<BR>
>
> # SPDX-License-Identifier: BSD-2-Clause-Patent
>
> #
>
> ##
>
> @@ -19,7 +19,7 @@
> #
>
> # The following information is for reference only and not required by the
> build tools.
>
> #
>
> -# VALID_ARCHITECTURES = IA32 X64 ARM AARCH64
>
> +# VALID_ARCHITECTURES = IA32 X64 ARM AARCH64 RISCV64
>
> #
>
>
>
> [Sources]
>
> diff --git a/CryptoPkg/Library/Include/CrtLibSupport.h
> b/CryptoPkg/Library/Include/CrtLibSupport.h
> index 5a20ba636f..7a82f1d406 100644
> --- a/CryptoPkg/Library/Include/CrtLibSupport.h
> +++ b/CryptoPkg/Library/Include/CrtLibSupport.h
> @@ -3,6 +3,7 @@
> cryptographic library.
>
>
>
> Copyright (c) 2010 - 2019, Intel Corporation. All rights reserved.<BR>
>
> +Copyright (c) 2020, Hewlett Packard Enterprise Development LP. All rights
> reserved.<BR>
>
> SPDX-License-Identifier: BSD-2-Clause-Patent
>
>
>
> **/
>
> @@ -43,7 +44,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
>
>
> #define CONFIG_HEADER_BN_H
>
>
>
> -#if defined(MDE_CPU_X64) || defined(MDE_CPU_AARCH64) ||
> defined(MDE_CPU_IA64)
>
> +#if defined(MDE_CPU_X64) || defined(MDE_CPU_AARCH64) ||
> defined(MDE_CPU_IA64) || defined(MDE_CPU_RISCV64)
>
> //
>
> // With GCC we would normally use SIXTY_FOUR_BIT_LONG, but MSVC
> needs
>
> // SIXTY_FOUR_BIT, because 'long' is 32-bit and only 'long long' is
>
> --
> 2.25.0
next prev parent reply other threads:[~2020-03-17 9:19 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-06 5:36 [edk2/master PATCH RISC-V CI Code Changes v1 00/11] Necessary code changes for RISCV64 CI testing Abner Chang
2020-03-06 5:36 ` [edk2/master PATCH RISC-V CI Code Changes v1 01/11] FatPkg: Add RISC-V architecture for EDK2 CI Abner Chang
2020-03-12 5:39 ` [edk2-devel] " Ni, Ray
2020-03-12 6:27 ` Abner Chang
2020-03-12 6:47 ` Liming Gao
2020-03-20 1:16 ` Michael D Kinney
2020-03-20 3:28 ` Liming Gao
2020-03-20 3:49 ` Bob Feng
2020-03-12 7:07 ` Ni, Ray
2020-03-06 5:36 ` [edk2/master PATCH RISC-V CI Code Changes v1 02/11] FmpDevicePkg: " Abner Chang
2020-03-27 3:20 ` [edk2-devel] " Liming Gao
2020-03-06 5:36 ` [edk2/master PATCH RISC-V CI Code Changes v1 03/11] NetworkPkg: " Abner Chang
2020-03-06 5:36 ` [edk2/master PATCH RISC-V CI Code Changes v1 04/11] NetworkPkg/HttpBootDxe: " Abner Chang
2020-03-06 5:36 ` [edk2/master PATCH RISC-V CI Code Changes v1 05/11] CryptoPkg: " Abner Chang
2020-03-17 9:19 ` Xiaoyu Lu [this message]
2020-07-13 9:27 ` [edk2-devel] " Laszlo Ersek
2020-07-13 18:05 ` Laszlo Ersek
2020-07-14 1:13 ` Abner Chang
2020-07-22 0:58 ` Guomin Jiang
2020-03-06 5:36 ` [edk2/master PATCH RISC-V CI Code Changes v1 06/11] MdePkg/Include: Add RISC-V related definitions " Abner Chang
2020-03-06 5:36 ` [edk2/master PATCH RISC-V CI Code Changes v1 07/11] SecurityPkg: Security package changes for RISC-V " Abner Chang
2020-03-06 5:36 ` [edk2/master PATCH RISC-V CI Code Changes v1 08/11] ShellPkg: Shell " Abner Chang
2020-03-12 2:21 ` [edk2-devel] " Gao, Zhichao
2020-03-06 5:36 ` [edk2/master PATCH RISC-V CI Code Changes v1 09/11] UnitTestFrameworkPkg: Add RISC-V architecture " Abner Chang
2020-03-06 5:36 ` [edk2/master PATCH RISC-V CI Code Changes v1 10/11] MdePkg/DxeServicesLib: Add RISC-V architecture Abner Chang
2020-03-27 3:21 ` Liming Gao
2020-03-06 5:36 ` [edk2/master PATCH RISC-V CI Code Changes v1 11/11] MdeModulePkg: Use LockBoxNullLib for RISC-V Abner Chang
2020-03-19 8:01 ` [edk2-devel] " Dong, Eric
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=92382c01f37f43eeacc2386ff7717554@intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox