From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web10.1818.1584436779148498319 for ; Tue, 17 Mar 2020 02:19:39 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: xiaoyux.lu@intel.com) IronPort-SDR: 4CyKmsMdfO6TOGpQoIq3pqR4YJVYbkguYHmlzV7QhXe3g+gWME8kWnFHMrru8WV1s3r4T3xPvL O+ynygwgQB8A== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Mar 2020 02:19:38 -0700 IronPort-SDR: +Rygu6fYFAL4Ahfn6QW3K0dV3hthdUdhsn3y7adDPH4ULHXyxuMnHgAAD3vt5LWwWPSNpkNkjo rX408BcWV/dQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,563,1574150400"; d="scan'208";a="233442829" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga007.jf.intel.com with ESMTP; 17 Mar 2020 02:19:37 -0700 Received: from shsmsx603.ccr.corp.intel.com (10.109.6.143) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 17 Mar 2020 02:19:37 -0700 Received: from shsmsx603.ccr.corp.intel.com (10.109.6.143) by SHSMSX603.ccr.corp.intel.com (10.109.6.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 17 Mar 2020 17:19:35 +0800 Received: from shsmsx603.ccr.corp.intel.com ([10.109.6.143]) by SHSMSX603.ccr.corp.intel.com ([10.109.6.143]) with mapi id 15.01.1713.004; Tue, 17 Mar 2020 17:19:35 +0800 From: "Xiaoyu Lu" To: Abner Chang , "devel@edk2.groups.io" CC: Daniel Schaefer , "Wang, Jian J" , Leif Lindholm , Gilbert Chen Subject: Re: [edk2/master PATCH RISC-V CI Code Changes v1 05/11] CryptoPkg: Add RISC-V architecture for EDK2 CI. Thread-Topic: [edk2/master PATCH RISC-V CI Code Changes v1 05/11] CryptoPkg: Add RISC-V architecture for EDK2 CI. Thread-Index: AQHV835XHyJRKDMZXEumEgNXpuobzahMVrnA Date: Tue, 17 Mar 2020 09:19:35 +0000 Message-ID: <92382c01f37f43eeacc2386ff7717554@intel.com> References: <20200306053620.12131-1-abner.chang@hpe.com> <20200306053620.12131-6-abner.chang@hpe.com> In-Reply-To: <20200306053620.12131-6-abner.chang@hpe.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.36] MIME-Version: 1.0 Return-Path: xiaoyux.lu@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Xiaoyu Lu > -----Original Message----- > From: Abner Chang [mailto:abner.chang@hpe.com] > Sent: Friday, March 6, 2020 1:36 PM > To: devel@edk2.groups.io > Cc: abner.chang@hpe.com; Daniel Schaefer ; > Wang, Jian J ; Lu, XiaoyuX ; > Leif Lindholm ; Gilbert Chen > Subject: [edk2/master PATCH RISC-V CI Code Changes v1 05/11] CryptoPkg: > Add RISC-V architecture for EDK2 CI. >=20 > Add RISC-V architecture for EDK2 CI testing. >=20 > BZ:2562: > https://bugzilla.tianocore.org/show_bug.cgi?id=3D2562 >=20 > Signed-off-by: Abner Chang > Co-authored-by: Daniel Schaefer >=20 > Cc: Jian J Wang > Cc: Xiaoyu Lu > Cc: Leif Lindholm > Cc: Gilbert Chen > --- > CryptoPkg/CryptoPkg.dsc | 3 ++- > CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf | 6 +++++- > CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf | 4 ++++ > CryptoPkg/Library/BaseCryptLibNull/BaseCryptLibNull.inf | 3 ++- > CryptoPkg/Library/BaseCryptLibOnProtocolPpi/DxeCryptLib.inf | 3 ++- > CryptoPkg/Library/BaseCryptLibOnProtocolPpi/PeiCryptLib.inf | 3 ++- > CryptoPkg/Library/OpensslLib/OpensslLib.inf | 2 ++ > CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf | 2 ++ > CryptoPkg/Library/TlsLib/TlsLib.inf | 4 ++-- > CryptoPkg/Library/TlsLibNull/TlsLibNull.inf | 4 ++-- > CryptoPkg/Library/Include/CrtLibSupport.h | 3 ++- > 11 files changed, 27 insertions(+), 10 deletions(-) >=20 > diff --git a/CryptoPkg/CryptoPkg.dsc b/CryptoPkg/CryptoPkg.dsc > index 4cb37b1349..f79ff331cf 100644 > --- a/CryptoPkg/CryptoPkg.dsc > +++ b/CryptoPkg/CryptoPkg.dsc > @@ -3,6 +3,7 @@ > # PEIM, DXE Driver, and SMM Driver with all crypto services enabled. >=20 > # >=20 > # Copyright (c) 2009 - 2020, Intel Corporation. All rights reserved. >=20 > +# Copyright (c) 2020, Hewlett Packard Enterprise Development LP. All ri= ghts > reserved.
>=20 > # SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > # >=20 > ## >=20 > @@ -18,7 +19,7 @@ > PLATFORM_VERSION =3D 0.98 >=20 > DSC_SPECIFICATION =3D 0x00010005 >=20 > OUTPUT_DIRECTORY =3D Build/CryptoPkg >=20 > - SUPPORTED_ARCHITECTURES =3D IA32|X64|ARM|AARCH64 >=20 > + SUPPORTED_ARCHITECTURES =3D IA32|X64|ARM|AARCH64|RISCV64 >=20 > BUILD_TARGETS =3D DEBUG|RELEASE|NOOPT >=20 > SKUID_IDENTIFIER =3D DEFAULT >=20 >=20 >=20 > diff --git a/CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf > b/CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf > index 1bbe4f435a..a63ad66b4f 100644 > --- a/CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf > +++ b/CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf > @@ -7,6 +7,7 @@ > # buffer overflow or integer overflow. >=20 > # >=20 > # Copyright (c) 2009 - 2019, Intel Corporation. All rights reserved. >=20 > +# Copyright (c) 2020, Hewlett Packard Enterprise Development LP. All ri= ghts > reserved.
>=20 > # SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > # >=20 > ## >=20 > @@ -23,7 +24,7 @@ > # >=20 > # The following information is for reference only and not required by th= e > build tools. >=20 > # >=20 > -# VALID_ARCHITECTURES =3D IA32 X64 ARM AARCH64 >=20 > +# VALID_ARCHITECTURES =3D IA32 X64 ARM AARCH64 RISCV64 >=20 > # >=20 >=20 >=20 > [Sources] >=20 > @@ -72,6 +73,9 @@ > [Sources.AARCH64] >=20 > Rand/CryptRand.c >=20 >=20 >=20 > +[Sources.RISCV64] >=20 > + Rand/CryptRand.c >=20 > + >=20 > [Packages] >=20 > MdePkg/MdePkg.dec >=20 > CryptoPkg/CryptoPkg.dec >=20 > diff --git a/CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf > b/CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf > index bff308a4f5..e5b8ececc1 100644 > --- a/CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf > +++ b/CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf > @@ -12,6 +12,7 @@ > # authenticode signature verification functions are not supported in th= is > instance. >=20 > # >=20 > # Copyright (c) 2009 - 2019, Intel Corporation. All rights reserved. >=20 > +# Copyright (c) 2020, Hewlett Packard Enterprise Development LP. All ri= ghts > reserved.
>=20 > # SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > # >=20 > ## >=20 > @@ -77,6 +78,9 @@ > [Sources.AARCH64] >=20 > Rand/CryptRand.c >=20 >=20 >=20 > +[Sources.RISCV64] >=20 > + Rand/CryptRand.c >=20 > + >=20 > [Packages] >=20 > MdePkg/MdePkg.dec >=20 > CryptoPkg/CryptoPkg.dec >=20 > diff --git a/CryptoPkg/Library/BaseCryptLibNull/BaseCryptLibNull.inf > b/CryptoPkg/Library/BaseCryptLibNull/BaseCryptLibNull.inf > index 8f53b0dfd0..9b4991cbb0 100644 > --- a/CryptoPkg/Library/BaseCryptLibNull/BaseCryptLibNull.inf > +++ b/CryptoPkg/Library/BaseCryptLibNull/BaseCryptLibNull.inf > @@ -7,6 +7,7 @@ > # buffer overflow or integer overflow. >=20 > # >=20 > # Copyright (c) 2009 - 2020, Intel Corporation. All rights reserved. >=20 > +# Copyright (c) 2020, Hewlett Packard Enterprise Development LP. All ri= ghts > reserved.
>=20 > # SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > # >=20 > ## >=20 > @@ -23,7 +24,7 @@ > # >=20 > # The following information is for reference only and not required by th= e > build tools. >=20 > # >=20 > -# VALID_ARCHITECTURES =3D IA32 X64 ARM AARCH64 >=20 > +# VALID_ARCHITECTURES =3D IA32 X64 ARM AARCH64 RISCV64 >=20 > # >=20 >=20 >=20 > [Sources] >=20 > diff --git a/CryptoPkg/Library/BaseCryptLibOnProtocolPpi/DxeCryptLib.inf > b/CryptoPkg/Library/BaseCryptLibOnProtocolPpi/DxeCryptLib.inf > index 9282b0fd6b..baa4433cbe 100644 > --- a/CryptoPkg/Library/BaseCryptLibOnProtocolPpi/DxeCryptLib.inf > +++ b/CryptoPkg/Library/BaseCryptLibOnProtocolPpi/DxeCryptLib.inf > @@ -3,6 +3,7 @@ > # Protocol. >=20 > # >=20 > # Copyright (C) Microsoft Corporation. All rights reserved. >=20 > +# Copyright (c) 2020, Hewlett Packard Enterprise Development LP. All rig= hts > reserved.
>=20 > # SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > # >=20 > ## >=20 > @@ -21,7 +22,7 @@ > # >=20 > # The following information is for reference only and not required by th= e > build tools. >=20 > # >=20 > -# VALID_ARCHITECTURES =3D IA32 X64 ARM AARCH64 >=20 > +# VALID_ARCHITECTURES =3D IA32 X64 ARM AARCH64 RISCV64 >=20 > # >=20 >=20 >=20 > [Packages] >=20 > diff --git a/CryptoPkg/Library/BaseCryptLibOnProtocolPpi/PeiCryptLib.inf > b/CryptoPkg/Library/BaseCryptLibOnProtocolPpi/PeiCryptLib.inf > index 5c56e3320e..038ca71890 100644 > --- a/CryptoPkg/Library/BaseCryptLibOnProtocolPpi/PeiCryptLib.inf > +++ b/CryptoPkg/Library/BaseCryptLibOnProtocolPpi/PeiCryptLib.inf > @@ -3,6 +3,7 @@ > # PPI. >=20 > # >=20 > # Copyright (C) Microsoft Corporation. All rights reserved. >=20 > +# Copyright (c) 2020, Hewlett Packard Enterprise Development LP. All rig= hts > reserved.
>=20 > # SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > # >=20 > ## >=20 > @@ -20,7 +21,7 @@ > # >=20 > # The following information is for reference only and not required by th= e > build tools. >=20 > # >=20 > -# VALID_ARCHITECTURES =3D IA32 X64 ARM AARCH64 >=20 > +# VALID_ARCHITECTURES =3D IA32 X64 ARM AARCH64 RISCV64 >=20 > # >=20 >=20 >=20 > [Packages] >=20 > diff --git a/CryptoPkg/Library/OpensslLib/OpensslLib.inf > b/CryptoPkg/Library/OpensslLib/OpensslLib.inf > index 3fa52f5543..01ee665183 100644 > --- a/CryptoPkg/Library/OpensslLib/OpensslLib.inf > +++ b/CryptoPkg/Library/OpensslLib/OpensslLib.inf > @@ -2,6 +2,7 @@ > # This module provides OpenSSL Library implementation. >=20 > # >=20 > # Copyright (c) 2010 - 2019, Intel Corporation. All rights reserved. >=20 > +# (C) Copyright 2020 Hewlett Packard Enterprise Development LP
>=20 > # SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > # >=20 > ## >=20 > @@ -661,6 +662,7 @@ > GCC:*_*_X64_CC_FLAGS =3D -U_WIN32 -U_WIN64 $(OPENSSL_FLAGS) - > Wno-error=3Dmaybe-uninitialized -Wno-error=3Dformat -Wno-format -Wno- > error=3Dunused-but-set-variable -DNO_MSABI_VA_FUNCS >=20 > GCC:*_*_ARM_CC_FLAGS =3D $(OPENSSL_FLAGS) -Wno-error=3Dmaybe- > uninitialized -Wno-error=3Dunused-but-set-variable >=20 > GCC:*_*_AARCH64_CC_FLAGS =3D $(OPENSSL_FLAGS) -Wno-error=3Dmaybe- > uninitialized -Wno-format -Wno-error=3Dunused-but-set-variable >=20 > + GCC:*_*_RISCV64_CC_FLAGS =3D $(OPENSSL_FLAGS) -Wno-error=3Dformat - > Wno-error=3Dmaybe-uninitialized -Wno-format -Wno-error=3Dunused-but-set- > variable >=20 > GCC:*_CLANG35_*_CC_FLAGS =3D -std=3Dc99 -Wno-error=3Duninitialized >=20 > GCC:*_CLANG38_*_CC_FLAGS =3D -std=3Dc99 -Wno-error=3Duninitialized >=20 > GCC:*_CLANGPDB_*_CC_FLAGS =3D -std=3Dc99 -Wno-error=3Duninitialized - > Wno-error=3Dincompatible-pointer-types -Wno-error=3Dpointer-sign -Wno- > error=3Dimplicit-function-declaration -Wno-error=3Dignored-pragma-optimiz= e >=20 > diff --git a/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf > b/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf > index f1f9fbb938..5c2206f6fb 100644 > --- a/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf > +++ b/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf > @@ -2,6 +2,7 @@ > # This module provides OpenSSL Library implementation. >=20 > # >=20 > # Copyright (c) 2010 - 2019, Intel Corporation. All rights reserved. >=20 > +# (C) Copyright 2020 Hewlett Packard Enterprise Development LP
>=20 > # SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > # >=20 > ## >=20 > @@ -610,6 +611,7 @@ > GCC:*_*_X64_CC_FLAGS =3D -U_WIN32 -U_WIN64 $(OPENSSL_FLAGS) - > Wno-error=3Dmaybe-uninitialized -Wno-error=3Dformat -Wno-format -Wno- > error=3Dunused-but-set-variable -DNO_MSABI_VA_FUNCS >=20 > GCC:*_*_ARM_CC_FLAGS =3D $(OPENSSL_FLAGS) -Wno-error=3Dmaybe- > uninitialized -Wno-error=3Dunused-but-set-variable >=20 > GCC:*_*_AARCH64_CC_FLAGS =3D $(OPENSSL_FLAGS) -Wno-error=3Dmaybe- > uninitialized -Wno-format -Wno-error=3Dunused-but-set-variable >=20 > + GCC:*_*_RISCV64_CC_FLAGS =3D $(OPENSSL_FLAGS) -Wno-error=3Dmaybe- > uninitialized -Wno-format -Wno-error=3Dunused-but-set-variable >=20 > GCC:*_CLANG35_*_CC_FLAGS =3D -std=3Dc99 -Wno-error=3Duninitialized >=20 > GCC:*_CLANG38_*_CC_FLAGS =3D -std=3Dc99 -Wno-error=3Duninitialized >=20 > GCC:*_CLANGPDB_*_CC_FLAGS =3D -std=3Dc99 -Wno-error=3Duninitialized - > Wno-error=3Dincompatible-pointer-types -Wno-error=3Dpointer-sign -Wno- > error=3Dimplicit-function-declaration -Wno-error=3Dignored-pragma-optimiz= e >=20 > diff --git a/CryptoPkg/Library/TlsLib/TlsLib.inf > b/CryptoPkg/Library/TlsLib/TlsLib.inf > index 2f3ce695c3..27209f4d7f 100644 > --- a/CryptoPkg/Library/TlsLib/TlsLib.inf > +++ b/CryptoPkg/Library/TlsLib/TlsLib.inf > @@ -2,7 +2,7 @@ > # SSL/TLS Wrapper Library Instance based on OpenSSL. >=20 > # >=20 > # Copyright (c) 2016 - 2018, Intel Corporation. All rights reserved. >=20 > -# (C) Copyright 2016 Hewlett Packard Enterprise Development LP
>=20 > +# (C) Copyright 2016-2020 Hewlett Packard Enterprise Development LP
>=20 > # SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > # >=20 > ## >=20 > @@ -19,7 +19,7 @@ > # >=20 > # The following information is for reference only and not required by th= e > build tools. >=20 > # >=20 > -# VALID_ARCHITECTURES =3D IA32 X64 ARM AARCH64 >=20 > +# VALID_ARCHITECTURES =3D IA32 X64 ARM AARCH64 RISCV64 >=20 > # >=20 >=20 >=20 > [Sources] >=20 > diff --git a/CryptoPkg/Library/TlsLibNull/TlsLibNull.inf > b/CryptoPkg/Library/TlsLibNull/TlsLibNull.inf > index 33f0e7493f..b2920ddacf 100644 > --- a/CryptoPkg/Library/TlsLibNull/TlsLibNull.inf > +++ b/CryptoPkg/Library/TlsLibNull/TlsLibNull.inf > @@ -2,7 +2,7 @@ > # SSL/TLS Wrapper Null Library Instance. >=20 > # >=20 > # Copyright (c) 2016 - 2018, Intel Corporation. All rights reserved. >=20 > -# (C) Copyright 2016 Hewlett Packard Enterprise Development LP
>=20 > +# (C) Copyright 2016-2020 Hewlett Packard Enterprise Development LP
>=20 > # SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > # >=20 > ## >=20 > @@ -19,7 +19,7 @@ > # >=20 > # The following information is for reference only and not required by th= e > build tools. >=20 > # >=20 > -# VALID_ARCHITECTURES =3D IA32 X64 ARM AARCH64 >=20 > +# VALID_ARCHITECTURES =3D IA32 X64 ARM AARCH64 RISCV64 >=20 > # >=20 >=20 >=20 > [Sources] >=20 > diff --git a/CryptoPkg/Library/Include/CrtLibSupport.h > b/CryptoPkg/Library/Include/CrtLibSupport.h > index 5a20ba636f..7a82f1d406 100644 > --- a/CryptoPkg/Library/Include/CrtLibSupport.h > +++ b/CryptoPkg/Library/Include/CrtLibSupport.h > @@ -3,6 +3,7 @@ > cryptographic library. >=20 >=20 >=20 > Copyright (c) 2010 - 2019, Intel Corporation. All rights reserved.
>=20 > +Copyright (c) 2020, Hewlett Packard Enterprise Development LP. All right= s > reserved.
>=20 > SPDX-License-Identifier: BSD-2-Clause-Patent >=20 >=20 >=20 > **/ >=20 > @@ -43,7 +44,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent >=20 >=20 > #define CONFIG_HEADER_BN_H >=20 >=20 >=20 > -#if defined(MDE_CPU_X64) || defined(MDE_CPU_AARCH64) || > defined(MDE_CPU_IA64) >=20 > +#if defined(MDE_CPU_X64) || defined(MDE_CPU_AARCH64) || > defined(MDE_CPU_IA64) || defined(MDE_CPU_RISCV64) >=20 > // >=20 > // With GCC we would normally use SIXTY_FOUR_BIT_LONG, but MSVC > needs >=20 > // SIXTY_FOUR_BIT, because 'long' is 32-bit and only 'long long' is >=20 > -- > 2.25.0