From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mx.groups.io with SMTP id smtpd.web10.204767.1673979715917087055 for ; Tue, 17 Jan 2023 10:21:56 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="signature has expired" header.i=@bsdio.com header.s=fm1 header.b=jHb54bzz; spf=pass (domain: bsdio.com, ip: 66.111.4.27, mailfrom: rebecca@bsdio.com) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 497215C006D; Tue, 17 Jan 2023 13:21:55 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Tue, 17 Jan 2023 13:21:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdio.com; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1673979715; x=1674066115; bh=VNgFJ7RnSw 8rJoiqK8UuU6dpYiTzsqELML6gkSMLJ2o=; b=jHb54bzzu/tpt1/mUYQ+MNImtK r4lwH9kfqxi1H/X8fyJ3bd8/8IQPhvwgRIL2iFUE31N6tLIhTZenm3nZ2CPOaypz BCTrAe5SLVm+TRF7IsTKgpLUHw0KSfU2wglRLngz/zvMocU4JCGjJjXatQlb6nUj b14j4bu6va9hX1cM0BeZf3MiIygESUOnfiyGX7WfPzpV2Bz8O8P6+67RI9FJyAQd BrfRsbOOWBc/hx61SkfoUAPQuVPIoHdGjZd/vrWMKzQOqGLtFyVnLUNWUyco2JEQ JVqotAiVPITp4mgGy8rX5JYkCN9s8PISjth9sxAJVpV6s73+zohGR/1eRPEg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1673979715; x=1674066115; bh=VNgFJ7RnSw8rJoiqK8UuU6dpYiTz sqELML6gkSMLJ2o=; b=r3P0MHVLP3qc2+geG56+qaZImetU8eDMR5d3tebhnKNx USX+aQPxb7J6kbuTlKIkyFLOCmzDa7HmNkhGKk+GAwUM8HSz6YMzCqpXWnee5JWh b3W1oqdtw2kolTtf/89Feh159huysD1UzfEnknBaZqOVtHKrNrLlRPbRYGOjTgU6 Y1K+YSnaP6eQRRE8nUoogIEedGwjtTMo7/ZPviCQjmsi64VyVwf3PS1DLvBtgl6F oTkxm7nd8Plx4lRQTLz8vmZ/VLLD3bdU9hw194nsO6yIwAHBhXoGysLlJLY8iVBn bGHxo0BrLq61bJqGJrTgBYH3KF514TDblJJLuxhaGw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedruddtiedguddutdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpegtkfffgggfuffvvehfhfgjsegrtderredtfeejnecuhfhrohhmpeftvggs vggttggrucevrhgrnhcuoehrvggsvggttggrsegsshguihhordgtohhmqeenucggtffrrg htthgvrhhnpeetgefhhfdtffdvhfeifeffheeugfeiuefgffeikeduhfejteetveetudeg feelleenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hrvggsvggttggrsegsshguihhordgtohhm X-ME-Proxy: Feedback-ID: i5b994698:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 17 Jan 2023 13:21:53 -0500 (EST) Message-ID: <923d3222-775c-f0e8-b4c1-4c10f122ad0a@bsdio.com> Date: Tue, 17 Jan 2023 11:21:52 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [edk2-devel] [edk2-platforms][PATCH 1/1] AmpereAltraPkg: Update ArmPlatformLib to work with changed ARM_CORE_INFO To: devel@edk2.groups.io, ardb@kernel.org, Rebecca Cran Cc: Nhi Pham , nhi@os.amperecomputing.com, patches@amperecomputing.com, quic_llindhol@quicinc.com, ardb+tianocore@kernel.org, Tinh Nguyen References: <20230113042126.3107135-1-nhi@os.amperecomputing.com> <7d401f29-56d9-d754-88a6-684ce329a727@quicinc.com> <25ee195f-85ee-d783-7e5c-f0da8b9972b4@quicinc.com> From: "Rebecca Cran" In-Reply-To: Content-Type: multipart/alternative; boundary="------------DoHKv2Dd7c6iD7V37de8wKE1" Content-Language: en-US --------------DoHKv2Dd7c6iD7V37de8wKE1 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 1/17/23 09:40, Ard Biesheuvel wrote: > On Tue, 17 Jan 2023 at 13:55, Rebecca Cran wrote: >> I was under the impression that this is becoming a more standard format? >> > If this is not defined in an ARM spec somewhere, we shouldn't add it > to ArmPkg at this point. From what I've found, the ARM specs such as the Arm Architecture Reference Manual for A-profile architecture don't define the meaning of the affinity fields? That appears to be left up to the individual Arm core TRMs. For example, the Cortex-X2 TRM says: Affinity level 0. This is the affinity level that is most significant for determining PE behavior. Higher affinity levels are increasingly less significant in determining PE behavior. The assigned value of the MPIDR.{Aff2, Aff1, Aff0} or AArch64-MPIDR_EL1.{Aff3, Aff2, Aff1, Aff0} set of fields of each PE must be unique within the system as a whole. 0b00000000 Only one thread. Affinity level 1. See the description of Aff0 for more information. Value read from the CPUID configuration pins. Identification number for each CPU in an cluster counting from zero. Affinity level 2. See the description of Aff0 for more information. The value will be determined by the CLUSTERIDAFF2 configuration pins. Affinity level 3. See the description of Aff0 for more information. The value will be determined by the CLUSTERIDAFF3 configuration pins. -- Rebecca Cran --------------DoHKv2Dd7c6iD7V37de8wKE1 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit 
On 1/17/23 09:40, Ard Biesheuvel wrote:

On Tue, 17 Jan 2023 at 13:55, Rebecca Cran <rebecca@quicinc.com> wrote:

I was under the impression that this is becoming a more standard format?


If this is not defined in an ARM spec somewhere, we shouldn't add it
to ArmPkg at this point.

From what I've found, the ARM specs such as the Arm Architecture Reference Manual for A-profile architecture don't define the meaning of the affinity fields? That appears to be left up to the individual Arm core TRMs.

For example, the Cortex-X2 TRM says:

Affinity level 0. This is the affinity level that is most significant for determining PE behavior. Higher affinity
levels are increasingly less significant in determining PE behavior. The assigned value of the MPIDR.{Aff2,
Aff1, Aff0} or AArch64-MPIDR_EL1.{Aff3, Aff2, Aff1, Aff0} set of fields of each PE must be unique within the
system as a whole.
0b00000000
Only one thread.


Affinity level 1. See the description of Aff0 for more information.
Value read from the CPUID configuration pins. Identification number for each CPU in an cluster counting from
zero.


Affinity level 2. See the description of Aff0 for more information.
The value will be determined by the CLUSTERIDAFF2 configuration pins.


Affinity level 3. See the description of Aff0 for more information.
The value will be determined by the CLUSTERIDAFF3 configuration pins.


--
Rebecca Cran

--------------DoHKv2Dd7c6iD7V37de8wKE1--