From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <lersek@redhat.com>
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ml01.01.org (Postfix) with ESMTPS id 46185803AB
 for <edk2-devel@ml01.01.org>; Mon, 13 Mar 2017 07:58:02 -0700 (PDT)
Received: from int-mx09.intmail.prod.int.phx2.redhat.com
 (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by mx1.redhat.com (Postfix) with ESMTPS id CFCA63A76BA;
 Mon, 13 Mar 2017 14:58:02 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-193.phx2.redhat.com
 [10.3.116.193])
 by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id
 v2DEw1Wr025157; Mon, 13 Mar 2017 10:58:01 -0400
To: Lans Zhang <jia.zhang@windriver.com>, edk2-devel@ml01.01.org
References: <1489242230-8293-1-git-send-email-jia.zhang@windriver.com>
Cc: ting.ye@intel.com, jiaxin.wu@intel.com
From: Laszlo Ersek <lersek@redhat.com>
Message-ID: <92550320-e00a-812f-e2d4-a87bbd5d0a78@redhat.com>
Date: Mon, 13 Mar 2017 15:57:59 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.8.0
MIME-Version: 1.0
In-Reply-To: <1489242230-8293-1-git-send-email-jia.zhang@windriver.com>
X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
 (mx1.redhat.com [10.5.110.29]); Mon, 13 Mar 2017 14:58:02 +0000 (UTC)
Subject: Re: [PATCH] CryptoPkg: ignore the openssl tarball in .gitignore
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: EDK II Development  <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Mon, 13 Mar 2017 14:58:02 -0000
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit

On 03/11/17 15:23, Lans Zhang wrote:
> The modified pattern can match up both the openssl source directory
> and tarball.
> 
> Cc: Ye Ting <ting.ye@intel.com>
> Cc: Wu Jiaxin <jiaxin.wu@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Lans Zhang <jia.zhang@windriver.com>
> ---
>  CryptoPkg/.gitignore | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/CryptoPkg/.gitignore b/CryptoPkg/.gitignore
> index 05272c2..a631aaf 100644
> --- a/CryptoPkg/.gitignore
> +++ b/CryptoPkg/.gitignore
> @@ -1,2 +1,2 @@
>  Include/openssl
> -Library/OpensslLib/openssl-*/
> +Library/OpensslLib/openssl-*
> 

I think I never place the tarball under Library/OpensslLib/, only the
extracted directory:

$ wget -q -O - http://www.openssl.org/source/openssl-1.0.2k.tar.gz \
  | tar -x -z

But I sure don't mind this change.

Acked-by: Laszlo Ersek <lersek@redhat.com>