From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail-ed1-f51.google.com (mail-ed1-f51.google.com [209.85.208.51])
 by mx.groups.io with SMTP id smtpd.web11.36695.1675068131315114219
 for <devel@edk2.groups.io>;
 Mon, 30 Jan 2023 00:42:11 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@gmail.com header.s=20210112 header.b=UYfZcMKi;
 spf=pass (domain: gmail.com, ip: 209.85.208.51, mailfrom: savvamtr@gmail.com)
Received: by mail-ed1-f51.google.com with SMTP id x7so6948450edr.0
        for <devel@edk2.groups.io>; Mon, 30 Jan 2023 00:42:10 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=references:to:cc:in-reply-to:date:subject:mime-version:message-id
         :from:from:to:cc:subject:date:message-id:reply-to;
        bh=MXRK8KyzhN/0wHVc4ph3tXF1SzyVAgL4lqe5493Clf0=;
        b=UYfZcMKiyASvHXTbBwLmT2XBHsAN441J+boPRKKTJ8yOWc9YpywwFjbooRrwVK99Ve
         cass89vp7Ae2vSwsKvpgM0hSrMsbr1qv1tHvnLEp5An1ymNvMcGSHrOD+c40ibi90h5d
         a/gCvo88xSLEzEAAwbBvWEVV6WMvMxUpFEgGnlDnHOSlBx5f9PtwUNgLebM82KMIQI/a
         gWfAV2RXKT/wIngMVCz0GJ/NgSyDmp7ZTU6cd2HSTnuvD0gdfWTcXc8na9zg2Fuh7vOe
         lQViUN9sLcVTB/pfKNoTdFRicqpxgVTkTV+GwtY5OJHIbJpO/uOwqHVIQsVOGr1FY+6M
         8G9w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=references:to:cc:in-reply-to:date:subject:mime-version:message-id
         :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
        bh=MXRK8KyzhN/0wHVc4ph3tXF1SzyVAgL4lqe5493Clf0=;
        b=zQiwjiVruwzP17xg31d3IeskiZkPcvRB1sD3F5Srsb71o2bUW1BqHgdC7DTtEps3z3
         AXf0AZQOSsKN9L8AFudGC+6jPW99yjFyUPnlfbg4w0/HcZDuMJJxjdcM+/1/fXE22TpB
         lpOD35p+gHVo9O/i4WiSNCxHZ5Iykgo+4oRwXP0zIwo14UaYB3VhCUJWKzidXp9bgxe5
         zargS2b0B819uaWlCVVNzaaq8YVZuX8bTcesf0r9JVFc92CgGfl3Bkp4THBy0cslQ47v
         kwuBz9zTJFaG6GJM60jJ2Hk0n1rS9X2lyhoNOUZ0SnviuiMQ+2/b1nCtY455+qt655iQ
         prFg==
X-Gm-Message-State: AFqh2kr4WvMi0efyl8pn96CqYnkEa6SFhDZRpTeIkgBFpP+ttKtf09zE
	W+Q7jKOrilvTre1KEoqp7zs=
X-Google-Smtp-Source: AMrXdXvfxk/5328gviJQangLhb3+9xzFjNDTbcwhhOTumSx/zeut7mv9+7I60btdCt04I+s55U2t6w==
X-Received: by 2002:a05:6402:2990:b0:499:8849:5fb8 with SMTP id eq16-20020a056402299000b0049988495fb8mr54170845edb.30.1675068129717;
        Mon, 30 Jan 2023 00:42:09 -0800 (PST)
Return-Path: <savvamtr@gmail.com>
Received: from smtpclient.apple ([176.62.67.29])
        by smtp.gmail.com with ESMTPSA id l11-20020aa7d94b000000b004954c90c94bsm6545657eds.6.2023.01.30.00.42.08
        (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
        Mon, 30 Jan 2023 00:42:09 -0800 (PST)
From: "Savva Mitrofanov" <savvamtr@gmail.com>
Message-Id: <926CA694-9DE9-420E-A1B0-C7E70CC06D91@gmail.com>
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.2\))
Subject: Re: [edk2-platforms][PATCH v3 02/11] Ext4Pkg: Fix incorrect checksum metadata feature check
Date: Mon, 30 Jan 2023 14:42:07 +0600
In-Reply-To: <72C59A93-6B86-4046-A408-6D63396C24B2@posteo.de>
Cc: devel@edk2.groups.io,
 Pedro Falcato <pedro.falcato@gmail.com>,
 =?utf-8?B?0JLQuNGC0LDQu9C40Lkg0K7RgNGM0LXQstC40Ycg0KfQtdC/0YbQvtCy?= <vit9696@protonmail.com>
To: =?utf-8?Q?Marvin_H=C3=A4user?= <mhaeuser@posteo.de>
References: <20230127092945.94389-1-savvamtr@gmail.com>
 <20230127092945.94389-3-savvamtr@gmail.com>
 <72C59A93-6B86-4046-A408-6D63396C24B2@posteo.de>
X-Mailer: Apple Mail (2.3696.120.41.1.2)
Content-Type: multipart/alternative;
	boundary="Apple-Mail=_74AF1F9F-BF0A-4A4A-8661-CDCD5E746471"

--Apple-Mail=_74AF1F9F-BF0A-4A4A-8661-CDCD5E746471
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8

Thanks for pointing this, yes, this change actually replaces structure =
field from FeaturesCompat to FeaturesRoCompat. The commit message was =
already corrected in referenced repository fork.

> On 27 Jan 2023, at 16:02, Marvin H=C3=A4user <mhaeuser@posteo.de> =
wrote:
>=20
> The actual issue appears to be FeaturesCompat vs FeaturesRoCompat =
(latter is hidden by your usage of the macro). Checking for !=3D 0 is =
redundant (albeit required by the code style guideline for =
non-functional reasons). Please confirm and update the commit message if =
you agree.


--Apple-Mail=_74AF1F9F-BF0A-4A4A-8661-CDCD5E746471
Content-Transfer-Encoding: quoted-printable
Content-Type: text/html;
	charset=utf-8

<html><head><meta http-equiv=3D"Content-Type" content=3D"text/html; =
charset=3Dutf-8"></head><body style=3D"word-wrap: break-word; =
-webkit-nbsp-mode: space; line-break: after-white-space;" =
class=3D"">Thanks for pointing this, yes, this change actually replaces =
structure field from FeaturesCompat to FeaturesRoCompat. The commit =
message was already corrected in referenced&nbsp;<span =
style=3D"caret-color: rgba(0, 0, 0, 0.847); color: rgba(0, 0, 0, 0.847); =
font-family: -apple-system-font;" class=3D"">repository =
fork.</span><div><br class=3D""><blockquote type=3D"cite" class=3D""><div =
class=3D"">On 27 Jan 2023, at 16:02, Marvin H=C3=A4user &lt;<a =
href=3D"mailto:mhaeuser@posteo.de" class=3D"">mhaeuser@posteo.de</a>&gt; =
wrote:</div><br class=3D"Apple-interchange-newline"><div class=3D""><span =
style=3D"caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: =
12px; font-style: normal; font-variant-caps: normal; font-weight: 400; =
letter-spacing: normal; text-align: start; text-indent: 0px; =
text-transform: none; white-space: normal; word-spacing: 0px; =
-webkit-text-stroke-width: 0px; text-decoration: none; float: none; =
display: inline !important;" class=3D"">The actual issue appears to be =
FeaturesCompat vs FeaturesRoCompat (latter is hidden by your usage of =
the macro). Checking for !=3D 0 is redundant (albeit required by the =
code style guideline for non-functional reasons). Please confirm and =
update the commit message if you =
agree.</span></div></blockquote></div><br class=3D""></body></html>=

--Apple-Mail=_74AF1F9F-BF0A-4A4A-8661-CDCD5E746471--