Re: [edk2-devel] EDK II Maintainers please test the pull request commit gate

["Laszlo Ersek" <lersek@redhat.com>]

Hi Mike,

On 11/07/19 20:26, Michael D Kinney wrote:
> Laszlo,
> 
> The hub command line utility also shows an option to
> create a fork without using the GitHub UI.  But since I
> already have all the relevant forks I needed, I have not
> tried this feature yet.

sorry, I was unclear with my "fork on github.com" adjustment.

I didn't mean that people were required to use the github *UI* for the
fork operation.

Instead, I meant that the data store inside <github.com> had to learn
about the "fork relationship" between the tianocore/edk2-staging repo,
and the <MaintainerAccount>/edk2-staging repo.

Because, in my vocabulary, if I enter my local *edk2* clone, and run the
following commands:

$ git remote add -f --no-tags staging \
    https://github.com/tianocore/edk2-staging.git
$ git checkout -b ci-test-1 staging/edk2-ci
$ [modify files]
$ git add ...
$ git commit
$ git push lersek-edk2 ci-test-1

then I *have* forked the edk2-staging repo. It's because now I'm
exposing a public topic branch that is the derivative of the
edk2-staging/edk2-ci branch.

But, this is not what the test procedure requires. The test procedure
requires each maintainer to tell github explicitly, "I am now forking
edk2-staging under my account, the way github (re)defines 'forking'".
That's *not* what "forking" means in base git terminology, in my
opinion, regardless of whether a maintainer implements the github kind
of forking on the github WebUI, or with the "hub" command line utility.

In brief, I wanted to say, "what github (the service) calls a fork is
quite a bit more restrictive than what base git calls a fork, so please
let's clearly require the github kind in the instructions".

Thanks
Laszlo


>> -----Original Message-----
>> From: Laszlo Ersek <lersek@redhat.com>
>> Sent: Thursday, November 7, 2019 3:01 AM
>> To: devel@edk2.groups.io; Kinney, Michael D
>> <michael.d.kinney@intel.com>
>> Subject: Re: [edk2-devel] EDK II Maintainers please test
>> the pull request commit gate
>>
>> On 11/07/19 03:24, Michael D Kinney wrote:
>>> EDK II Maintainers,
>>>
>>> Please take a few minutes to test the GitHub pull
>> request commit gate
>>> feature under review in the edk2-staging/edk2-ci
>> branch.  This will be
>>> the only method to push patches to the edk2 repo in
>> the near future,
>>> and we want all current EDK II Maintainers to make
>> sure they know how
>>> to use this new process on the edk2-staging repo
>> before it is
>>> activated on the
>>> edk2 repo.
>>>
>>> Please perform the following steps:
>>> * Create a personal fork of the edk2-staging repo.
>>
>> Slight but relevant clarification: please create a
>> personal fork of the edk2-staging repo *on GitHub.com*.
>>
>>> * Check out the edk2-ci branch from your personal
>>>   fork of the edk2-staging repo
>>> * Create a new branch based on the edk2-ci branch
>>> * Edit the file SampleFile.txt in the root of this
>>>   branch and add an Acked-by: <your email> tag to
>>>   the end of this file.
>>> * Submit a pull request against the Tianocore
>>>   edk2-staging/edk2-ci.  Set the 'push' label so
>>>   the change to SampleFile.txt will be committed
>>>   if all checks pass.
>>>
>>>   NOTE: Make sure you select the 'edk2-ci' branch.
>>>   The default branch for the edk2-staging repo is
>>>   the 'about' branch and the pull request will not
>>>   work against the 'about' branch.
>>>
>>> * Verify that all checks pass and your change to
>>>   SampleFile.txt was merged into the
>>>   edk2-staging/edk2-ci branch.
>>>
>>> For those that prefer command line tools over a WebUI,
>> the command
>>> line utility called 'hub' can be used to submit a pull
>> request and
>>> check the status of a pull request.
>>>
>>> * https://github.com/github/hub
>>> * https://github.com/github/hub/releases
>>> * https://hub.github.com/hub.1.html
>>
>> I've gone through the above (except the personal Acked-
>> by tag) earlier,
>> successfully:
>>
>> https://github.com/tianocore/edk2-staging/pull/99
>>
>> Thanks!
>> Laszlo
> 
> 
> 
>