From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.61]) by mx.groups.io with SMTP id smtpd.web11.12787.1573233143621358191 for ; Fri, 08 Nov 2019 09:12:23 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=atyoek9u; spf=pass (domain: redhat.com, ip: 205.139.110.61, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1573233142; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VX/fp27gZRr8rzltfCSg4Zl8/q1Wq17JAU5BSFxMTzk=; b=atyoek9u709SeCNKvle0B6Ijbub5f/RpdfTGt5aY6PSByZo4n/gc86emDhW01m+V7Lurbh sx5NECIyjCRg9X9TCbty4H0ewYcVlNbef0Vuc5nP6ZYICdWZgG59nTagVF4JWEaLC1RYvL tzma9sG8jmM2YD9MXXKdy1WEc9L8wls= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-304-mnZtYqGBOCaDU1L9j5X0LQ-1; Fri, 08 Nov 2019 12:12:19 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D362C800C72; Fri, 8 Nov 2019 17:12:18 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-117-227.ams2.redhat.com [10.36.117.227]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0D28760BE2; Fri, 8 Nov 2019 17:12:17 +0000 (UTC) Subject: Re: [edk2-devel] EDK II Maintainers please test the pull request commit gate To: devel@edk2.groups.io, michael.d.kinney@intel.com References: From: "Laszlo Ersek" Message-ID: <927a6e50-1106-92d1-3480-4d4492ca2340@redhat.com> Date: Fri, 8 Nov 2019 18:12:17 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-MC-Unique: mnZtYqGBOCaDU1L9j5X0LQ-1 X-Mimecast-Spam-Score: 0 Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi Mike, On 11/07/19 20:26, Michael D Kinney wrote: > Laszlo, >=20 > The hub command line utility also shows an option to > create a fork without using the GitHub UI. But since I > already have all the relevant forks I needed, I have not > tried this feature yet. sorry, I was unclear with my "fork on github.com" adjustment. I didn't mean that people were required to use the github *UI* for the fork operation. Instead, I meant that the data store inside had to learn about the "fork relationship" between the tianocore/edk2-staging repo, and the /edk2-staging repo. Because, in my vocabulary, if I enter my local *edk2* clone, and run the following commands: $ git remote add -f --no-tags staging \ https://github.com/tianocore/edk2-staging.git $ git checkout -b ci-test-1 staging/edk2-ci $ [modify files] $ git add ... $ git commit $ git push lersek-edk2 ci-test-1 then I *have* forked the edk2-staging repo. It's because now I'm exposing a public topic branch that is the derivative of the edk2-staging/edk2-ci branch. But, this is not what the test procedure requires. The test procedure requires each maintainer to tell github explicitly, "I am now forking edk2-staging under my account, the way github (re)defines 'forking'". That's *not* what "forking" means in base git terminology, in my opinion, regardless of whether a maintainer implements the github kind of forking on the github WebUI, or with the "hub" command line utility. In brief, I wanted to say, "what github (the service) calls a fork is quite a bit more restrictive than what base git calls a fork, so please let's clearly require the github kind in the instructions". Thanks Laszlo >> -----Original Message----- >> From: Laszlo Ersek >> Sent: Thursday, November 7, 2019 3:01 AM >> To: devel@edk2.groups.io; Kinney, Michael D >> >> Subject: Re: [edk2-devel] EDK II Maintainers please test >> the pull request commit gate >> >> On 11/07/19 03:24, Michael D Kinney wrote: >>> EDK II Maintainers, >>> >>> Please take a few minutes to test the GitHub pull >> request commit gate >>> feature under review in the edk2-staging/edk2-ci >> branch. This will be >>> the only method to push patches to the edk2 repo in >> the near future, >>> and we want all current EDK II Maintainers to make >> sure they know how >>> to use this new process on the edk2-staging repo >> before it is >>> activated on the >>> edk2 repo. >>> >>> Please perform the following steps: >>> * Create a personal fork of the edk2-staging repo. >> >> Slight but relevant clarification: please create a >> personal fork of the edk2-staging repo *on GitHub.com*. >> >>> * Check out the edk2-ci branch from your personal >>> fork of the edk2-staging repo >>> * Create a new branch based on the edk2-ci branch >>> * Edit the file SampleFile.txt in the root of this >>> branch and add an Acked-by: tag to >>> the end of this file. >>> * Submit a pull request against the Tianocore >>> edk2-staging/edk2-ci. Set the 'push' label so >>> the change to SampleFile.txt will be committed >>> if all checks pass. >>> >>> NOTE: Make sure you select the 'edk2-ci' branch. >>> The default branch for the edk2-staging repo is >>> the 'about' branch and the pull request will not >>> work against the 'about' branch. >>> >>> * Verify that all checks pass and your change to >>> SampleFile.txt was merged into the >>> edk2-staging/edk2-ci branch. >>> >>> For those that prefer command line tools over a WebUI, >> the command >>> line utility called 'hub' can be used to submit a pull >> request and >>> check the status of a pull request. >>> >>> * https://github.com/github/hub >>> * https://github.com/github/hub/releases >>> * https://hub.github.com/hub.1.html >> >> I've gone through the above (except the personal Acked- >> by tag) earlier, >> successfully: >> >> https://github.com/tianocore/edk2-staging/pull/99 >> >> Thanks! >> Laszlo >=20 >=20 >=20 >=20