public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Zeng, Star" <star.zeng@intel.com>
To: Ruiyu Ni <ruiyu.ni@intel.com>, edk2-devel@lists.01.org
Cc: Michael D Kinney <michael.d.kinney@intel.com>,
	Liming Gao <liming.gao@intel.com>,
	star.zeng@intel.com
Subject: Re: [PATCH 03/10] MdeModulePkg/PeiMain: Cleanup whitespace in Reset.c
Date: Wed, 7 Feb 2018 19:39:16 +0800	[thread overview]
Message-ID: <927d8531-8fc3-656f-0650-8e18c72ca2c9@intel.com> (raw)
In-Reply-To: <20180202064530.407028-4-ruiyu.ni@intel.com>

On 2018/2/2 14:45, Ruiyu Ni wrote:
> From: Michael D Kinney <michael.d.kinney@intel.com>
> 
> Cc: Liming Gao <liming.gao@intel.com>
> Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>

Reviewed-by: Star Zeng <star.zeng@intel.com>

Thanks,
Star
> ---
>   MdeModulePkg/Core/Pei/Reset/Reset.c | 41 ++++++++++++++++++-------------------
>   1 file changed, 20 insertions(+), 21 deletions(-)
> 
> diff --git a/MdeModulePkg/Core/Pei/Reset/Reset.c b/MdeModulePkg/Core/Pei/Reset/Reset.c
> index cd36c526b5..e6d7899ef7 100644
> --- a/MdeModulePkg/Core/Pei/Reset/Reset.c
> +++ b/MdeModulePkg/Core/Pei/Reset/Reset.c
> @@ -1,14 +1,14 @@
>   /** @file
>     Pei Core Reset System Support
> -
> +
>   Copyright (c) 2006 - 2017, Intel Corporation. All rights reserved.<BR>
> -This program and the accompanying materials
> -are licensed and made available under the terms and conditions of the BSD License
> -which accompanies this distribution.  The full text of the license may be found at
> -http://opensource.org/licenses/bsd-license.php
> -
> -THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
> -WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
> +This program and the accompanying materials
> +are licensed and made available under the terms and conditions of the BSD License
> +which accompanies this distribution.  The full text of the license may be found at
> +http://opensource.org/licenses/bsd-license.php
> +
> +THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
> +WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
>   
>   **/
>   
> @@ -29,11 +29,11 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
>   EFI_STATUS
>   EFIAPI
>   PeiResetSystem (
> -  IN CONST EFI_PEI_SERVICES         **PeiServices
> +  IN CONST EFI_PEI_SERVICES  **PeiServices
>     )
>   {
> -  EFI_STATUS        Status;
> -  EFI_PEI_RESET_PPI *ResetPpi;
> +  EFI_STATUS         Status;
> +  EFI_PEI_RESET_PPI  *ResetPpi;
>   
>     //
>     // Attempt to use newer ResetSystem2().  If this returns, then ResetSystem2()
> @@ -52,9 +52,10 @@ PeiResetSystem (
>                );
>     if (!EFI_ERROR (Status)) {
>       return ResetPpi->ResetSystem (PeiServices);
> -  }
> +  }
> +
>     //
> -  // Report Status Code that Reset PPI is not available
> +  // Report Status Code that Reset PPI is not available.
>     //
>     REPORT_STATUS_CODE (
>       EFI_ERROR_CODE | EFI_ERROR_MINOR,
> @@ -85,14 +86,14 @@ PeiResetSystem (
>   VOID
>   EFIAPI
>   PeiResetSystem2 (
> -  IN EFI_RESET_TYPE     ResetType,
> -  IN EFI_STATUS         ResetStatus,
> -  IN UINTN              DataSize,
> -  IN VOID               *ResetData OPTIONAL
> +  IN EFI_RESET_TYPE  ResetType,
> +  IN EFI_STATUS      ResetStatus,
> +  IN UINTN           DataSize,
> +  IN VOID            *ResetData OPTIONAL
>     )
>   {
> -  EFI_STATUS            Status;
> -  EFI_PEI_RESET2_PPI    *Reset2Ppi;
> +  EFI_STATUS          Status;
> +  EFI_PEI_RESET2_PPI  *Reset2Ppi;
>   
>     //
>     // Look for PEI Reset System 2 PPI
> @@ -103,7 +104,6 @@ PeiResetSystem2 (
>                NULL,
>                (VOID **)&Reset2Ppi
>                );
> -
>     if (!EFI_ERROR (Status)) {
>       Reset2Ppi->ResetSystem (ResetType, ResetStatus, DataSize, ResetData);
>       return;
> @@ -117,4 +117,3 @@ PeiResetSystem2 (
>       (EFI_SOFTWARE_PEI_CORE | EFI_SW_PS_EC_RESET_NOT_AVAILABLE)
>       );
>   }
> -
> 



  reply	other threads:[~2018-02-07 11:34 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-02  6:45 [PATCH 00/10] Formalize the reset system core design Ruiyu Ni
2018-02-02  6:45 ` [PATCH 01/10] MdePkg/PeiServicesLib: Add PeiServicesResetSystem2() Ruiyu Ni
2018-02-07 11:37   ` Zeng, Star
2018-02-02  6:45 ` [PATCH 02/10] MdeModulePkg/PeiMain: Always attempt to use Reset2 PPI first Ruiyu Ni
2018-02-07 11:37   ` Zeng, Star
2018-02-02  6:45 ` [PATCH 03/10] MdeModulePkg/PeiMain: Cleanup whitespace in Reset.c Ruiyu Ni
2018-02-07 11:39   ` Zeng, Star [this message]
2018-02-02  6:45 ` [PATCH 04/10] MdeModulePkg/ResetSystemRuntimeDxe: Add platform filter and handler Ruiyu Ni
2018-02-02 13:46   ` Laszlo Ersek
2018-02-06  2:56     ` Ni, Ruiyu
2018-02-07 11:44   ` Zeng, Star
2018-02-02  6:45 ` [PATCH 05/10] MdeModulePkg/ResetSystemRuntimeDxe: Add more debug message Ruiyu Ni
2018-02-07 12:04   ` Zeng, Star
2018-02-09  3:01     ` Ni, Ruiyu
2018-02-02  6:45 ` [PATCH 06/10] MdeModulePkg: Add ResetSystemLib instances that call core services Ruiyu Ni
2018-02-07 12:20   ` Zeng, Star
2018-02-09  3:00     ` Ni, Ruiyu
2018-02-02  6:45 ` [PATCH 07/10] MdeModulePkg: Add ResetUtility librray class and BASE instance Ruiyu Ni
2018-02-07 12:28   ` Zeng, Star
2018-02-08  1:36     ` Zeng, Star
2018-02-08  2:07       ` Zeng, Star
2018-02-02  6:45 ` [PATCH 08/10] MdePkg/UefiRuntimeLib: Support more module types Ruiyu Ni
2018-02-07 12:24   ` Zeng, Star
2018-02-09  3:06     ` Ni, Ruiyu
2018-02-02  6:45 ` [PATCH 09/10] MdeModulePkg: Add ResetSystemPei PEIM Ruiyu Ni
2018-02-07 12:35   ` Zeng, Star
2018-02-08  2:16     ` Zeng, Star
2018-02-09  3:12     ` Ni, Ruiyu
2018-02-02  6:45 ` [PATCH 10/10] MdeModulePkg/ResetSystemPei: Add reset notifications in PEI Ruiyu Ni
2018-02-07 12:40   ` Zeng, Star
2018-02-08  2:18     ` Zeng, Star

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=927d8531-8fc3-656f-0650-8e18c72ca2c9@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox