From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.81]) by mx.groups.io with SMTP id smtpd.web09.12320.1583333489983159026 for ; Wed, 04 Mar 2020 06:51:30 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=PGqSS2oB; spf=pass (domain: redhat.com, ip: 207.211.31.81, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1583333489; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=L+zntEpRkdc9LA4qJY1g6ZNnrtf0N3QlV/7HzEo4x8U=; b=PGqSS2oBu3nmVqCb4CXPQFFnnCDgWI0KKmqVgetsoOIhi4VkKwwcBIU8a6iNZ9kw53KMqP VRspO9InaT9QYDI+qR3tN4AE9rxMkVPg+eBk/lcAxleCbAlUdhyJ/zn0Q/f2r8IK58fm+L Egy+a5DqRHBesNxDeg33qbl30dRm00E= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-489-ZV9RowHFOpSVM1ZOGDTtlA-1; Wed, 04 Mar 2020 09:51:22 -0500 X-MC-Unique: ZV9RowHFOpSVM1ZOGDTtlA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A3079DBA6; Wed, 4 Mar 2020 14:51:21 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-117-59.ams2.redhat.com [10.36.117.59]) by smtp.corp.redhat.com (Postfix) with ESMTP id 786385D9C9; Wed, 4 Mar 2020 14:51:20 +0000 (UTC) Subject: Re: [PATCH 0/2] OvmfPkg, ArmVirtPkg: sync Timeout with PcdPlatformBootTimeOut To: Ard Biesheuvel Cc: edk2-devel-groups-io , Jordan Justen , Leif Lindholm , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= References: <20200304094413.19462-1-lersek@redhat.com> From: "Laszlo Ersek" Message-ID: <929a77fa-0224-86e2-1ed5-231616052f44@redhat.com> Date: Wed, 4 Mar 2020 15:51:19 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 03/04/20 10:54, Ard Biesheuvel wrote: > On Wed, 4 Mar 2020 at 10:44, Laszlo Ersek wrote: >> >> Repo: https://pagure.io/lersek/edk2.git >> Branch: timeout_var >> >> In the PlatformBootManagerLib instances, set the Timeout global variable >> to the same value as PcdPlatformBootTimeOut. This way the "setvar" >> command in the UEFI shell, and the "efibootmgr" command in a Linux >> guest, can report the front page timeout that was requested on the QEMU >> command line (see GetFrontPageTimeoutFromQemu() in >> "OvmfPkg/Library/QemuBootOrderLib/QemuBootOrderLib.c"). >> >> A DEBUG_VERBOSE message is logged on success too, for our QE team's >> sake. >> >> Cc: Ard Biesheuvel >> Cc: Jordan Justen >> Cc: Leif Lindholm >> Cc: Philippe Mathieu-Daud=C3=A9 >> >> Thanks >> Laszlo >> >> Laszlo Ersek (2): >> OvmfPkg/PlatformBootManagerLib: sync Timeout with >> PcdPlatformBootTimeOut >> ArmVirtPkg/PlatformBootManagerLib: sync Timeout with >> PcdPlatformBootTimeOut >> >=20 > Provided that the use of the bare 'sizeof ' doesn't throw > up any build errors with Clang (I seem to remember a report from Mike > Kinney about this?) >=20 > Reviewed-by: Ard Biesheuvel I use the "sizeof" operator exclusively without parens if the operand is not a type name, at least in packages that I co-maintain. I don't recall any particular build failures (even from the edk2 CI). Thanks! Laszlo >=20 >> ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c | = 27 ++++++++++++++++++-- >> ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf | = 1 + >> OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c | = 26 +++++++++++++++++-- >> OvmfPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf | = 2 ++ >> 4 files changed, 52 insertions(+), 4 deletions(-) >> >> -- >> 2.19.1.3.g30247aa5d201 >> >=20