From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: mateusz.albecki@intel.com) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by groups.io with SMTP; Thu, 13 Jun 2019 06:46:49 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Jun 2019 06:46:47 -0700 X-ExtLoop1: 1 Received: from irsmsx107.ger.corp.intel.com ([163.33.3.99]) by orsmga005.jf.intel.com with ESMTP; 13 Jun 2019 06:46:46 -0700 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.238]) by IRSMSX107.ger.corp.intel.com ([169.254.10.211]) with mapi id 14.03.0415.000; Thu, 13 Jun 2019 14:43:59 +0100 From: mateusz.albecki@intel.com To: "devel@edk2.groups.io" CC: "Wu, Hao A" Subject: Re: [PATCH 0/2] Add GetOperatingParam notify phase to SdMmcOverride protocol Thread-Topic: [PATCH 0/2] Add GetOperatingParam notify phase to SdMmcOverride protocol Thread-Index: AQHVGgBKTqE4nvrEEkq8P4+79vevdKaUMYaAgAV2aPA= Date: Thu, 13 Jun 2019 13:43:59 +0000 Message-ID: <92CF190FF2351747A47C1708F0E09C0875E512A7@IRSMSX102.ger.corp.intel.com> References: <20190603113346.1288-1-mateusz.albecki@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNDVmODVmNzAtYjQzOS00MGU3LWEzMzktOWEwZDAyZjVmODBiIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiampuYzJDRVwvbmZmMGxRY1Npak13Y2hkS25iaWdBQnZkU1FXT1k1bnpJcnNGa3E0ZlBISHB3czg5OERsV1ppUjgifQ== dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [163.33.239.180] MIME-Version: 1.0 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_92CF190FF2351747A47C1708F0E09C0875E512A7IRSMSX102gercor_" --_000_92CF190FF2351747A47C1708F0E09C0875E512A7IRSMSX102gercor_ Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Resending to group. From: Wu, Hao A Sent: Monday, June 10, 2019 5:18 AM To: Albecki, Mateusz Subject: RE: [PATCH 0/2] Add GetOperatingParam notify phase to SdMmcOverrid= e protocol Hello Mateusz, Thanks for the patch series and sorry for the delayed response. One question first, I did not see the patches being sent to the mailing list 'devel@edk2.groups.io'. We have recently switched to this new mailing list = back to early April, the old one 'edk2-devel@lists.01.org' is no longer being us= ed. In case that you have not registered the new list, you can sign up at: https://edk2.groups.io/g/devel or email: devel+subscribe@edk2.groups.io to get registered in the new mailing list. Or you can send me the patch files and I will help to send them to the mail= ing list. Below are some general level feedbacks (Other patch-specific feedbacks will= be replied in other mails): * Could you help to add the below Bugzilla tracker reference in the= commit log message? https://bugzilla.tianocore.org/show_bug.cgi?id=3D1882 * Could you help to run the script 'BaseTools/Scripts/PatchCheck.py= ' and resolve its report on the commit log format issues? Checking git commit: 6e3f64aeb4 The commit message format is not valid: * Contributed-under! (Note: this must be removed by the code contributor!) * Add quotes (") around name with a comma: Albecki, Mateusz * Email format is invalid: hao.a.wu@intel.com * Line 15 of commit message is too long. https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message-Format The code passed all checks. Checking git commit: 91595ae911 The commit message format is not valid: * Contributed-under! (Note: this must be removed by the code contributor!) * Add quotes (") around name with a comma: Albecki, Mateusz * Email format is invalid: hao.a.wu@intel.com https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message-Format The code passed all checks. * Could you help to resolve the typo 'Prefered' to 'Preferred' in t= he naming of some variables? * Could you help to use lowercase 'static' (instead of using the up= percase one) for the new functions? Also, I only verified the build of the patch series. Please grant me some t= ime to verify on the HW on my side. Maybe your updated patches arrive first and= I will then verify the update ones. Best Regards, Hao Wu > -----Original Message----- > From: Albecki, Mateusz > Sent: Monday, June 03, 2019 7:34 PM > Cc: Albecki, Mateusz; Wu, Hao A > Subject: [PATCH 0/2] Add GetOperatingParam notify phase to > SdMmcOverride protocol > > To allow platform greater control over the bus settings for SD card and > eMMC card > we have added a new notify phase to SdMmcOverrideProtocol called > GetOperatingParam. > This phase is signaled before SD card/eMMC initialization and allows plat= form > to tweak > the values in new structure called > EDKII_SD_MMC_OPERATING_PARAMETERS which allows to configure > bus width, clock frequency and driver strength. Other bus parameters can = be > configured by > overriding host controller capabilities. > > Tests: > - OS boot from eMMC without SdMmcOverride protocol installed > - OS boot from eMMC with SdMmcOverride installed and clock frequency > lowered to 100MHz in HS200 > - OS boot from eMMC with driver strength changed to Type1 > - SD card enumeration in UEFI shell on default speed and high speed(non > UHS-I) with SdMmcOverride installed and UHS-I disabled in capability > > > Cc: hao.a.wu@intel.com > > Albecki, Mateusz (2): > MdeModulePkg/SdMmcOverride: Add GetOperatingParam notify phase > MdeModulePkg/SdMmcHcDxe: Implement revision 3 of > SdMmcOverrideProtocol > > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/EmmcDevice.c | 522 > +++++++++++++++------ > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdDevice.c | 381 > ++++++++++++--- > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.c | 52 +- > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.h | 18 +- > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c | 8 +- > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.h | 8 +- > MdeModulePkg/Include/Protocol/SdMmcOverride.h | 58 ++- > 7 files changed, 802 insertions(+), 245 deletions(-) > > -- > 2.14.1.windows.1 -------------------------------------------------------------------- Intel Technology Poland sp. z o.o. ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydz= ial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-31= 6 | Kapital zakladowy 200.000 PLN. Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata= i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej wi= adomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; jakiek= olwiek przegladanie lub rozpowszechnianie jest zabronione. This e-mail and any attachments may contain confidential material for the s= ole use of the intended recipient(s). If you are not the intended recipient= , please contact the sender and delete all copies; any review or distributi= on by others is strictly prohibited. --_000_92CF190FF2351747A47C1708F0E09C0875E512A7IRSMSX102gercor_ Content-Type: text/html; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

Resending to group.

 

From: Wu, Hao A
Sent: Monday, June 10, 2019 5:18 AM
To: Albecki, Mateusz <mateusz.albecki@intel.com>
Subject: RE: [PATCH 0/2] Add GetOperatingParam notify phase to SdMmc= Override protocol

 

Hello Mateusz,

 

Thanks for the patch series = and sorry for the delayed response.

 

One question first, I did no= t see the patches being sent to the mailing list

'devel@edk2.groups.io'. We h= ave recently switched to this new mailing list back

to early April, the old one = 'edk2-devel@lists.01.org' is no longer being used.

 

In case that you have not re= gistered the new list, you can sign up at:

https://edk2.groups.io/g/devel

or email:<= /p>

devel+subscribe@edk2.groups.io=

to get registered in the new= mailing list.

 

Or you can send me the patch= files and I will help to send them to the mailing list.<= /p>

 

 

Below are some general level= feedbacks (Other patch-specific feedbacks will be replied in other mails):=

·         Could you help to ad= d the below Bugzilla tracker reference in the commit log message?

https://bugzilla.tianocore.org/show_b= ug.cgi?id=3D1882

 

·         Could you help to ru= n the script ‘BaseTools/Scripts/PatchCheck.py’ and resolve its = report on the commit log format issues?

Checking git commit: 6e3f= 64aeb4

The commit message format= is not valid:

* Contributed-under! (Not= e: this must be removed by the code contributor!)

* Add quotes (") aro= und name with a comma: Albecki, Mateusz

* Email format is invalid= : hao.a.wu@intel.com

* Line 15 of commit messa= ge is too long.

https://gith= ub.com/tianocore/tianocore.github.io/wiki/Commit-Message-Format

The code passed all check= s.

 <= /i>

Checking git commit: 9159= 5ae911

The commit message format= is not valid:

* Contributed-under! (Not= e: this must be removed by the code contributor!)

* Add quotes (") aro= und name with a comma: Albecki, Mateusz

* Email format is invalid= : hao.a.wu@intel.com

https://gith= ub.com/tianocore/tianocore.github.io/wiki/Commit-Message-Format

The code passed all check= s.

 

·         Could you help to re= solve the typo ‘Prefered’ to ‘Preferred’ in the nam= ing of some variables?

 

·         Could you help to us= e lowercase ‘static’ (instead of using the uppercase one) for t= he new functions?

 

 

Also, I only verified the bu= ild of the patch series. Please grant me some time

to verify on the HW on my si= de. Maybe your updated patches arrive first and I

will then verify the update = ones.

 

 

Best Regards,

Hao Wu

 

> -----Original Message--= ---

> From: Albecki, Mateusz<= o:p>

> Sent: Monday, June 03, = 2019 7:34 PM

> Cc: Albecki, Mateusz; W= u, Hao A

> Subject: [PATCH 0/2] Ad= d GetOperatingParam notify phase to

> SdMmcOverride protocol<= o:p>

>

> To allow platform great= er control over the bus settings for SD card and

> eMMC card

> we have added a new not= ify phase to SdMmcOverrideProtocol called

> GetOperatingParam.=

> This phase is signaled = before SD card/eMMC initialization and allows platform

> to tweak

> the values in new struc= ture called

> EDKII_SD_MMC_OPERATING_= PARAMETERS which allows to configure

> bus width, clock freque= ncy and driver strength. Other bus parameters can be

> configured by

> overriding host control= ler capabilities.

>

> Tests:

> - OS boot from eMMC wit= hout SdMmcOverride protocol installed

> - OS boot from eMMC wit= h SdMmcOverride installed and clock frequency

> lowered to 100MHz in HS= 200

> - OS boot from eMMC wit= h driver strength changed to Type1

> - SD card enumeration i= n UEFI shell on default speed and high speed(non

> UHS-I) with SdMmcOverri= de installed and UHS-I disabled in capability

>

>

> Cc: hao.a.wu@intel.com

>

> Albecki, Mateusz (2):

>   MdeModulePk= g/SdMmcOverride: Add GetOperatingParam notify phase

>   MdeModulePk= g/SdMmcHcDxe: Implement revision 3 of

> SdMmcOverrideProtocol

>

>  MdeModulePkg/Bus/= Pci/SdMmcPciHcDxe/EmmcDevice.c    | 522

> ++++= 3;++++++++++------

>  MdeModulePkg/Bus/= Pci/SdMmcPciHcDxe/SdDevice.c      | 381=

> ++++= 3;+++++++---

>  MdeModulePkg/Bus/= Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.c |  52 +-

>  MdeModulePkg/Bus/= Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.h |  18 +-

>  MdeModulePkg/Bus/= Pci/SdMmcPciHcDxe/SdMmcPciHci.c   |   8 +-

>  MdeModulePkg/Bus/= Pci/SdMmcPciHcDxe/SdMmcPciHci.h   |   8 +-

>  MdeModulePkg/Incl= ude/Protocol/SdMmcOverride.h      |  58 += +-

>  7 files changed, = 802 insertions(+), 245 deletions(-)

>

> --

> 2.14.1.windows.1

 

---------------------------------------------------------------------
Intel Technology Poland sp. z o.o.
ul. Słowackiego 173 | 80-298 Gdańsk | Sąd Rejonowy Gd= ańsk Północ | VII Wydział Gospodarczy Krajowego Rejestru Sądowego - KRS 101882 = | NIP 957-07-52-316 | Kapitał zakładowy 200.000 PLN.

Ta wiadomość wraz z załącznikami jest przeznaczona d= la określonego adresata i może zawierać informacje poufne. W razie przypadkowego o= trzymania tej wiadomości, prosimy o powiadomienie nadawcy oraz trwałe jej usu= nięcie; jakiekolwiek przeglądanie lub rozpowszechnianie jest zabronione.
This e-mail and any attachments may contain confidential material for the s= ole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by oth= ers is strictly prohibited.

--_000_92CF190FF2351747A47C1708F0E09C0875E512A7IRSMSX102gercor_--