From: Laszlo Ersek <lersek@redhat.com>
To: Hao Wu <hao.a.wu@intel.com>, edk2-devel@lists.01.org
Cc: Ruiyu Ni <ruiyu.ni@intel.com>, Eric Dong <eric.dong@intel.com>
Subject: Re: [PATCH v1] UefiCpuPkg: Merge StuffRsb.inc files into one in UefiCpuPkg/Include
Date: Wed, 26 Dec 2018 22:43:27 +0100 [thread overview]
Message-ID: <92ab3a16-789b-e110-e2af-20e72d954882@redhat.com> (raw)
In-Reply-To: <20181221072959.11168-1-hao.a.wu@intel.com>
On 12/21/18 08:29, Hao Wu wrote:
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1091
>
> Previously, when compiling NASM source files, BaseTools did not support
> including files outside of the NASM source file directory. As a result, we
> duplicated multiple copies of "StuffRsb.inc" files in UefiCpuPkg. Those
> INC files contain the common logic to stuff the Return Stack Buffer and
> are identical.
>
> After the fix of BZ 1085:
> https://bugzilla.tianocore.org/show_bug.cgi?id=1085
> The above support was introduced.
>
> Thus, this commit will merge all the StuffRsb.inc files in UefiCpuPkg into
> one file. The merged file will be named 'StuffRsbNasm.inc' and be placed
> under folder UefiCpuPkg/Include/.
>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Hao Wu <hao.a.wu@intel.com>
> ---
> UefiCpuPkg/{Library/SmmCpuFeaturesLib/Ia32/StuffRsb.inc => Include/StuffRsbNasm.inc} | 3 +-
> UefiCpuPkg/Library/SmmCpuFeaturesLib/Ia32/SmiEntry.nasm | 2 +-
> UefiCpuPkg/Library/SmmCpuFeaturesLib/Ia32/SmiException.nasm | 2 +-
> UefiCpuPkg/Library/SmmCpuFeaturesLib/X64/SmiEntry.nasm | 2 +-
> UefiCpuPkg/Library/SmmCpuFeaturesLib/X64/SmiException.nasm | 2 +-
> UefiCpuPkg/Library/SmmCpuFeaturesLib/X64/StuffRsb.inc | 55 --------------------
> UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/SmiEntry.nasm | 2 +-
> UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/SmmInit.nasm | 2 +-
> UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/StuffRsb.inc | 55 --------------------
> UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiEntry.nasm | 2 +-
> UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmmInit.nasm | 2 +-
> UefiCpuPkg/PiSmmCpuDxeSmm/X64/StuffRsb.inc | 55 --------------------
> 12 files changed, 10 insertions(+), 174 deletions(-)
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Thanks!
Laszlo
prev parent reply other threads:[~2018-12-26 21:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-21 7:29 [PATCH v1] UefiCpuPkg: Merge StuffRsb.inc files into one in UefiCpuPkg/Include Hao Wu
2018-12-24 2:22 ` Dong, Eric
2018-12-26 21:43 ` Laszlo Ersek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=92ab3a16-789b-e110-e2af-20e72d954882@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox