From: "Taylor Beebe" <taylor.d.beebe@gmail.com>
To: devel@edk2.groups.io, gaoliming@byosoft.com.cn
Cc: 'Rebecca Cran' <rebecca@bsdio.com>,
'Bob Feng' <bob.c.feng@intel.com>,
'Yuwei Chen' <yuwei.chen@intel.com>
Subject: Re: 回复: 回复: [edk2-devel] [PATCH v2 0/2] Update BaseTools NULL Include and Library Matching
Date: Tue, 9 Apr 2024 12:42:43 -0700 [thread overview]
Message-ID: <92b0faf2-dc7b-4b69-ac24-cd96c071748c@gmail.com> (raw)
In-Reply-To: <018f01da849e$4caff4b0$e60fde10$@byosoft.com.cn>
Hi Liming,
I made a mistake in patch 2 of the v2 series. In v3, lines 126 and 144
of WorkspaceCommon.py update the check to:
`LibraryClassName[4:].isdigit()`
instead of
`LibraryClass[4:].isdigit()`
Can you re-review with this change?
-Taylor
On 4/1/2024 6:37 PM, gaoliming via groups.io wrote:
> Taylor:
> Thanks for you detail information. I understand this problem. I agree your fix. Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
>
> Thanks
> Liming
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117558): https://edk2.groups.io/g/devel/message/117558
Mute This Topic: https://groups.io/mt/105280288/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2024-04-09 19:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-22 19:19 [edk2-devel] [PATCH v2 0/2] Update BaseTools NULL Include and Library Matching Taylor Beebe
2024-03-22 19:19 ` [edk2-devel] [PATCH v2 1/2] BaseTools: Don't Recurse NULL Includes Not Linked to Module Taylor Beebe
2024-03-22 19:19 ` [edk2-devel] [PATCH v2 2/2] BaseTools: Use Stronger Matching for NULL Linked Libraries Taylor Beebe
2024-03-28 1:00 ` 回复: [edk2-devel] [PATCH v2 0/2] Update BaseTools NULL Include and Library Matching gaoliming via groups.io
2024-03-29 0:28 ` Taylor Beebe
2024-04-02 1:37 ` 回复: " gaoliming via groups.io
2024-04-09 19:42 ` Taylor Beebe [this message]
2024-04-15 3:25 ` 回复: " gaoliming via groups.io
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=92b0faf2-dc7b-4b69-ac24-cd96c071748c@gmail.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox