From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 321727803D8 for ; Tue, 9 Apr 2024 19:42:46 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=/vywxQRxBBtuj74d5Jg7lhfvyaCzbnjNi+qyHyTdP+Q=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1712691765; v=1; b=joOMtwCo8h6zldgDWszi0cfxT9QIJ+XaXot9q3OACheoaCRsC6lXR/KNHNIVpCuGfY3swaT6 IRLXWlbwBOQgwSMxbTSTqARNoOUCka8I7WkBb2lfvGLu/fhYFIFXAkR5SOcuQ+FwfpvsYBotYcl 4pOA5SfHjghbLgMJT94wH1/wK9G1fiMl9qNx+THgY0D+U7j/lYl/ERIKONO7if/7Y6D/WUC9wxF Zf6TsZCEUs8tPscHsAwToXnuSSLrauJj+WtqcqAaSukMiKt8XOXg4SpsimDEsjahiTP0hHKF0ml VjNF7M2v92uhd+TQVD0F/RbtvR86nyqsKv0H6RxFqPzjw== X-Received: by 127.0.0.2 with SMTP id zSW9YY7687511x3Xf4uKMSQI; Tue, 09 Apr 2024 12:42:45 -0700 X-Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) by mx.groups.io with SMTP id smtpd.web10.147506.1712691764877150929 for ; Tue, 09 Apr 2024 12:42:44 -0700 X-Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-6ecec796323so5623227b3a.3 for ; Tue, 09 Apr 2024 12:42:44 -0700 (PDT) X-Gm-Message-State: nANnjHHp6hIy1cX7NxI73q6fx7686176AA= X-Google-Smtp-Source: AGHT+IEA/sNfrsmQUGdZr4lTzhmU1bXro4pGr9X+LCK1OqBIGC5QieNlBRyK3K/kiqmIs9V/QP5/9g== X-Received: by 2002:a05:6a00:2d93:b0:6ea:d114:5ea1 with SMTP id fb19-20020a056a002d9300b006ead1145ea1mr641120pfb.17.1712691764020; Tue, 09 Apr 2024 12:42:44 -0700 (PDT) X-Received: from [10.0.4.35] ([4.155.48.122]) by smtp.gmail.com with ESMTPSA id e28-20020aa798dc000000b006e53cc789c3sm8550864pfm.107.2024.04.09.12.42.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Apr 2024 12:42:43 -0700 (PDT) Message-ID: <92b0faf2-dc7b-4b69-ac24-cd96c071748c@gmail.com> Date: Tue, 9 Apr 2024 12:42:43 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: =?UTF-8?B?UmU6IOWbnuWkjTog5Zue5aSNOiBbZWRrMi1kZXZlbF0gW1BBVENIIHYyIDAvMl0gVXBkYXRlIEJhc2VUb29scyBOVUxMIEluY2x1ZGUgYW5kIExpYnJhcnkgTWF0Y2hpbmc=?= To: devel@edk2.groups.io, gaoliming@byosoft.com.cn Cc: 'Rebecca Cran' , 'Bob Feng' , 'Yuwei Chen' References: <20240322191915.184-1-taylor.d.beebe@gmail.com> <062501da80ab$62ddd8c0$28998a40$@byosoft.com.cn> <968375d9-d671-491d-a544-3372089788a8@gmail.com> <018f01da849e$4caff4b0$e60fde10$@byosoft.com.cn> From: "Taylor Beebe" In-Reply-To: <018f01da849e$4caff4b0$e60fde10$@byosoft.com.cn> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Tue, 09 Apr 2024 12:42:44 -0700 Resent-From: taylor.d.beebe@gmail.com Reply-To: devel@edk2.groups.io,taylor.d.beebe@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Language: en-CA Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=joOMtwCo; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi Liming, I made a mistake in patch 2 of the v2 series. In v3, lines 126 and 144=20 of WorkspaceCommon.py update the check to: `LibraryClassName[4:].isdigit()` instead of `LibraryClass[4:].isdigit()` Can you re-review with this change? -Taylor On 4/1/2024 6:37 PM, gaoliming via groups.io wrote: > Taylor: > Thanks for you detail information. I understand this problem. I agree = your fix. Reviewed-by: Liming Gao > > Thanks > Liming > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117558): https://edk2.groups.io/g/devel/message/117558 Mute This Topic: https://groups.io/mt/105280288/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-