From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id B681178003C for ; Mon, 28 Aug 2023 18:43:31 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=39Ln7yXrzx+ZmdfiwdrXj15PktUXR7iOS6K0VEOLY0E=; c=relaxed/simple; d=groups.io; h=DKIM-Filter:Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1693248210; v=1; b=IOFlqdhhwCYNHeJ2ThrpJPTS/vjiMwkmTsa5WnbUWDy0wO0dJcVU8Qud3FH1daAQ/PrEhHkv T+MOD5Qh2CLYLIAnj4SwOG5au/nTfyGqddGev6qYXtjOXkUIvzzMvGmVLoQgB0hRcBtL1Uvrhs8 ygHGVPCqrqnFYU4NnJx1lKbY= X-Received: by 127.0.0.2 with SMTP id tVazYY7687511xv7ZMURg8UM; Mon, 28 Aug 2023 11:43:30 -0700 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web11.1238.1693248209872164563 for ; Mon, 28 Aug 2023 11:43:29 -0700 X-Received: from [10.137.194.171] (unknown [131.107.1.171]) by linux.microsoft.com (Postfix) with ESMTPSA id D7A132127D58; Mon, 28 Aug 2023 11:43:28 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com D7A132127D58 Message-ID: <92b463d6-9c1d-450a-b81a-124b6ea1fd57@linux.microsoft.com> Date: Mon, 28 Aug 2023 11:43:28 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] another PR rejected by CI To: devel@edk2.groups.io, taylor.d.beebe@gmail.com, mike.maslenkin@gmail.com, ardb@kernel.org Cc: Michael Kubacki , Taylor Beebe , Michael Kinney , Leif Lindholm References: From: "Oliver Smith-Denny" In-Reply-To: Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,osde@linux.microsoft.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 8dqsZ3BA6aSu3II6Grzfwamkx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=IOFlqdhh; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=linux.microsoft.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Another option, when the main pipeline page says there is an uncrustify error is to take the cmdline it ran with and append UNCRUSTIFY_IN_PLACE=3DTRUE to it. It will then auto-fixup any uncrustify errors (which obviously should be audited afterwards). I do this to avoid having to wade through numerous errors, especially since I almost always take whatever the auto-format provides. For example, for your failure, if you ran: stuart_ci_build -c .pytool/CISettings.py -p OvmfPkg -t NO-TARGET,NOOPT=20 -a IA32,X64,ARM,AARCH64,RISCV64,LOONGARCH64 TOOL_CHAIN_TAG=3DGCC5=20 UNCRUSTIFY_IN_PLACE=3DTRUE It will autofix the issue. Oliver On 8/28/2023 11:19 AM, Taylor Beebe wrote: > Here's a git-patch so you can easily fix it: >=20 > --- > =C2=A0OvmfPkg/IoMmuDxe/IoMmuBuffer.c | 2 +- > =C2=A01 file changed, 1 insertion(+), 1 deletion(-) > diff --git a/OvmfPkg/IoMmuDxe/IoMmuBuffer.c b/OvmfPkg/IoMmuDxe/IoMmuBuffe= r.c > index 2764c35044ac..d66763263784 100644 > --- a/OvmfPkg/IoMmuDxe/IoMmuBuffer.c > +++ b/OvmfPkg/IoMmuDxe/IoMmuBuffer.c > @@ -434,7 +434,7 @@ IoMmuFreeBounceBuffer ( > =C2=A0 =C2=A0 =C2=A0 =C2=A0mReservedMemBitmap, > =C2=A0 =C2=A0 =C2=A0 =C2=A0mReservedMemBitmap & ((UINT32)(~MapInfo->Rese= rvedMemBitmap)) > =C2=A0 =C2=A0 =C2=A0 =C2=A0)); > - =C2=A0 =C2=A0MapInfo->PlainTextAddress =C2=A0=3D 0; > + =C2=A0 =C2=A0MapInfo->PlainTextAddress =3D 0; > =C2=A0 =C2=A0 =C2=A0ClearReservedMemBit (MapInfo->ReservedMemBitmap); > =C2=A0 =C2=A0 =C2=A0MapInfo->ReservedMemBitmap =3D 0; > =C2=A0 =C2=A0} > --=20 > On 8/28/2023 11:16 AM, Mike Maslenkin wrote: >> Hello! >> >> https://dev.azure.com/tianocore/edk2-ci/_build/results?buildId=3D100301&= view=3Dms.vss-test-web.build-test-results-tab&runId=3D877528&resultId=3D100= 006&paneView=3Dattachments >> >> Uncrustify found formatting errors in IoMmuDxe/IoMmuBuffer.c >> See Standard_Error_Output.log in "attachments" >> >> It doesn't like two spaces at assignment >> MapInfo->PlainTextAddress_ _=3D 0; >> >> Best Regards, >> Mike >> >> >> On Mon, Aug 28, 2023 at 8:58=E2=80=AFPM Ard Biesheuvel = wrote: >>> Could someone please explain to me how I can figure out why this PR >>> was rejected by the CI? >>> >>> https://github.com/tianocore/edk2/pull/4763 >>> >>> >>> >>> >>> >> >> >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108064): https://edk2.groups.io/g/devel/message/108064 Mute This Topic: https://groups.io/mt/101015386/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-