From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=VRNoZJLV; spf=pass (domain: redhat.com, ip: 205.139.110.120, mailfrom: philmd@redhat.com) Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.120]) by groups.io with SMTP; Fri, 27 Sep 2019 03:02:28 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1569578547; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:openpgp:openpgp; bh=jv9bIapmuBhZYT7OniRbbQyiE92kvMZpDNAtIuJmQUM=; b=VRNoZJLVPbl/VIpczR5k4+tqhXZjAMBZNQoC4yD2qE0K3QFV07iBFODOTJFQAKVZ1JqXmc 59C3JXukPfi1wZS+FoGVUJ4qA+fE2/D81d7ntLxAM37q038Q90Li5gLjObVdsZvz+P4WUL ZX3DuuVmqYwoVYASN2RwJqrTAH/rYZM= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-44-rioglKsCMnaMGlj5wHAR9g-1; Fri, 27 Sep 2019 06:02:24 -0400 Received: by mail-wm1-f71.google.com with SMTP id k184so2544043wmk.1 for ; Fri, 27 Sep 2019 03:02:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=LgLFUGhC+0nKf6sNMbgKegjJR97Msqt4XUktwQBJW3s=; b=WvpONOjd74P56g2wN+p3h2z27fK+XllGYx+biwM7DIhG7VUn41ZxuZ2JIRX69SO3LO nQPNTn/iwVD8zJ8gTknPoe9X/hmTnEBeoEEjxEAGzJQqKW+PWRtaD/ybEdrHYdstzGyk 8XKWs+qsIDXh+AmLSni+Lfu3r0/irZUq2sIbqEj+P9CmY/KXD3fZyp2F1GGU3TB063HO G07DLV8hVPaC2AQ1uVcM9a5vLgd8TklGKr4eLuonQHqdTWj7t7H2L6qCo7f0J0lueIIX bIC5at3ta+eHUg7txfbVtgosW0SLz0d3uU2u1sbXz80lSsxqE0n0TsG1EQ5N+q6YXi2R k9fw== X-Gm-Message-State: APjAAAWsd0dwBOhgPgQ7r6LFPm1g6vBeLCKcux1dGmx6qvWFYzslPfTg IaMP/cwMPJCi88RGZYVzfH5UjKqy9ro2EvprvjFR552l0kYiPWcKHpqCnzoNpanAkE1lXMh4Iqe zIQjbsvXNuKtjoQ== X-Received: by 2002:a05:600c:241:: with SMTP id 1mr6453598wmj.162.1569578542638; Fri, 27 Sep 2019 03:02:22 -0700 (PDT) X-Google-Smtp-Source: APXvYqxvQHkjCFupsnbcbr929vxOE7zxhBBCCngN5CB/cMyFyeDyAMUb17z5c9PJxsLrLwz/0nghbA== X-Received: by 2002:a05:600c:241:: with SMTP id 1mr6453587wmj.162.1569578542460; Fri, 27 Sep 2019 03:02:22 -0700 (PDT) Return-Path: Received: from [192.168.1.35] (240.red-88-21-68.staticip.rima-tde.net. [88.21.68.240]) by smtp.gmail.com with ESMTPSA id k9sm4142882wrd.7.2019.09.27.03.02.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 27 Sep 2019 03:02:21 -0700 (PDT) Subject: Re: [edk2-devel] [Patch 1/1] BaseTools: Fix a bug of genffs command generation To: devel@edk2.groups.io, bob.c.feng@intel.com Cc: Liming Gao References: <20190927023017.20424-1-bob.c.feng@intel.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Openpgp: id=89C1E78F601EE86C867495CBA2A3FD6EDEADC0DE; url=http://pgp.mit.edu/pks/lookup?op=get&search=0xA2A3FD6EDEADC0DE Message-ID: <92d30283-2980-01b2-0aa9-c751f7591e3b@redhat.com> Date: Fri, 27 Sep 2019 12:02:21 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20190927023017.20424-1-bob.c.feng@intel.com> X-MC-Unique: rioglKsCMnaMGlj5wHAR9g-1 X-Mimecast-Spam-Score: 0 Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 9/27/19 4:30 AM, Bob Feng wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2221 >=20 > The command used by multiple thread genffs feature in makefile > for testing if file exist is generated based on the toolchain family. > It should be based on the OS type. >=20 > Cc: Liming Gao > Signed-off-by: Bob Feng > --- > BaseTools/Source/Python/GenFds/GenFdsGlobalVariable.py | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/BaseTools/Source/Python/GenFds/GenFdsGlobalVariable.py b/Bas= eTools/Source/Python/GenFds/GenFdsGlobalVariable.py > index 4d8b2bdee299..bd97aa9dd208 100644 > --- a/BaseTools/Source/Python/GenFds/GenFdsGlobalVariable.py > +++ b/BaseTools/Source/Python/GenFds/GenFdsGlobalVariable.py > @@ -11,10 +11,11 @@ > # > from __future__ import print_function > from __future__ import absolute_import > =20 > import Common.LongFilePathOs as os > +import sys > from sys import stdout > from subprocess import PIPE,Popen > from struct import Struct > from array import array > =20 > @@ -484,11 +485,11 @@ class GenFdsGlobalVariable: > Cmd +=3D ("-o", Output) > Cmd +=3D Input > =20 > SaveFileOnChange(CommandFile, ' '.join(Cmd), False) > if IsMakefile: > - if GlobalData.gGlobalDefines.get("FAMILY") =3D=3D "MSFT"= : > + if sys.platform =3D=3D "win32": > Cmd =3D ['if', 'exist', Input[0]] + Cmd > else: > Cmd =3D ['-test', '-e', Input[0], "&&"] + Cmd > if ' '.join(Cmd).strip() not in GenFdsGlobalVariable.Sec= CmdList: > GenFdsGlobalVariable.SecCmdList.append(' '.join(Cmd)= .strip()) >=20 Reviewed-by: Philippe Mathieu-Daude