From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from atlmailgw1.ami.com (atlmailgw1.ami.com [63.147.10.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 862E91A1DF5 for ; Tue, 20 Sep 2016 12:28:50 -0700 (PDT) X-AuditID: ac1060b2-a7fff7000000467b-41-57e18dee1eb6 Received: from atlms2.us.megatrends.com (atlms2.us.megatrends.com [172.16.96.152]) (using TLS with cipher AES128-SHA (128/128 bits)) (Client did not present a certificate) by (Symantec Messaging Gateway) with SMTP id A6.60.18043.EED81E75; Tue, 20 Sep 2016 15:28:49 -0400 (EDT) Received: from ATLMS1.us.megatrends.com ([fe80::8c55:daf0:ef05:5605]) by atlms2.us.megatrends.com ([fe80::29dc:a91e:ea0c:cdeb%12]) with mapi id 14.03.0123.003; Tue, 20 Sep 2016 15:28:33 -0400 From: Felix Poludov To: "Kinney, Michael D" , "Gao, Liming" , "edk2-devel@lists.01.org" Thread-Topic: [PATCH] [MdePkg ] New Debug Message Levels Thread-Index: AdIOoGfwP58VzQt9RL+w0VhTGXv9FAAAR6uQAAb6ZRABImanIAAFA+8wAAZUIrA= Date: Tue, 20 Sep 2016 19:28:33 +0000 Message-ID: <9333E191E0D52B4999CE63A99BA663A00270FEF3B8@atlms1.us.megatrends.com> References: <9333E191E0D52B4999CE63A99BA663A00270FEBC69@atlms1.us.megatrends.com> <9333E191E0D52B4999CE63A99BA663A00270FEBD66@atlms1.us.megatrends.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14B47ACEB@shsmsx102.ccr.corp.intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.16.99.93] content-transfer-encoding: quoted-printable MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprIKsWRmVeSWpSXmKPExsWyRiBhhu7H3ofhBgtOq1jsOXSU2WLFvQ3s Fh0d/5gcmD0W73nJ5NE9+x9LAFNUA6NNYl5efkliSapCSmpxsq1SQFFmWWJypZJCZoqtkqGS QkFOYnJqbmpeia1SYkFBal6Kkh2XAgawASrLzFNIzUvOT8nMS7dV8gz217WwMLXUNVSyC8lI VcjMS8svyk0syczPU0jOzysBqk5NAYoqJHRxZrRfmclScKW04mrfNpYGxum+XYycHBICJhIT Py1g6WLk4hASmM0k8aKpA8o5zChx6GULM0gVm4CKxKazF5hBEiICExklJsz7yNbFyMEhLGAu MeGfDUiNiICFxIup71kgbD+JU7uWs4OUsAioSmw4nAti8goESkw4KQ4xfi2TxMY9Tawg5ZwC IRJ3Vp8CsxkFxCS+n1rDBGIzC4hL3HoynwniUAGJJXvOM0PYohIvH/9jhbAVJLa872SHqNeR WLD7ExuErS2xbOFrsHpeAUGJkzOfsExgFJmFZOwsJC2zkLTMQtKygJFlFaNQYklObmJmTnq5 oV5ibqZecn7uJkZICti0g7HlovkhRgEORiUe3l81D8OFWBPLiitzDzFKcDArifA+6gEK8aYk VlalFuXHF5XmpBYfYnQChspEZiluUBQB4zze2MBAShTGMTQxMzE3Mje0NDE3NlYS5y364xsu JJAOTDvZqakFqUUwQ5g4OKUaGE84J5RvPBP1+e1Sllnzj249Pe9BduQr1R+6FhM3P5W8U3VM 7GdRQJPSN//I6C8J02491u2137Xvo8mnsGj3AM4Xr22t9/vtWFl/nF39gdPXIIWnJg0rjVvs mHz+vL+WEsWSMu1N+aHDR7e6X+Qr3eD2Yi33E6cgnz+7NkidP/TSSrpy80HeUGklluKMREMt 5qLiRADiGxdKJAMAAA== Subject: Re: [PATCH] [MdePkg ] New Debug Message Levels X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Sep 2016 19:28:50 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Mike and Liming, Thanks for reviewing the patch. I implemented all the requested modifications: - EFI_D_ definitions are removed - DEBUG_CSM is removed - Validation expression in MdePkg.dec is updated - MdePkg.uni is updated Here is the updated patch Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Felix Polyudov =3D=3D diff --git a/MdePkg/Include/Library/DebugLib.h b/MdePkg/Include/Library/Debu= gLib.h index 803872c..34ea29f 100644 --- a/MdePkg/Include/Library/DebugLib.h +++ b/MdePkg/Include/Library/DebugLib.h @@ -54,6 +54,11 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER= EXPRESS OR IMPLIED. #define DEBUG_CACHE 0x00200000 // Memory range cachability changes #define DEBUG_VERBOSE 0x00400000 // Detailed debug messages that may // significantly impact boot performanc= e +#define DEBUG_USB 0x00000200 // USB Driver +#define DEBUG_PCI 0x00000800 // PCI Bus Driver +#define DEBUG_CPU 0x00002000 // Processor Driver +#define DEBUG_CHIPSET 0x00008000 // Chipset/SoC Drivers +#define DEBUG_PLATFORM 0x00040000 // Platform/Board Drivers #define DEBUG_ERROR 0x80000000 // Error // diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec index 606e2f1..1747bb1 100644 --- a/MdePkg/MdePkg.dec +++ b/MdePkg/MdePkg.dec @@ -1883,11 +1883,16 @@ # BIT6 - Information message.
# BIT7 - Dispatcher message.
# BIT8 - Variable message.
+ # BIT9 - USB Driver message.
# BIT10 - Boot Manager message.
+ # BIT11 - PCI Bus Driver message.
# BIT12 - BlockIo Driver message.
+ # BIT13 - Processor Driver message.
# BIT14 - Network Driver message.
+ # BIT15 - Chipset/SoC Driver message.
# BIT16 - UNDI Driver message.
# BIT17 - LoadFile message.
+ # BIT18 - Platform/Board Driver message.
# BIT19 - Event message.
# BIT20 - Global Coherency Database changes message.
# BIT21 - Memory range cachability changes message.
@@ -1951,18 +1956,23 @@ # BIT6 - Information message.
# BIT7 - Dispatcher message.
# BIT8 - Variable message.
+ # BIT9 - USB Driver message.
# BIT10 - Boot Manager message.
+ # BIT11 - PCI Bus Driver message.
# BIT12 - BlockIo Driver message.
+ # BIT13 - Processor Driver message.
# BIT14 - Network Driver message.
+ # BIT15 - Chipset/SoC Driver message.
# BIT16 - UNDI Driver message.
# BIT17 - LoadFile message.
+ # BIT18 - Platform/Board Driver message.
# BIT19 - Event message.
# BIT20 - Global Coherency Database changes message.
# BIT21 - Memory range cachability changes message.
# BIT22 - Detailed debug message.
# BIT31 - Error message.
# @Prompt Debug Message Print Level. - # @Expression 0x80000002 | (gEfiMdePkgTokenSpaceGuid.PcdDebugPrintErrorL= evel & 0x7F84AA00) =3D=3D 0 + # @Expression 0x80000002 | (gEfiMdePkgTokenSpaceGuid.PcdDebugPrintErrorL= evel & 0x7F800000) =3D=3D 0 gEfiMdePkgTokenSpaceGuid.PcdDebugPrintErrorLevel|0x80000000|UINT32|0x0000= 0006 ## The mask is used to control ReportStatusCodeLib behavior.

diff --git a/MdePkg/MdePkg.uni b/MdePkg/MdePkg.uni index a110e45..4f3999d 100644 --- a/MdePkg/MdePkg.uni +++ b/MdePkg/MdePkg.uni @@ -196,11 +196,16 @@ = "BIT6 - Information message.
\n" = "BIT7 - Dispatcher message.
\n" = "BIT8 - Variable message.
\n" + = "BIT9 - USB Driver message.
\n" = "BIT10 - Boot Manager message.
\n" + = "BIT11 - PCI Bus Driver message.
\n" = "BIT12 - BlockIo Driver message.
\n" + = "BIT13 - Processor Driver message.
\n" = "BIT14 - Network Driver message.
\n" + = "BIT15 - Chipset/SoC Driver message.
\n" = "BIT16 - UNDI Driver message.
\n" = "BIT17 - LoadFile message.
\n" + = "BIT18 - Platform/Board Driver message.
\n" = "BIT19 - Event message.
\n" = "BIT20 - Global Coherency Database changes message.
\n" = "BIT21 - Memory range cacheability changes message.
\n" @@ -219,11 +224,16 @@ = "BIT6 - Information message.
\n" = "BIT7 - Dispatcher message.
\n" = "BIT8 - Variable message.
\n" + = "BIT9 - USB Driver message.
\n" = "BIT10 - Boot Manager message.
\n" + = "BIT11 - PCI Bus Driver message.
\n" = "BIT12 - BlockIo Driver message.
\n" + = "BIT13 - Processor Driver message.
\n" = "BIT14 - Network Driver message.
\n" + = "BIT15 - Chipset/SoC Driver message.
\n" = "BIT16 - UNDI Driver message.
\n" = "BIT17 - LoadFile message.
\n" + = "BIT18 - Platform/Board Driver message.
\n" = "BIT19 - Event message.
\n" = "BIT20 - Global Coherency Database changes message.
\n" = "BIT21 - Memory range cacheability changes message.
\n" =3D=3D -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Kinne= y, Michael D Sent: Tuesday, September 20, 2016 12:26 PM To: Gao, Liming; Felix Poludov; edk2-devel@lists.01.org; Kinney, Michael D Subject: Re: [edk2] [PATCH] [MdePkg ] New Debug Message Levels Felix, We should only add the DEBUG_ defines for new bit values. We would like to= retire the use of EFI_D_ defines and encourage use of DEBUG_ defines. The= reason is that DEBUG() macros apply to all execution phases and module type= s. Also, what is the use case for DEBUG_CSM. I would image this would only be= used for CSM wrapper modules, and the exiting define values should be suffi= cient for that specific use case. That bit mask is starting to get full. Thanks, Mike > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Gao= , Liming > Sent: Tuesday, September 20, 2016 7:01 AM > To: Felix Poludov ; edk2-devel@lists.01.org > Subject: Re: [edk2] [PATCH] [MdePkg ] New Debug Message Levels > > Felix: > I have two comments. > 1) Update @Expression 0x80000002 | (gEfiMdePkgTokenSpaceGuid.PcdDebugPrin= tErrorLevel > & 0x7F84AA00) =3D=3D 0. 0x7F84AA00 should be updated to match the valid de= bug error level > bit mask. > 2) PCD help message in MdePkg.uni is also required to be updated. > > Thanks > Liming > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Fel= ix Poludov > Sent: Thursday, September 15, 2016 3:27 AM > To: edk2-devel@lists.01.org > Subject: Re: [edk2] [PATCH] [MdePkg ] New Debug Message Levels > > Resending with the patch (the patch was missing in the original e-mail). > > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Fel= ix Poludov > Sent: Wednesday, September 14, 2016 12:05 PM > To: edk2-devel@lists.01.org > Subject: [edk2] [PATCH] [MdePkg ] New Debug Message Levels > > Dear MdePkg maintainer, > > DebugLib.h defines debug message levels. Some values such as DEBUG_ERROR a= nd > DEBUG_INFO define messages category, whereas other values such as DEBUG_BL= KIO and > DEBUG_VARIABLE define message domain. > This patch adds definitions for several additional message domains. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Felix Polyudov > > > Thanks > Felix > > =3D=3D > diff --git a/MdePkg/Include/Library/DebugLib.h b/MdePkg/Include/Library/De= bugLib.h > index 803872c..47549b7 100644 > --- a/MdePkg/Include/Library/DebugLib.h > +++ b/MdePkg/Include/Library/DebugLib.h > @@ -54,6 +54,12 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITH= ER EXPRESS > OR IMPLIED. > #define DEBUG_CACHE 0x00200000 // Memory range cachability changes > #define DEBUG_VERBOSE 0x00400000 // Detailed debug messages that may > // significantly impact boot performa= nce > +#define DEBUG_USB 0x00000200 // USB Driver > +#define DEBUG_PCI 0x00000800 // PCI Bus Driver > +#define DEBUG_CSM 0x00002000 // Compatibility Support Module > +#define DEBUG_CPU 0x00008000 // Processor Driver > +#define DEBUG_CHIPSET 0x00040000 // Chipset/SoC Drivers > +#define DEBUG_PLATFORM 0x00800000 // Platform/Board Drivers > #define DEBUG_ERROR 0x80000000 // Error > > // > @@ -75,6 +81,12 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITH= ER EXPRESS > OR IMPLIED. > #define EFI_D_LOADFILE DEBUG_LOADFILE > #define EFI_D_EVENT DEBUG_EVENT > #define EFI_D_VERBOSE DEBUG_VERBOSE > +#define EFI_D_USB DEBUG_USB > +#define EFI_D_PCI DEBUG_PCI > +#define EFI_D_CSM DEBUG_CSM > +#define EFI_D_CPU DEBUG_CPU > +#define EFI_D_CHIPSET DEBUG_CHIPSET > +#define EFI_D_PLATFORM DEBUG_PLATFORM > #define EFI_D_ERROR DEBUG_ERROR > > /** > diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec > index 606e2f1..eaae076 100644 > --- a/MdePkg/MdePkg.dec > +++ b/MdePkg/MdePkg.dec > @@ -1883,15 +1883,21 @@ > # BIT6 - Information message.
> # BIT7 - Dispatcher message.
> # BIT8 - Variable message.
> + # BIT9 - USB Driver message.
> # BIT10 - Boot Manager message.
> + # BIT11 - PCI Bus Driver message.
> # BIT12 - BlockIo Driver message.
> + # BIT13 - Compatibility Support Module message.
> # BIT14 - Network Driver message.
> + # BIT15 - Processor Driver message.
> # BIT16 - UNDI Driver message.
> # BIT17 - LoadFile message.
> + # BIT18 - Chipset/SoC Driver message.
> # BIT19 - Event message.
> # BIT20 - Global Coherency Database changes message.
> # BIT21 - Memory range cachability changes message.
> # BIT22 - Detailed debug message.
> + # BIT23 - Platform/Board Driver message.
> # BIT31 - Error message.
> # @Prompt Fixed Debug Message Print Level. > gEfiMdePkgTokenSpaceGuid.PcdFixedDebugPrintErrorLevel|0xFFFFFFFF|UINT32= |0x30001016 > @@ -1951,15 +1957,21 @@ > # BIT6 - Information message.
> # BIT7 - Dispatcher message.
> # BIT8 - Variable message.
> + # BIT9 - USB Driver message.
> # BIT10 - Boot Manager message.
> + # BIT11 - PCI Bus Driver message.
> # BIT12 - BlockIo Driver message.
> + # BIT13 - Compatibility Support Module message.
> # BIT14 - Network Driver message.
> + # BIT15 - Processor Driver message.
> # BIT16 - UNDI Driver message.
> # BIT17 - LoadFile message.
> + # BIT18 - Chipset/SoC Driver message.
> # BIT19 - Event message.
> # BIT20 - Global Coherency Database changes message.
> # BIT21 - Memory range cachability changes message.
> # BIT22 - Detailed debug message.
> + # BIT23 - Platform/Board Driver message.
> # BIT31 - Error message.
> # @Prompt Debug Message Print Level. > # @Expression 0x80000002 | (gEfiMdePkgTokenSpaceGuid.PcdDebugPrintErro= rLevel & > 0x7F84AA00) =3D=3D 0 > > Please consider the environment before printing this email. > > The information contained in this message may be confidential and propriet= ary to > American Megatrends, Inc. This communication is intended to be read only= by the > individual or entity to whom it is addressed or by their designee. If the= reader of > this message is not the intended recipient, you are on notice that any dis= tribution > of this message, in any form, is strictly prohibited. Please promptly not= ify the > sender by reply e-mail or by telephone at 770-246-8600, and then delete or= destroy > all copies of the transmission. > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel Please consider the environment before printing this email. The information contained in this message may be confidential and proprietar= y to American Megatrends, Inc. This communication is intended to be read on= ly by the individual or entity to whom it is addressed or by their designee.= If the reader of this message is not the intended recipient, you are on not= ice that any distribution of this message, in any form, is strictly prohibit= ed. Please promptly notify the sender by reply e-mail or by telephone at 77= 0-246-8600, and then delete or destroy all copies of the transmission.