From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from atlmailgw2.ami.com (atlmailgw2.ami.com [63.147.10.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 546EB81D99 for ; Fri, 28 Oct 2016 06:52:13 -0700 (PDT) X-AuditID: ac10606f-d93ff70000000890-10-5813580b46eb Received: from atlms2.us.megatrends.com (atlms2.us.megatrends.com [172.16.96.152]) (using TLS with cipher AES128-SHA (128/128 bits)) (Client did not present a certificate) by (Symantec Messaging Gateway) with SMTP id 5A.7D.02192.B0853185; Fri, 28 Oct 2016 09:52:12 -0400 (EDT) Received: from ATLMS1.us.megatrends.com ([fe80::8c55:daf0:ef05:5605]) by atlms2.us.megatrends.com ([fe80::29dc:a91e:ea0c:cdeb%12]) with mapi id 14.03.0123.003; Fri, 28 Oct 2016 09:52:10 -0400 From: Felix Poludov To: "Dong, Eric" , "edk2-devel@lists.01.org" CC: "Gao, Liming" , "Bi, Dandan" Thread-Topic: [RFC] [MdePkg] UefiLib: CreatePopUp Thread-Index: AdIwjdjhOCSq+FCtTKCTGmtOXAGI2QAMMLIgABg3kNA= Date: Fri, 28 Oct 2016 13:52:10 +0000 Message-ID: <9333E191E0D52B4999CE63A99BA663A00270FF787F@atlms1.us.megatrends.com> References: <9333E191E0D52B4999CE63A99BA663A00270FF754E@atlms1.us.megatrends.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.16.99.93] content-transfer-encoding: quoted-printable MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprLKsWRmVeSWpSXmKPExsWyRiBhhi5PhHCEwblnphZbt6lb7Dl0lNli 84tgixX3NrA7sHgs3vOSyaN79j+WAKaoBkabxLy8/JLEklSFlNTiZFulgKLMssTkSiWFzBRb JUMlhYKcxOTU3NS8ElulxIKC1LwUJTsuBQxgA1SWmaeQmpecn5KZl26r5Bnsr2thYWqpa6hk F5KRqpCZl5ZflJtYkpmfp5Ccn1cCVJ2aAhRVSOjizFhx+BljQadcxfG2DrYGxpsSXYycHBIC JhInG3czdjFycQgJzGaSWLNpEgtIQkjgMKNEc7MNiM0moCKx6ewFZhBbRCBWYsqu/+xdjBwc zAI+EmcvRICYwgIGEkevRENUGEo8PnOTESQsImAl8WWLEUiYRUBV4u23m2wgYV6BQImt/yOg ljJKXJpxBmwpp0CIRPPt02A2o4CYxPdTa5hAbGYBcYlbT+YzQVwsILFkz3lmCFtU4uXjf6wQ toLElved7BD1OhILdn9ig7C1JZYtfA1WzysgKHFy5hOWCYyis5CMnYWkZRaSlllIWhYwsqxi FEosyclNzMxJLzfSS8zN1EvOz93ECEkN+TsYP340P8QowMGoxMP7xls4Qog1say4MvcQowQH s5II755goBBvSmJlVWpRfnxRaU5q8SFGJ2CwTGSW4gbFFTDy440NDKREYRxDEzMTcyNzQ0sT c2NjJXFe6b++4UIC6cBElJ2aWpBaBDOEiYNTqoHx6MxXKjb3fR/E9nJG/hE94LkvujZP7eKN 7W23Os8v6n6bmbX2o+Up5Y6EHKNnz87e034u+r27fdupgzsX7pzN3fdmcWdzLpPSpESveVcm HmiWmL56ksvNlx67/y15zHdydVTbqQfSvN4ve6bPfs6uXhybei7hZuYtg2ef7Z4EptWHpl9Z eTIzR4mlOCPRUIu5qDgRAGn1bX8wAwAA Subject: Re: [RFC] [MdePkg] UefiLib: CreatePopUp X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Oct 2016 13:52:13 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Hi Eric, My goal is to facilitate CreatePopUp customization. Since UI is one of the most customizable areas in the firmware projects, an= ability to easily replace UI element would be useful. Thank you for providing the presentation. I agree with the problem statement. It describes some of the reasons behind= my request. As far as the solution you propose, you are introducing a new function HiiGe= tUserSelection, which is more powerful, but still implements a specific look= -and-feel. So it should be possible to easily replace HiiGetUserSelection with a projec= t specific version to align implementation with project-specific UI. Which library class are you planning to add HiiGetUserSelection to? Another question is, what are you planning to do with the existing CreatePop= Up function? If you just remove it, existing projects that use the function will break. With my proposal, CreatePopUp can be easily replaced by picking a different= library instance. For example, we can have a legacy instance that implements current behavior= as well as and advanced instance that implements popup using HII infrastruc= ture. Thanks Felix -----Original Message----- From: Dong, Eric [mailto:eric.dong@intel.com] Sent: Thursday, October 27, 2016 10:36 PM To: Felix Poludov; edk2-devel@lists.01.org Cc: Gao, Liming; Bi, Dandan Subject: RE: [RFC] [MdePkg] UefiLib: CreatePopUp Hi Felix, Do you want to provide a new solution for CreatePopup or just want to split= CreatePopup from UefiLib? We already has a proposal to provide new API to= replace CreatePopup. This new API will use modal form to paint the UI. Deta= il you can see the proposal in below link: https://github.com/ydong10/doc/blob/master/Use%20Modal%20form%20for%20Create= Popup%20API.pptx Thanks, Eric > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Fel= ix Poludov > Sent: Friday, October 28, 2016 5:12 AM > To: edk2-devel@lists.01.org > Subject: [edk2] [RFC] [MdePkg] UefiLib: CreatePopUp > > UefiLib library class (MdePkg ) includes CreatePopUp function. > The function displays a message box. > There is certainly more than one way to draw a message box. > If homogenous user interface is a project requirement, > CreatePopUp is likely to be overridden to align message box appearance wit= h the platform look and feel. > The function can be overridden by creating a project specific UefiLib inst= ance, but this seems like an overkill > because the rest of the UefiLib, which is quite big, would have to be dupl= icated. > > One way to solve the problem is to move CreatePopUp to a new library class= , however, this may break existing projects. > I suggest changing CreatePopUp implementation to delegate pop up drawing t= o a new > function UiCreatePopUp provided by a new library class UiLib.h. > > I would like to solicit feedback for this proposal. > If there will be no major objections, I'll start working on a patch. > > Thanks > Felix > > Please consider the environment before printing this email. > > The information contained in this message may be confidential and propriet= ary to American Megatrends, Inc. This communication is > intended to be read only by the individual or entity to whom it is address= ed or by their designee. If the reader of this message is not the > intended recipient, you are on notice that any distribution of this messag= e, in any form, is strictly prohibited. Please promptly notify the > sender by reply e-mail or by telephone at 770-246-8600, and then delete or= destroy all copies of the transmission. > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel Please consider the environment before printing this email. The information contained in this message may be confidential and proprietar= y to American Megatrends, Inc. This communication is intended to be read on= ly by the individual or entity to whom it is addressed or by their designee.= If the reader of this message is not the intended recipient, you are on not= ice that any distribution of this message, in any form, is strictly prohibit= ed. Please promptly notify the sender by reply e-mail or by telephone at 77= 0-246-8600, and then delete or destroy all copies of the transmission.