public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Felix Poludov <Felixp@ami.com>
To: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: [PATCH] staging/edk2-test: TestProfile bug fix
Date: Wed, 2 Aug 2017 13:53:54 +0000	[thread overview]
Message-ID: <9333E191E0D52B4999CE63A99BA663A00302B394D6@atlms1.us.megatrends.com> (raw)

The patch is a bug fix for TestFrameworkPkg/Support/TestProfile driver.
AsciiStrCpy function was used to copy overlapping strings, which triggered an ASSERT.

The function was used on overlapping strings in a couple of places:
1. _alltrim: AsciiStrCpy is replaced with CopyMem, which can handle overlapping buffers
2. _prosessLine: AsciiStrCpy at the beginning of the function is removed.
The call was redundant. The function was trying to move the data that have already been moved by _alltrim.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Felix Polyudov <felixp@ami.com>
---

diff --git a/TestFrameworkPkg/Support/TestProfile/TestProfile.c b/TestFrameworkPkg/Support/TestProfile/TestProfile.c
index f02e9df..3f0e0d5 100644
--- a/TestFrameworkPkg/Support/TestProfile/TestProfile.c
+++ b/TestFrameworkPkg/Support/TestProfile/TestProfile.c
@@ -269,7 +269,7 @@ Routine Description:
   }
   tmp[Index] = '\0';
-  AsciiStrCpy (ptrStr, tmp);
+  CopyMem(ptrStr, tmp, Index+1);
   return ptrStr;
}
@@ -419,7 +419,7 @@ Routine Description:
   CHAR8 ptrValue[MAX_STRING_LEN + 1];
   INI   *ptrItem;
-  AsciiStrCpy (ptrLine, _alltrim (ptrLine));
+  _alltrim (ptrLine);
   if (*ptrLine == '#') {
     // it's a comment line


Please consider the environment before printing this email.

The information contained in this message may be confidential and proprietary to American Megatrends, Inc.  This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited.  Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.


             reply	other threads:[~2017-08-02 13:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-02 13:53 Felix Poludov [this message]
2017-08-02 17:37 ` [PATCH] staging/edk2-test: TestProfile bug fix Kinney, Michael D
2017-08-02 17:53   ` Felix Poludov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9333E191E0D52B4999CE63A99BA663A00302B394D6@atlms1.us.megatrends.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox