From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from atlmailgw1.ami.com (atlmailgw1.ami.com [63.147.10.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id DA00C21D491B2 for ; Wed, 2 Aug 2017 09:28:40 -0700 (PDT) X-AuditID: ac1060b2-099ff70000000ee1-66-5981fe3aa148 Received: from atlms2.us.megatrends.com (atlms2.us.megatrends.com [172.16.96.152]) (using TLS with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by atlmailgw1.ami.com (Symantec Messaging Gateway) with SMTP id 42.97.03809.A3EF1895; Wed, 2 Aug 2017 12:30:50 -0400 (EDT) Received: from ATLMS1.us.megatrends.com ([fe80::8c55:daf0:ef05:5605]) by atlms2.us.megatrends.com ([fe80::29dc:a91e:ea0c:cdeb%12]) with mapi id 14.03.0123.003; Wed, 2 Aug 2017 12:30:49 -0400 From: Felix Poludov To: Marvin H?user , "edk2-devel@lists.01.org" CC: "michael.d.kinney@intel.com" , "Gao, Liming" Thread-Topic: [PATCH] MdePkg: Add PcdPciExpressRegionLength PCD Token Thread-Index: AdMLlX81eFs3tOGETJ+auIxES1UwdgAAR/hQAAVZmpA= Date: Wed, 2 Aug 2017 16:30:48 +0000 Message-ID: <9333E191E0D52B4999CE63A99BA663A00302B395EA@atlms1.us.megatrends.com> References: <9333E191E0D52B4999CE63A99BA663A00302B394A5@atlms1.us.megatrends.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.16.99.93] content-transfer-encoding: quoted-printable MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrBKsWRmVeSWpSXmKPExsWyRiBhhq7Vv8ZIgy9HNS32HDrKbLHi3gZ2 i7f/r7JbdHT8Y3Jg8Vi85yWTR/fsfywem1+/YA5gjmpgtEnMy8svSSxJVUhJLU62VQooyixL TK5UUshMsVUyVFIoyElMTs1NzSuxVUosKEjNS1Gy41LAADZAZZl5Cql5yfkpmXnptkqewf66 FhamlrqGSnYhGakKmXlp+UW5iSWZ+XkKyfl5JUDVqSlAUYWELs6Mw9vWshb8lqtoeH2LqYGx RaqLkZNDQsBEonXlVNYuRi4OIYHtTBKzu2cwgSSEBA4xStxflwFiswmoSGw6e4EZxBYRSJXY vm0yC4jNDGRf2biQHcQWFnCR2PHzJztEjavEqlcH2SBsK4n161+DxVmA5tzc+x0szisQKHH1 6TVmiMVLGCW+33oFVsQpECuxpf0AWBGjgJjE91NrmCCWiUvcejKfCeJqAYkle84zQ9iiEi8f /2OFsBUktrzvZIeo15FYsPsTG4StLbFs4WtmiMWCEidnPmGZwCg6C8nYWUhaZiFpmYWkZQEj yypGocSSnNzEzJz0ckO9xNxMveT83E2MkISxaQdjy0XzQ4wCHIxKPLyHvjRGCrEmlhVX5gKD koNZSYS3/ydQiDclsbIqtSg/vqg0J7X4EKMTMFwmMktxg+ILmADijQ0MpERhHEMTMxNzI3ND SxNzY2MlcV6fhvBIIYF0YELKTk0tSC2CGcLEwSnVwFh/b9KK20vMZuz613fSYWLcmoZO8+4P pyK2S82asG/9gh2HTDsXb/o76yjbpq+uIp5KlbY86bYxc0O/LmhY7eHBLLmyVv7zjY1pz4IE v1gFtqz9ZGjrdSwurSZK4J5R1T8h17dGGw0239qpZWxsvL3lUU2R7+G3/L06KmaN/y1evZ2a qHXwpZYSS3FGoqEWc1FxIgBMCXTZOwMAAA== Subject: Re: [PATCH] MdePkg: Add PcdPciExpressRegionLength PCD Token X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Aug 2017 16:28:41 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" I find that many platform packages have some kind of PCD token to represent= size of the PCI express region. That is the reason I think it should be standardized. As far as PCD token name and type (UINT32 vs. UINT64), I'm seeking community= feedback. Both PcdPciExpressSize and PcdPciExpressRegionLength are names used in diffe= rent platform packages. -----Original Message----- From: Marvin H?user [mailto:Marvin.Haeuser@outlook.com] Sent: Wednesday, August 02, 2017 9:57 AM To: edk2-devel@lists.01.org Cc: Felix Poludov; michael.d.kinney@intel.com; Gao, Liming Subject: RE: [PATCH] MdePkg: Add PcdPciExpressRegionLength PCD Token A bunch of platforms, such as QuarkSocPkg, already declare such a PCD named= PcdPciExpressSize of type UINT64. Maybe PcdPciExpressSize|UINT64 should be 'promoted' to a MdePkg PCD and the= platform-defined PCDs replaced? Regards, Marvin. > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Felix Poludov > Sent: Wednesday, August 2, 2017 3:48 PM > To: edk2-devel@lists.01.org > Subject: [edk2] [PATCH] MdePkg: Add PcdPciExpressRegionLength PCD > Token > > Add PcdPciExpressRegionLength PCD Token to MdePkg. > The new token can be used in conjunction with PcdPciExpressBaseAddress > PCD token to describe PCI Express MMIO region. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Felix Polyudov > --- > > Resending with inline patch. > > -- > diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec index > d6928b3..7e55019 100644 > --- a/MdePkg/MdePkg.dec > +++ b/MdePkg/MdePkg.dec > @@ -2089,6 +2089,10 @@ > # @Prompt PCI Express Base Address. > > gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress|0xE0000000|UINT6 > 4|0x0000000a > + ## Length of the PCI express region. > + # @Prompt PCI Express Region Length. > + > + > gEfiMdePkgTokenSpaceGuid.PcdPciExpressRegionLength|0x10000000|UINT > 32|0 > + x00000031 > + > ## Default current ISO 639-2 language: English & French. > # @Prompt Default Value of LangCodes Variable. > > gEfiMdePkgTokenSpaceGuid.PcdUefiVariableDefaultLangCodes|"engfraengf > ra"|VOID*|0x0000001c > diff --git a/MdePkg/MdePkg.uni b/MdePkg/MdePkg.uni index > a110e45..62df5dc 100644 > --- a/MdePkg/MdePkg.uni > +++ b/MdePkg/MdePkg.uni > @@ -276,6 +276,10 @@ > #string STR_gEfiMdePkgTokenSpaceGuid_PcdPciExpressBaseAddress_HELP > #language en-US "This value is used to set the base address of PCI > express hierarchy." > +#string > STR_gEfiMdePkgTokenSpaceGuid_PcdPciExpressRegionLength_PROMPT > #language en-US "PCI Express Region Length" > + > +#string > STR_gEfiMdePkgTokenSpaceGuid_PcdPciExpressRegionLength_HELP > #language en-US "Length of the PCI express region." > + > #string > STR_gEfiMdePkgTokenSpaceGuid_PcdUefiVariableDefaultLangCodes_PROM > PT #language en-US "Default Value of LangCodes Variable" > #string > STR_gEfiMdePkgTokenSpaceGuid_PcdUefiVariableDefaultLangCodes_HELP > #language en-US "Default current ISO 639-2 language: English & French." > -- > > Please consider the environment before printing this email. > > The information contained in this message may be confidential and > proprietary to American Megatrends, Inc. This communication is > intended to be read only by the individual or entity to whom it is > addressed or by their designee. If the reader of this message is not > the intended recipient, you are on notice that any distribution of > this message, in any form, is strictly prohibited. Please promptly > notify the sender by reply e-mail or by telephone at 770-246-8600, and > then delete or destroy all copies of the transmission. > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel Please consider the environment before printing this email. The information contained in this message may be confidential and proprietar= y to American Megatrends, Inc. This communication is intended to be read on= ly by the individual or entity to whom it is addressed or by their designee.= If the reader of this message is not the intended recipient, you are on not= ice that any distribution of this message, in any form, is strictly prohibit= ed. Please promptly notify the sender by reply e-mail or by telephone at 77= 0-246-8600, and then delete or destroy all copies of the transmission.