public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Felix Poludov <Felixp@ami.com>
To: Michael D Kinney <michael.d.kinney@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: Andrew Fish <afish@apple.com>
Subject: Re: [edk2-staging/edk2-test Patch V2 0/2] TestFrameworkPkg/TestProfile: Fix overlapping buffer ASSERT()
Date: Thu, 17 Aug 2017 03:16:43 +0000	[thread overview]
Message-ID: <9333E191E0D52B4999CE63A99BA663A00302B3EE5B@atlms1.us.megatrends.com> (raw)
In-Reply-To: <20170815035718.1560-1-michael.d.kinney@intel.com>

The patch looks fine.
Reviewed-by: Felix Polyudov <felixp@ami.com>

-----Original Message-----
From: Michael D Kinney [mailto:michael.d.kinney@intel.com]
Sent: Monday, August 14, 2017 11:57 PM
To: edk2-devel@lists.01.org
Cc: Andrew Fish; Michael Kinney; Felix Poludov
Subject: [edk2-staging/edk2-test Patch V2 0/2] TestFrameworkPkg/TestProfile: Fix overlapping buffer ASSERT()

New in V2
* Update the DSC files to improve debug of the TestFrameworkPkg
  and TestCasePkg.

The patch is a bug fix for TestFrameworkPkg/Support/TestProfile
driver. AsciiStrCpy() function was used to copy overlapping strings, which triggered an ASSERT().

Cc: Andrew Fish <afish@apple.com>
Cc: Michael Kinney <michael.d.kinney@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Felix Polyudov <felixp@ami.com>

Michael D Kinney (2):
  Test*Pkg: Update DSC files to improve debug
  TestFrameworkPkg/TestProfile: Fix overlapping buffer ASSERT()

 TestCasePkg/TestCasePkg.dsc                        | 65 ++++++++++++++++++++++
 TestFrameworkPkg/Support/TestProfile/TestProfile.c |  4 +-
 TestFrameworkPkg/TestFrameworkPkg.dsc              | 62 +++++++++++++++++++++
 3 files changed, 129 insertions(+), 2 deletions(-)

--
2.13.1.windows.2


Please consider the environment before printing this email.

The information contained in this message may be confidential and proprietary to American Megatrends, Inc.  This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited.  Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.


      parent reply	other threads:[~2017-08-17  3:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-15  3:57 [edk2-staging/edk2-test Patch V2 0/2] TestFrameworkPkg/TestProfile: Fix overlapping buffer ASSERT() Michael D Kinney
2017-08-15  3:57 ` [edk2-staging/edk2-test Patch V2 1/2] Test*Pkg: Update DSC files to improve debug Michael D Kinney
2017-08-15  3:57 ` [edk2-staging/edk2-test Patch V2 2/2] TestFrameworkPkg/TestProfile: Fix overlapping buffer ASSERT() Michael D Kinney
2017-08-17  3:16 ` Felix Poludov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9333E191E0D52B4999CE63A99BA663A00302B3EE5B@atlms1.us.megatrends.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox