From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: ami.com, ip: 63.147.10.42, mailfrom: felixp@ami.com) Received: from atlmailgw2.ami.com (atlmailgw2.ami.com [63.147.10.42]) by groups.io with SMTP; Thu, 04 Apr 2019 14:15:05 -0700 X-AuditID: ac10606f-22dff7000000384e-3f-5ca673d660d7 Received: from atlms2.us.megatrends.com (atlms2.us.megatrends.com [172.16.96.152]) (using TLS with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (Client did not present a certificate) by atlmailgw2.ami.com (Symantec Messaging Gateway) with SMTP id 34.95.14414.6D376AC5; Thu, 4 Apr 2019 17:15:02 -0400 (EDT) Received: from ATLMS1.us.megatrends.com ([fe80::8c55:daf0:ef05:5605]) by atlms2.us.megatrends.com ([fe80::29dc:a91e:ea0c:cdeb%12]) with mapi id 14.03.0415.000; Thu, 4 Apr 2019 17:15:00 -0400 From: felixp@ami.com To: "devel@edk2.groups.io" , "'dandan.bi@intel.com'" CC: Liming Gao , Jian J Wang , Hao Wu Subject: Re: [edk2-devel] [patch 4/7] MdeModulePkg: Move BaseUefiTianoCustomDecompressLib to Thread-Topic: [edk2-devel] [patch 4/7] MdeModulePkg: Move BaseUefiTianoCustomDecompressLib to Thread-Index: AQHU6u2/WFFgn03wtEunMkQSdjDqgqYsfoyg Date: Thu, 4 Apr 2019 21:14:59 +0000 Message-ID: <9333E191E0D52B4999CE63A99BA663A00302C73274@atlms1.us.megatrends.com> References: <20190404135209.13116-1-dandan.bi@intel.com> <20190404135209.13116-5-dandan.bi@intel.com> In-Reply-To: <20190404135209.13116-5-dandan.bi@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.16.99.93] content-transfer-encoding: quoted-printable MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrEKsWRmVeSWpSXmKPExsWyRiBhhu614mUxBkeW6lhs3aZu0T5hNpvF 1Vu/mCzmfZvBarHi3gZ2B1aP7d8vMHos3vOSKYApqoHRJjEvL78ksSRVISW1ONlWKaAosywx uVJJITPFVslQSaEgJzE5NTc1r8RWKbGgIDUvRcmOSwED2ACVZeYppOYl56dk5qXbKnkG++ta WJha6hoq2YVkpCpk5qXlF+UmlmTm5ykk5+eVAFWnpgBFFRK6ODNmP+Us+OxT0XA/soHxl1MX IyeHhICJxLet/9m6GLk4hAR2MUms2/iYCcI5xChxZF0zC0gVm4CqxPHVIDYHh4hAksTC9Qog YWaBTIlZC5+zgtjCAnESLx5uYgOxRQTiJS5/OQ1VbiTxfXUGSJhFQEVifdMBJhCbVyBQomPT MrDpQgLpEr3b34GVcwpYSlx7HwUSZhQQk/h+ag0TxCZxiVtP5jNBnCwgsWTPeWYIW1Ti5eN/ rBC2gsSW953sEPU6Egt2f2KDsLUlli18zQyxVlDi5MwnLBMYRWchGTsLScssJC2zkLQsYGRZ xSiUWJKTm5iZk15upJeYm6mXnJ+7iRGSJPJ3MH78aH6IUYCDUYmHd0b6shgh1sSy4spcYDhy MCuJ8AZ/XxojxJuSWFmVWpQfX1Sak1p8iNEJGCoTmaW4QVEFjPt4YwMDKVEYx9DEzMTcyNzQ 0sTc2FhJnDd/bVMMMLCAaSg7NbUgtQhmCBMHp1QDI1/64xPas8q55JQ38X1u89o2645K66qg Z3sDOFRPLFe5wKbQInjg83t17WyfbaUCvCXH2o+6H9lll2ewoVOgnnurYeWKxD8cu3kT9qpO 0/t/8/c+Jgn3JDH7L+erK389FYt+7PryqFvXXDOuDm+JM2lP56xouNsQ8e7Ewi/FR1dvtEq4 K7jHRImlOCPRUIu5qDgRAHtYZO01AwAA Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Dandan, Since UEFI compression and Tiano compression are just different flavors of t= he same algorithm (the same algorithm with different PBit values), I think it's better not to have two parallel implementation in BaseUefiDecom= pressLib.c and BaseUefiTianoCustomDecompressLib.c. A cleaner approach would be to share the same decompression code between two= libraries. -----Original Message----- From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Dandan= Bi Sent: Thursday, April 04, 2019 9:52 AM To: devel@edk2.groups.io Cc: Liming Gao; Jian J Wang; Hao Wu Subject: [edk2-devel] [patch 4/7] MdeModulePkg: Move BaseUefiTianoCustomDeco= mpressLib to REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1683 We will remove IntelFrameworkModulePkg, but BaseUefiTianoCustomDecompressLib may still need to be used. So move BaseUefiTianoCustomDecompressLib from IntelFrameworkModulePkg to MdeModulePkg. Cc: Liming Gao Cc: Jian J Wang Cc: Hao Wu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Dandan Bi --- IntelFrameworkModulePkg/IntelFrameworkModulePkg.dec | 4 ---- IntelFrameworkModulePkg/IntelFrameworkModulePkg.dsc | 1 - .../Include/Guid/TianoDecompress.h | 0 .../BaseUefiTianoCustomDecompressLib.c | 0 .../BaseUefiTianoCustomDecompressLib.inf | 2 +- .../BaseUefiTianoCustomDecompressLibInternals.h | 0 .../BaseUefiTianoDecompressLib.uni | 0 MdeModulePkg/MdeModulePkg.dec | 4 ++++ MdeModulePkg/MdeModulePkg.dsc | 1 + 9 files changed, 6 insertions(+), 6 deletions(-) rename {IntelFrameworkModulePkg =3D> MdeModulePkg}/Include/Guid/TianoDecomp= ress.h (100%) rename {IntelFrameworkModulePkg =3D> MdeModulePkg}/Library/BaseUefiTianoCus= tomDecompressLib/BaseUefiTianoCustomDecompressLib.c (100%) rename {IntelFrameworkModulePkg =3D> MdeModulePkg}/Library/BaseUefiTianoCus= tomDecompressLib/BaseUefiTianoCustomDecompressLib.inf (94%) rename {IntelFrameworkModulePkg =3D> MdeModulePkg}/Library/BaseUefiTianoCus= tomDecompressLib/BaseUefiTianoCustomDecompressLibInternals.h (100%) rename {IntelFrameworkModulePkg =3D> MdeModulePkg}/Library/BaseUefiTianoCus= tomDecompressLib/BaseUefiTianoDecompressLib.uni (100%) diff --git a/IntelFrameworkModulePkg/IntelFrameworkModulePkg.dec b/IntelFram= eworkModulePkg/IntelFrameworkModulePkg.dec index 5557b5a1cd..0a451dd9ee 100644 --- a/IntelFrameworkModulePkg/IntelFrameworkModulePkg.dec +++ b/IntelFrameworkModulePkg/IntelFrameworkModulePkg.dec @@ -40,14 +40,10 @@ ## GUID identifies Data Hub records logged by Status Code Runtime Protoco= l. # Include/Guid/DataHubStatusCodeRecord.h gEfiDataHubStatusCodeRecordGuid =3D { 0xD083E94C, 0x6560, 0x42E4, { 0xB6,= 0xD4, 0x2D, 0xF7, 0x5A, 0xDF, 0x6A, 0x2A }} - ## GUID indicates the tiano custom compress/decompress algorithm. - # Include/Guid/TianoDecompress.h - gTianoCustomDecompressGuid =3D { 0xA31280AD, 0x481E, 0x41B6, { 0x95,= 0xE8, 0x12, 0x7F, 0x4C, 0x98, 0x47, 0x79 }} - ## Include/Guid/AcpiVariable.h gEfiAcpiVariableCompatiblityGuid =3D { 0xc020489e, 0x6db2, 0x4ef2, { 0x= 9a, 0xa5, 0xca, 0x6, 0xfc, 0x11, 0xd3, 0x6a }} ## Include/Guid/LegacyBios.h gEfiLegacyBiosGuid =3D { 0x2E3044AC, 0x879F, 0x490F, { 0x= 97, 0x60, 0xBB, 0xDF, 0xAF, 0x69, 0x5F, 0x50 }} diff --git a/IntelFrameworkModulePkg/IntelFrameworkModulePkg.dsc b/IntelFram= eworkModulePkg/IntelFrameworkModulePkg.dsc index 949a181a7b..2afda5df79 100644 --- a/IntelFrameworkModulePkg/IntelFrameworkModulePkg.dsc +++ b/IntelFrameworkModulePkg/IntelFrameworkModulePkg.dsc @@ -117,11 +117,10 @@ gEfiMdePkgTokenSpaceGuid.PcdDebugPropertyMask|0x0f gEfiMdePkgTokenSpaceGuid.PcdReportStatusCodePropertyMask|0x06 gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress|0xE0000000 [Components] - IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefi= TianoCustomDecompressLib.inf IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompr= essLib.inf IntelFrameworkModulePkg/Library/PeiS3Lib/PeiS3Lib.inf IntelFrameworkModulePkg/Library/PeiRecoveryLib/PeiRecoveryLib.inf IntelFrameworkModulePkg/Library/DxeReportStatusCodeLibFramework/DxeReport= StatusCodeLib.inf IntelFrameworkModulePkg/Library/SmmRuntimeDxeReportStatusCodeLibFramework= /SmmRuntimeDxeReportStatusCodeLibFramework.inf diff --git a/IntelFrameworkModulePkg/Include/Guid/TianoDecompress.h b/MdeMod= ulePkg/Include/Guid/TianoDecompress.h similarity index 100% rename from IntelFrameworkModulePkg/Include/Guid/TianoDecompress.h rename to MdeModulePkg/Include/Guid/TianoDecompress.h diff --git a/IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLi= b/BaseUefiTianoCustomDecompressLib.c b/MdeModulePkg/Library/BaseUefiTianoCus= tomDecompressLib/BaseUefiTianoCustomDecompressLib.c similarity index 100% rename from IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib= /BaseUefiTianoCustomDecompressLib.c rename to MdeModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTian= oCustomDecompressLib.c diff --git a/IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLi= b/BaseUefiTianoCustomDecompressLib.inf b/MdeModulePkg/Library/BaseUefiTianoC= ustomDecompressLib/BaseUefiTianoCustomDecompressLib.inf similarity index 94% rename from IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib= /BaseUefiTianoCustomDecompressLib.inf rename to MdeModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTian= oCustomDecompressLib.inf index ee64fa0d0e..41cc48cd24 100644 --- a/IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseU= efiTianoCustomDecompressLib.inf +++ b/MdeModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCus= tomDecompressLib.inf @@ -33,11 +33,11 @@ BaseUefiTianoCustomDecompressLibInternals.h BaseUefiTianoCustomDecompressLib.c [Packages] MdePkg/MdePkg.dec - IntelFrameworkModulePkg/IntelFrameworkModulePkg.dec + MdeModulePkg/MdeModulePkg.dec [LibraryClasses] BaseLib DebugLib BaseMemoryLib diff --git a/IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLi= b/BaseUefiTianoCustomDecompressLibInternals.h b/MdeModulePkg/Library/BaseUef= iTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLibInternals.h similarity index 100% rename from IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib= /BaseUefiTianoCustomDecompressLibInternals.h rename to MdeModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTian= oCustomDecompressLibInternals.h diff --git a/IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLi= b/BaseUefiTianoDecompressLib.uni b/MdeModulePkg/Library/BaseUefiTianoCustomD= ecompressLib/BaseUefiTianoDecompressLib.uni similarity index 100% rename from IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib= /BaseUefiTianoDecompressLib.uni rename to MdeModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTian= oDecompressLib.uni diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeModulePkg.dec index 9bbd0572f5..546ec38b9d 100644 --- a/MdeModulePkg/MdeModulePkg.dec +++ b/MdeModulePkg/MdeModulePkg.dec @@ -377,10 +377,14 @@ ## GUID indicates the LZMA custom compress/decompress algorithm. # Include/Guid/LzmaDecompress.h gLzmaCustomDecompressGuid =3D { 0xEE4E5898, 0x3914, 0x4259, { 0x9D,= 0x6E, 0xDC, 0x7B, 0xD7, 0x94, 0x03, 0xCF }} gLzmaF86CustomDecompressGuid =3D { 0xD42AE6BD, 0x1352, 0x4bfb, { 0x90= , 0x9A, 0xCA, 0x72, 0xA6, 0xEA, 0xE8, 0x89 }} + ## GUID indicates the tiano custom compress/decompress algorithm. + # Include/Guid/TianoDecompress.h + gTianoCustomDecompressGuid =3D { 0xA31280AD, 0x481E, 0x41B6, { 0x95,= 0xE8, 0x12, 0x7F, 0x4C, 0x98, 0x47, 0x79 }} + ## Include/Guid/TtyTerm.h gEfiTtyTermGuid =3D { 0x7d916d80, 0x5bb1, 0x458c, {0xa4, 0= x8f, 0xe2, 0x5f, 0xdd, 0x51, 0xef, 0x94 }} ## Include/Guid/HiiBootMaintenanceFormset.h gEfiIfrBootMaintenanceGuid =3D { 0xb2dedc91, 0xd59f, 0x48d2, { 0x89,= 0x8a, 0x12, 0x49, 0xc, 0x74, 0xa4, 0xe0 }} diff --git a/MdeModulePkg/MdeModulePkg.dsc b/MdeModulePkg/MdeModulePkg.dsc index da2078b8d2..8905ca5814 100644 --- a/MdeModulePkg/MdeModulePkg.dsc +++ b/MdeModulePkg/MdeModulePkg.dsc @@ -317,10 +317,11 @@ MdeModulePkg/Library/FrameBufferBltLib/FrameBufferBltLib.inf MdeModulePkg/Library/NonDiscoverableDeviceRegistrationLib/NonDiscoverable= DeviceRegistrationLib.inf MdeModulePkg/Library/BaseBmpSupportLib/BaseBmpSupportLib.inf MdeModulePkg/Library/DisplayUpdateProgressLibGraphics/DisplayUpdateProgre= ssLibGraphics.inf MdeModulePkg/Library/DisplayUpdateProgressLibText/DisplayUpdateProgressLi= bText.inf + MdeModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustom= DecompressLib.inf MdeModulePkg/Universal/BdsDxe/BdsDxe.inf MdeModulePkg/Application/BootManagerMenuApp/BootManagerMenuApp.inf MdeModulePkg/Application/UiApp/UiApp.inf{ -- 2.18.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#55): https://edk2.groups.io/g/devel/message/55 Mute This Topic: https://groups.io/mt/30896393/1498468 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [felixp@ami.com] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Please consider the environment before printing this email. The information contained in this message may be confidential and proprietar= y to American Megatrends, Inc. This communication is intended to be read on= ly by the individual or entity to whom it is addressed or by their designee.= If the reader of this message is not the intended recipient, you are on not= ice that any distribution of this message, in any form, is strictly prohibit= ed. Please promptly notify the sender by reply e-mail or by telephone at 77= 0-246-8600, and then delete or destroy all copies of the transmission.