public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Felix Polyudov" <felixp@ami.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"'erik.schmauss@intel.com'" <erik.schmauss@intel.com>,
	"lersek@redhat.com" <lersek@redhat.com>,
	"Gao, Liming" <liming.gao@intel.com>
Cc: "Moore, Robert" <robert.moore@intel.com>
Subject: Re: [edk2-devel] ASL build tools - EDKII trim tool questions
Date: Fri, 12 Apr 2019 18:03:46 +0000	[thread overview]
Message-ID: <9333E191E0D52B4999CE63A99BA663A00302C76F92@atlms1.us.megatrends.com> (raw)
In-Reply-To: <CF6A88132359CE47947DB4C6E1709ED53C5A164E@ORSMSX122.amr.corp.intel.com>

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Schmauss, Erik
> Sent: Thursday, April 11, 2019 7:10 PM
> Subject: Re: [edk2-devel] ASL build tools - EDKII trim tool questions


> Yes, the current iASL preprocessor implementation is incomplete
> but we might be able to either develop our own or import an existing
> preprocessor if it has the correct license.

Eric,

It depends on the end goal.
If the goal is to display correct line numbers in the error messages, just adding support for #line directive is enough.
If the goal is to compile ASL file with a single iasl run without usage of other tools such as Trim, I don't think even having a full-fledged preprocessed would suffice.
In edk2, header files included into ASL files may contain C constructs, such as typedef's, alien to ASL compiler.
The Trim tool cleans them up prior to running IASL.
So even if iasl will be able to perform full preprocessing , Trim would still be required unless edk2 conventions are changed to require ASL-friendly include headers.

Please consider the environment before printing this email.

The information contained in this message may be confidential and proprietary to American Megatrends, Inc.  This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited.  Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.

  reply	other threads:[~2019-04-12 18:03 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-09  1:05 [edk2-devel] ASL build tools - EDKII trim tool questions Liming Gao
2019-04-09  9:10 ` Laszlo Ersek
2019-04-11 23:10   ` Schmauss, Erik
2019-04-12 18:03     ` Felix Polyudov [this message]
2019-04-12 18:49       ` Schmauss, Erik
  -- strict thread matches above, loose matches on Subject: below --
2019-04-04 19:08 erik.schmauss
2019-04-04 22:10 ` [edk2-devel] " Felix Polyudov
2019-04-04 23:44   ` erik.schmauss
2019-04-08 16:23     ` Liming Gao
2019-04-08 16:45       ` Schmauss, Erik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9333E191E0D52B4999CE63A99BA663A00302C76F92@atlms1.us.megatrends.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox