Re: [edk2-devel] [PATCH] BaseTools: Include headers not mentioned in inf are not hashed

["Felix Polyudov" <felixp@ami.com>]

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Laszlo Ersek
> Sent: Thursday, May 09, 2019 7:53 PM
> 
> Hello Christian,
> 
> On 05/09/19 23:27, Christian Rodriguez wrote:
> > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1787
> >
> > Get a list of local header files that are not present in the
> > MetaFile for this module. Add those local header files into
> > the hashing algorithm for a module. If a local header file is
> > not present in the MetaFile, the module will still build correctly
> > though the hashing system didn't know about it before.
> >
> > Signed-off-by: Christian Rodriguez <christian.rodriguez@intel.com>
> > Cc: Bob Feng <bob.c.feng@intel.com>
> > Cc: Liming Gao <liming.gao@intel.com>
> > Cc: Yonghong Zhu <yonghong.zhu@intel.com>
> > ---
> >  BaseTools/Source/Python/AutoGen/AutoGen.py | 24 ++++++++++++++++++++++++
> >  1 file changed, 24 insertions(+)
> 
> I saw the BZ soon after it was reported. I almost commented, but
> ultimately I couldn't decide what the real use case was.
> 
> With this particular use case (i.e. INF file is missing some
> module-specific header files that it could easily list), I think I
> disagree, mildly (not too strongly). E.g., we fixed such omissions in a
> bunch of INF files, last March, in the series

I agree with Lazlo.
According to section 3.9 of the INF specification (https://edk2-docs.gitbooks.io/edk-ii-inf-specification/3_edk_ii_inf_file_format/39_[sources]_sections.html),
all source files (including module header files) must be listed in the [Sources] section.
Here is the quote:
"All HII Unicode format files must be listed in this section as well as any other "source" type file, such as local module header files, Vfr files, etc. "

So, if file X is used by module Y, but is not listed in Y.inf, it's a violation of the INF spec., which makes it a bug that has to be fixed.


Please consider the environment before printing this email.

The information contained in this message may be confidential and proprietary to American Megatrends, Inc.  This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited.  Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.