From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: ami.com, ip: 63.147.10.42, mailfrom: felixp@ami.com) Received: from atlmailgw2.ami.com (atlmailgw2.ami.com [63.147.10.42]) by groups.io with SMTP; Wed, 05 Jun 2019 14:42:22 -0700 X-AuditID: ac10606f-bbfff70000003de9-0d-5cf8373c6c30 Received: from atlms2.us.megatrends.com (atlms2.us.megatrends.com [172.16.96.152]) (using TLS with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (Client did not present a certificate) by atlmailgw2.ami.com (Symantec Messaging Gateway) with SMTP id 78.A8.15849.C3738FC5; Wed, 5 Jun 2019 17:42:21 -0400 (EDT) Received: from ATLMS1.us.megatrends.com ([fe80::8c55:daf0:ef05:5605]) by atlms2.us.megatrends.com ([fe80::29dc:a91e:ea0c:cdeb%12]) with mapi id 14.03.0415.000; Wed, 5 Jun 2019 17:42:20 -0400 From: "Felix Polyudov" To: "devel@edk2.groups.io" , "'wei6.xu@intel.com'" CC: Michael D Kinney , Liming Gao , Chao B Zhang Subject: Re: [edk2-devel][Patch v2 1/7] MdePkg: Add Pei Boot In CapsuleOnDisk Mode Ppi definition. Thread-Topic: [edk2-devel][Patch v2 1/7] MdePkg: Add Pei Boot In CapsuleOnDisk Mode Ppi definition. Thread-Index: AQHVG7VGvblwRlzwvkaF9ol/f8+31aaNkRDw Date: Wed, 5 Jun 2019 21:42:19 +0000 Message-ID: <9333E191E0D52B4999CE63A99BA663A00302C92323@atlms1.us.megatrends.com> References: <20190605154203.11012-1-wei6.xu@intel.com> <20190605154203.11012-2-wei6.xu@intel.com> In-Reply-To: <20190605154203.11012-2-wei6.xu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.16.99.93] MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprOKsWRmVeSWpSXmKPExsWyRiBhhq6t+Y8Yg42dvBbz31ZbtE+YzWax 4t4GdouOjn9MFrv2PGR2YPXY/v0Co8fiPS+ZApiiGhhtEvPy8ksSS1IVUlKLk22VAooyyxKT K5UUMlNslQyVFApyEpNTc1PzSmyVEgsKUvNSlOy4FDCADVBZZp5Cal5yfkpmXrqtkmewv66F hamlrqGSXUhGqkJmXlp+UW5iSWZ+nkJyfl4JUHVqClBUIaGLM+PsZu6CQ9IVVx6+Ym1gfCvW xcjJISFgInFs+zemLkYuDiGBXUwSp+f2skA4hxglrnV9YgepYhNQlTi+upkFxBYRiJM4tHcH I4jNLFArcXD+H7C4sECKxLtj99kgalIl3m3/BVVvJPHyzWKgDRwcLAIqEjM/1YGEeQUCJRZN WQ9WLiSQLLHh4DmwVZwC5hI9V5+CjWcUEJP4fmoNE8QqcYlbT+YzQRwtILFkz3lmCFtU4uXj f6wQtoLElved7BD1OhILdn9ig7C1JZYtfM0MsVdQ4uTMJywTGEVnIRk7C0nLLCQts5C0LGBk WcUolFiSk5uYmZNebqSXmJupl5yfu4kRkirydzB+/Gh+iJGJgxEYdhzMSiK8ibe/xAjxpiRW VqUW5ccXleakFh9idAKGw0RmKW5Q/AAjPN7YwEBKFMYxNDEzMTcyN7Q0MTc2VhLnXbXmW4yQ QDow4WSnphakFsEMYeLglGpgnNSyjYP7/rH17L83tMVJvZ6/bvHv6xlK7Bz5DaL7b704aGT1 kW0X993blR2KZx8saxFdouUctDTgNcePRdpccwy/BHgnybIbbNkmb3LjVCdHYkLalrmruScw LHbSXfpVy7GNt8jdzev9s1uqIXYfn/B5W1y5dnf18d/nwpmSTxedU1+W/eiPghJLcUaioRZz UXEiAF8c6P4qAwAA Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable 1. It is my understanding that edk2 convention is to keep each PPI in a sep= arate header file. If this is the case, new PPI definition should not be ad= ded to BootInRecoveryMode.h. 2. gEfiPeiBootInCapsuleOnDiskModePpiGuid is a bad name. New PPI is not def= ined by UEFI/PI specifications and as such cannot have EFI prefix. Arguably= , it shouldn't even be in the MdePkg. -----Original Message----- From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Xu, = Wei6 Sent: Wednesday, June 05, 2019 11:42 AM To: devel@edk2.groups.io Cc: Michael D Kinney; Liming Gao; Chao B Zhang; Wei6 Xu Subject: [edk2-devel][Patch v2 1/7] MdePkg: Add Pei Boot In CapsuleOnDisk = Mode Ppi definition. BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1852 This PPI indicates current boot mode is capsule on disk mode. Cc: Michael D Kinney Cc: Liming Gao Cc: Chao B Zhang Signed-off-by: Wei6 Xu --- MdePkg/Include/Ppi/BootInRecoveryMode.h | 9 ++++++++- MdePkg/MdePkg.dec | 3 +++ 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/MdePkg/Include/Ppi/BootInRecoveryMode.h b/MdePkg/Include/Ppi/= BootInRecoveryMode.h index ae40744d9b..71b0ca8586 100644 --- a/MdePkg/Include/Ppi/BootInRecoveryMode.h +++ b/MdePkg/Include/Ppi/BootInRecoveryMode.h @@ -1,10 +1,10 @@ /** @file This PPI is installed by the platform PEIM to designate that a recovery= boot is in progress. - Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.
+ Copyright (c) 2006 - 2019, Intel Corporation. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent @par Revision Reference: This PPI is introduced in PI Version 1.0. @@ -19,6 +19,13 @@ } extern EFI_GUID gEfiPeiBootInRecoveryModePpiGuid; +#define EFI_PEI_BOOT_IN_CAPSULE_ON_DISK_MODE_PPI \ + { \ + 0xb08a11e4, 0xe2b7, 0x4b75, { 0xb5, 0x15, 0xaf, 0x61, 0x6, 0x68, 0xbf= , 0xd1 } \ + } + +extern EFI_GUID gEfiPeiBootInCapsuleOnDiskModePpiGuid; + #endif diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec index 6c563375ee..ec02b8c7c7 100644 --- a/MdePkg/MdePkg.dec +++ b/MdePkg/MdePkg.dec @@ -790,10 +790,13 @@ gEfiPeiMemoryDiscoveredPpiGuid =3D {0xf894643d, 0xc449, 0x42d1, {0x8e, = 0xa8, 0x85, 0xbd, 0xd8, 0xc6, 0x5b, 0xde } } ## Include/Ppi/BootInRecoveryMode.h gEfiPeiBootInRecoveryModePpiGuid =3D { 0x17ee496a, 0xd8e4, 0x4b9a, {0x9= 4, 0xd1, 0xce, 0x82, 0x72, 0x30, 0x8, 0x50 } } + ## Include/Ppi/BootInRecoveryMode.h + gEfiPeiBootInCapsuleOnDiskModePpiGuid =3D { 0xb08a11e4, 0xe2b7, 0x4b75,= { 0xb5, 0x15, 0xaf, 0x61, 0x6, 0x68, 0xbf, 0xd1 } } + ## Include/Ppi/EndOfPeiPhase.h gEfiEndOfPeiSignalPpiGuid =3D {0x605EA650, 0xC65C, 0x42e1, {0xBA, 0x80,= 0x91, 0xA5, 0x2A, 0xB6, 0x18, 0xC6 } } ## Include/Ppi/Reset.h gEfiPeiResetPpiGuid =3D { 0xef398d58, 0x9dfd, 0x4103, {0xbf, 0x94, 0x78= , 0xc6, 0xf4, 0xfe, 0x71, 0x2f } } -- 2.16.2.windows.1 Please consider the environment before printing this email. The information contained in this message may be confidential and propriet= ary to American Megatrends, Inc. This communication is intended to be read= only by the individual or entity to whom it is addressed or by their desig= nee. If the reader of this message is not the intended recipient, you are o= n notice that any distribution of this message, in any form, is strictly pr= ohibited. Please promptly notify the sender by reply e-mail or by telephon= e at 770-246-8600, and then delete or destroy all copies of the transmissio= n.