From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.120]) by mx.groups.io with SMTP id smtpd.web11.1623.1588191278721434182 for ; Wed, 29 Apr 2020 13:14:38 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=HMblLi88; spf=pass (domain: redhat.com, ip: 205.139.110.120, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1588191277; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=26whsHwHnE+d5cQrpLNkCE7biDXCLD7DlMsG2uMA8iA=; b=HMblLi88tu27mBs2iJvYgY8W7UuVDfAYcy7v1SC2AKE6gA1mWW69Z7ENYuBuuSwBXTlVwr s9kPwzDY9P7bWMO0O3AHS9Pm7rs39mdQQwiz91K27zOHgYqkS9yQdp/vAVlyjot9bu/tH1 xLUHix5XHUlm25asUoKDiWswFkxREc4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-290-mAuYPHqwMyiylzXgIfcHeg-1; Wed, 29 Apr 2020 16:14:35 -0400 X-MC-Unique: mAuYPHqwMyiylzXgIfcHeg-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 54BEE8014D6; Wed, 29 Apr 2020 20:14:34 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-114-1.ams2.redhat.com [10.36.114.1]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2E49C396; Wed, 29 Apr 2020 20:14:33 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH 3/3] Maintainers.txt: mark EmbeddedPkg hw drivers as bsolete To: devel@edk2.groups.io, leif@nuviainc.com Cc: Andrew Fish , Ard Biesheuvel , Michael D Kinney References: <20200429163616.5951-1-leif@nuviainc.com> <20200429163616.5951-4-leif@nuviainc.com> From: "Laszlo Ersek" Message-ID: <93351a22-53e4-d73a-bd6c-a10feba09461@redhat.com> Date: Wed, 29 Apr 2020 22:14:32 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200429163616.5951-4-leif@nuviainc.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit On 04/29/20 18:36, Leif Lindholm wrote: > A bunch of legacy drivers (most not compliant with UEFI driver model) > added for various ARM development platforms are still in EmbeddedPkg, > which was arguably the only possible location for them before > edk2-platforms was added. > > DwEmmcDxe, Isp1761UsbDxe, Lan9118Dxe, and Lan91xDxe all use a > Pcd*BaseAddress mechanism making them *fundamentally* incompatible > with the UEFI driver model, and preventing use of more than one device > instance per system. > > SataSiI3132Dxe *looks* like a proper UEFI driver, but would need > re-review with that in mind for moving to edk2-platforms. > > Mark these as Status: Obsolete in Maintainers.txt to at the very least > indicate that they are not suitable references. > > Cc: Andrew Fish > Cc: Ard Biesheuvel > Cc: Laszlo Ersek > Cc: Michael D Kinney > Signed-off-by: Leif Lindholm > --- > Maintainers.txt | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/Maintainers.txt b/Maintainers.txt > index 4d62e0b334f3..3415a0410b7b 100644 > --- a/Maintainers.txt > +++ b/Maintainers.txt > @@ -172,6 +172,11 @@ M: Alexei Fedorov > > EmbeddedPkg > F: EmbeddedPkg/ > +X: EmbeddedPkg/Drivers/DwEmmcDxe/ > +X: EmbeddedPkg/Drivers/Isp1761UsbDxe/ > +X: EmbeddedPkg/Drivers/Lan9118Dxe/ > +X: EmbeddedPkg/Drivers/Lan91xDxe/ > +X: EmbeddedPkg/Drivers/SataSiI3132Dxe/ > X: EmbeddedPkg/Include/Protocol/MmcHost.h > X: EmbeddedPkg/Universal/MmcDxe/ > W: https://github.com/tianocore/tianocore.github.io/wiki/EmbeddedPkg > @@ -179,6 +184,11 @@ M: Leif Lindholm > M: Ard Biesheuvel > > EmbeddedPkg obsolete code > +F: EmbeddedPkg/Drivers/DwEmmcDxe/ > +F: EmbeddedPkg/Drivers/Isp1761UsbDxe/ > +F: EmbeddedPkg/Drivers/Lan9118Dxe/ > +F: EmbeddedPkg/Drivers/Lan91xDxe/ > +F: EmbeddedPkg/Drivers/SataSiI3132Dxe/ > F: EmbeddedPkg/Include/Protocol/MmcHost.h > F: EmbeddedPkg/Universal/MmcDxe/ > S: Obsolete > same generic observations as under patch#2 Reviewed-by: Laszlo Ersek