public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Laszlo Ersek <lersek@redhat.com>
To: "Zeng, Star" <star.zeng@intel.com>,
	"Zhang, Shenglei" <shenglei.zhang@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Dong, Eric" <eric.dong@intel.com>
Subject: Re: [PATCH] MdeModulePkg: Remove redundant things in inf and .h files
Date: Fri, 10 Aug 2018 18:59:38 +0200	[thread overview]
Message-ID: <93379bb3-87c1-2131-10a0-7ff03a283c3f@redhat.com> (raw)
In-Reply-To: <0C09AFA07DD0434D9E2A0C6AEB0483103BBABDD7@shsmsx102.ccr.corp.intel.com>

On 08/10/18 10:47, Zeng, Star wrote:
> I suggest merging this patch with https://lists.01.org/pipermail/edk2-devel/2018-August/027953.html to one patch.
> And remember to update the new patch's version.

There's another thing to remember please, when posting the new version
of the series:

  for every patch X:
    if patch X has received Reviewed-by tags in the v1 review, and
       patch X is not changed between v1 and v2
    then
      the v2 posting of patch X should carry the Reviewed-by tags from
        the v1 review.

I would very much *not* like to re-review those patches that I have
reviewed already, and are not changed in the v2 iteration.

In practice this means editing the commit message of every *unchanged*
patch, and appending the Reviewed-by tags from the mailing list for that
patch, at the bottom of the commit message. Use git-rebase + "reword".

(Sorry if I shouldn't have spelled this out; I'm unsure how much
experience Shenglei has with git.)

Thanks
Laszlo


      reply	other threads:[~2018-08-10 16:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-09  8:40 [PATCH] MdeModulePkg: Remove redundant things in inf and .h files shenglei
2018-08-10  8:47 ` Zeng, Star
2018-08-10 16:59   ` Laszlo Ersek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=93379bb3-87c1-2131-10a0-7ff03a283c3f@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox