From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=66.187.233.73; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 679AB210EB4DC for ; Fri, 10 Aug 2018 09:59:41 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7DBC6401EF2B; Fri, 10 Aug 2018 16:59:40 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-207.rdu2.redhat.com [10.10.120.207]) by smtp.corp.redhat.com (Postfix) with ESMTP id 820C310EE77F; Fri, 10 Aug 2018 16:59:39 +0000 (UTC) To: "Zeng, Star" , "Zhang, Shenglei" , "edk2-devel@lists.01.org" Cc: "Dong, Eric" References: <20180809084008.26376-1-shenglei.zhang@intel.com> <0C09AFA07DD0434D9E2A0C6AEB0483103BBABDD7@shsmsx102.ccr.corp.intel.com> From: Laszlo Ersek Message-ID: <93379bb3-87c1-2131-10a0-7ff03a283c3f@redhat.com> Date: Fri, 10 Aug 2018 18:59:38 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <0C09AFA07DD0434D9E2A0C6AEB0483103BBABDD7@shsmsx102.ccr.corp.intel.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Fri, 10 Aug 2018 16:59:40 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Fri, 10 Aug 2018 16:59:40 +0000 (UTC) for IP:'10.11.54.3' DOMAIN:'int-mx03.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'lersek@redhat.com' RCPT:'' Subject: Re: [PATCH] MdeModulePkg: Remove redundant things in inf and .h files X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Aug 2018 16:59:41 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 08/10/18 10:47, Zeng, Star wrote: > I suggest merging this patch with https://lists.01.org/pipermail/edk2-devel/2018-August/027953.html to one patch. > And remember to update the new patch's version. There's another thing to remember please, when posting the new version of the series: for every patch X: if patch X has received Reviewed-by tags in the v1 review, and patch X is not changed between v1 and v2 then the v2 posting of patch X should carry the Reviewed-by tags from the v1 review. I would very much *not* like to re-review those patches that I have reviewed already, and are not changed in the v2 iteration. In practice this means editing the commit message of every *unchanged* patch, and appending the Reviewed-by tags from the mailing list for that patch, at the bottom of the commit message. Use git-rebase + "reword". (Sorry if I shouldn't have spelled this out; I'm unsure how much experience Shenglei has with git.) Thanks Laszlo