From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=217.140.101.70; helo=foss.arm.com; envelope-from=supreeth.venkatesh@arm.com; receiver=edk2-devel@lists.01.org Received: from foss.arm.com (foss.arm.com [217.140.101.70]) by ml01.01.org (Postfix) with ESMTP id 6A98B2194D3B3 for ; Fri, 4 Jan 2019 09:49:51 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 201E8EBD; Fri, 4 Jan 2019 09:49:51 -0800 (PST) Received: from supven01-VirtualBox (unknown [10.119.49.21]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 601AF3F5D4; Fri, 4 Jan 2019 09:49:50 -0800 (PST) Message-ID: <933c491d918f3b9e798701cf277123ee34ad96ff.camel@arm.com> From: Supreeth Venkatesh To: Ard Biesheuvel , edk2-devel@lists.01.org Cc: Achin Gupta , Jiewen Yao , Leif Lindholm , Jagadeesh Ujja , Thomas Panakamattam Abraham , Sami Mujawar Date: Fri, 04 Jan 2019 11:49:44 -0600 In-Reply-To: <20190104110315.18339-3-ard.biesheuvel@linaro.org> References: <20190104110315.18339-1-ard.biesheuvel@linaro.org> <20190104110315.18339-3-ard.biesheuvel@linaro.org> X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.1 Mime-Version: 1.0 Subject: Re: [PATCH 2/8] StandaloneMmPkg/StandaloneMmCoreEntryPoint: add missing SerialPortLib ref X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Jan 2019 17:49:51 -0000 X-List-Received-Date: Fri, 04 Jan 2019 17:49:51 -0000 X-List-Received-Date: Fri, 04 Jan 2019 17:49:51 -0000 X-List-Received-Date: Fri, 04 Jan 2019 17:49:51 -0000 X-List-Received-Date: Fri, 04 Jan 2019 17:49:51 -0000 X-List-Received-Date: Fri, 04 Jan 2019 17:49:51 -0000 X-List-Received-Date: Fri, 04 Jan 2019 17:49:51 -0000 X-List-Received-Date: Fri, 04 Jan 2019 17:49:51 -0000 X-List-Received-Date: Fri, 04 Jan 2019 17:49:51 -0000 X-List-Received-Date: Fri, 04 Jan 2019 17:49:51 -0000 X-List-Received-Date: Fri, 04 Jan 2019 17:49:51 -0000 X-List-Received-Date: Fri, 04 Jan 2019 17:49:51 -0000 X-List-Received-Date: Fri, 04 Jan 2019 17:49:51 -0000 X-List-Received-Date: Fri, 04 Jan 2019 17:49:51 -0000 X-List-Received-Date: Fri, 04 Jan 2019 17:49:51 -0000 X-List-Received-Date: Fri, 04 Jan 2019 17:49:51 -0000 X-List-Received-Date: Fri, 04 Jan 2019 17:49:51 -0000 X-List-Received-Date: Fri, 04 Jan 2019 17:49:51 -0000 X-List-Received-Date: Fri, 04 Jan 2019 17:49:51 -0000 X-List-Received-Date: Fri, 04 Jan 2019 17:49:51 -0000 X-List-Received-Date: Fri, 04 Jan 2019 17:49:51 -0000 X-List-Received-Date: Fri, 04 Jan 2019 17:49:51 -0000 X-List-Received-Date: Fri, 04 Jan 2019 17:49:51 -0000 X-List-Received-Date: Fri, 04 Jan 2019 17:49:51 -0000 X-List-Received-Date: Fri, 04 Jan 2019 17:49:51 -0000 X-List-Received-Date: Fri, 04 Jan 2019 17:49:51 -0000 X-List-Received-Date: Fri, 04 Jan 2019 17:49:51 -0000 X-List-Received-Date: Fri, 04 Jan 2019 17:49:51 -0000 X-List-Received-Date: Fri, 04 Jan 2019 17:49:51 -0000 X-List-Received-Date: Fri, 04 Jan 2019 17:49:51 -0000 X-List-Received-Date: Fri, 04 Jan 2019 17:49:51 -0000 X-List-Received-Date: Fri, 04 Jan 2019 17:49:51 -0000 X-List-Received-Date: Fri, 04 Jan 2019 17:49:51 -0000 X-List-Received-Date: Fri, 04 Jan 2019 17:49:51 -0000 X-List-Received-Date: Fri, 04 Jan 2019 17:49:51 -0000 X-List-Received-Date: Fri, 04 Jan 2019 17:49:51 -0000 X-List-Received-Date: Fri, 04 Jan 2019 17:49:51 -0000 X-List-Received-Date: Fri, 04 Jan 2019 17:49:51 -0000 X-List-Received-Date: Fri, 04 Jan 2019 17:49:51 -0000 X-List-Received-Date: Fri, 04 Jan 2019 17:49:51 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit On Fri, 2019-01-04 at 12:03 +0100, Ard Biesheuvel wrote: > StandaloneMmCoreEntryPoint calls SerialPortInitialize() explicitly, > so add SerialPortLib to its list of LibraryClasses. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel Reviewed-by: Supreeth Venkatesh > --- > StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/StandaloneMmCoreE > ntryPoint.inf | 1 + > 1 file changed, 1 insertion(+) > > diff --git > a/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/StandaloneMmCore > EntryPoint.inf > b/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/StandaloneMmCore > EntryPoint.inf > index 3222cd359f3e..769eaeeefbea 100644 > --- > a/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/StandaloneMmCore > EntryPoint.inf > +++ > b/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/StandaloneMmCore > EntryPoint.inf > @@ -43,6 +43,7 @@ [Packages.AARCH64] > [LibraryClasses] > BaseLib > DebugLib > + SerialPortLib > > [LibraryClasses.AARCH64] > StandaloneMmMmuLib