From: "Sami Mujawar" <sami.mujawar@arm.com>
To: Vivek Gautam <vivek.gautam@arm.com>, devel@edk2.groups.io
Cc: ardb+tianocore@kernel.org, leif@nuviainc.com,
Pierre.Gondois@arm.com, "nd@arm.com" <nd@arm.com>
Subject: Re: [edk2-platforms][PATCH V3 2/5] Platform/Sgi: Enable virtio-p9 device on RD-N2 platform variants
Date: Wed, 26 Apr 2023 17:03:03 +0100 [thread overview]
Message-ID: <933e5741-3dc9-d0ee-20a4-45819e9f5bde@arm.com> (raw)
In-Reply-To: <20230324110303.1168851-3-vivek.gautam@arm.com>
Hi Vivek,
Thank you for this patch.
These changes look good to me.
Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
Regards,
Sami Mujawar
On 24/03/2023 11:03 am, Vivek Gautam wrote:
> Enable the virtio-p9 device that is present as part of the RoS
> peripherals on RD-N2 platform variants. This will allow filesystem
> sharing between the Host PC and target platform.
>
> Signed-off-by: Vivek Gautam <vivek.gautam@arm.com>
> Reviewed-by: Pierre Gondois <pierre.gondois@arm.com>
> ---
> Platform/ARM/SgiPkg/AcpiTables/RdN2AcpiTables.inf | 8 ++++++--
> Platform/ARM/SgiPkg/AcpiTables/RdN2Cfg1AcpiTables.inf | 8 ++++++--
> Platform/ARM/SgiPkg/AcpiTables/RdN2Cfg2AcpiTables.inf | 6 +++++-
> 3 files changed, 17 insertions(+), 5 deletions(-)
>
> diff --git a/Platform/ARM/SgiPkg/AcpiTables/RdN2AcpiTables.inf b/Platform/ARM/SgiPkg/AcpiTables/RdN2AcpiTables.inf
> index 66d5422df36b..833f87c3e4be 100644
> --- a/Platform/ARM/SgiPkg/AcpiTables/RdN2AcpiTables.inf
> +++ b/Platform/ARM/SgiPkg/AcpiTables/RdN2AcpiTables.inf
> @@ -1,7 +1,7 @@
> ## @file
> # ACPI table data and ASL sources required to boot the platform.
> #
> -# Copyright (c) 2020-2021, Arm Ltd. All rights reserved.
> +# Copyright (c) 2020 - 2023, Arm Ltd. All rights reserved.
> #
> # SPDX-License-Identifier: BSD-2-Clause-Patent
> #
> @@ -25,8 +25,9 @@
> RdN2/Pptt.aslc
> Spcr.aslc
> Ssdt.asl
> - SsdtRos.asl
> SsdtEvents.asl
> + SsdtRos.asl
> + SsdtRosVirtioP9.asl
>
> [Packages]
> ArmPkg/ArmPkg.dec
> @@ -70,6 +71,9 @@
> gArmSgiTokenSpaceGuid.PcdVirtioNetBaseAddress
> gArmSgiTokenSpaceGuid.PcdVirtioNetSize
> gArmSgiTokenSpaceGuid.PcdVirtioNetInterrupt
> + gArmSgiTokenSpaceGuid.PcdVirtioP9BaseAddress
> + gArmSgiTokenSpaceGuid.PcdVirtioP9Size
> + gArmSgiTokenSpaceGuid.PcdVirtioP9Interrupt
> gArmSgiTokenSpaceGuid.PcdWdogWS0Gsiv
> gArmSgiTokenSpaceGuid.PcdWdogWS1Gsiv
>
> diff --git a/Platform/ARM/SgiPkg/AcpiTables/RdN2Cfg1AcpiTables.inf b/Platform/ARM/SgiPkg/AcpiTables/RdN2Cfg1AcpiTables.inf
> index 742734ab7348..e3e4e55bc410 100644
> --- a/Platform/ARM/SgiPkg/AcpiTables/RdN2Cfg1AcpiTables.inf
> +++ b/Platform/ARM/SgiPkg/AcpiTables/RdN2Cfg1AcpiTables.inf
> @@ -1,7 +1,7 @@
> ## @file
> # ACPI table data and ASL sources required to boot the platform.
> #
> -# Copyright (c) 2021, Arm Ltd. All rights reserved.
> +# Copyright (c) 2021 - 2023, Arm Ltd. All rights reserved.
> #
> # SPDX-License-Identifier: BSD-2-Clause-Patent
> #
> @@ -25,8 +25,9 @@
> RdN2Cfg1/Pptt.aslc
> Spcr.aslc
> Ssdt.asl
> - SsdtRos.asl
> SsdtEvents.asl
> + SsdtRos.asl
> + SsdtRosVirtioP9.asl
>
> [Packages]
> ArmPkg/ArmPkg.dec
> @@ -71,6 +72,9 @@
> gArmSgiTokenSpaceGuid.PcdVirtioNetBaseAddress
> gArmSgiTokenSpaceGuid.PcdVirtioNetSize
> gArmSgiTokenSpaceGuid.PcdVirtioNetInterrupt
> + gArmSgiTokenSpaceGuid.PcdVirtioP9BaseAddress
> + gArmSgiTokenSpaceGuid.PcdVirtioP9Size
> + gArmSgiTokenSpaceGuid.PcdVirtioP9Interrupt
> gArmSgiTokenSpaceGuid.PcdWdogWS0Gsiv
> gArmSgiTokenSpaceGuid.PcdWdogWS1Gsiv
>
> diff --git a/Platform/ARM/SgiPkg/AcpiTables/RdN2Cfg2AcpiTables.inf b/Platform/ARM/SgiPkg/AcpiTables/RdN2Cfg2AcpiTables.inf
> index 2354f2dc65eb..6ce78582da35 100644
> --- a/Platform/ARM/SgiPkg/AcpiTables/RdN2Cfg2AcpiTables.inf
> +++ b/Platform/ARM/SgiPkg/AcpiTables/RdN2Cfg2AcpiTables.inf
> @@ -1,7 +1,7 @@
> ## @file
> # ACPI table data and ASL sources required to boot the platform.
> #
> -# Copyright (c) 2022, Arm Limited. All rights reserved.
> +# Copyright (c) 2022 - 2023, Arm Limited. All rights reserved.
> #
> # SPDX-License-Identifier: BSD-2-Clause-Patent
> #
> @@ -24,6 +24,7 @@
> RdN2Cfg2/Srat.aslc
> Spcr.aslc
> SsdtRos.asl
> + SsdtRosVirtioP9.asl
>
> [Packages]
> ArmPkg/ArmPkg.dec
> @@ -65,6 +66,9 @@
> gArmSgiTokenSpaceGuid.PcdVirtioNetBaseAddress
> gArmSgiTokenSpaceGuid.PcdVirtioNetSize
> gArmSgiTokenSpaceGuid.PcdVirtioNetInterrupt
> + gArmSgiTokenSpaceGuid.PcdVirtioP9BaseAddress
> + gArmSgiTokenSpaceGuid.PcdVirtioP9Size
> + gArmSgiTokenSpaceGuid.PcdVirtioP9Interrupt
> gArmSgiTokenSpaceGuid.PcdWdogWS0Gsiv
> gArmSgiTokenSpaceGuid.PcdWdogWS1Gsiv
>
next prev parent reply other threads:[~2023-04-26 16:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-24 11:02 [edk2-platforms][PATCH V3 0/5] Enable SoC expansion block and Virtio-P9 for RD-N2 variants Vivek Kumar Gautam
2023-03-24 11:02 ` [edk2-platforms][PATCH V3 1/5] Platform/Sgi: Add SSDT table for Virtio-P9 Vivek Kumar Gautam
2023-04-26 16:02 ` Sami Mujawar
2023-03-24 11:03 ` [edk2-platforms][PATCH V3 2/5] Platform/Sgi: Enable virtio-p9 device on RD-N2 platform variants Vivek Kumar Gautam
2023-04-26 16:03 ` Sami Mujawar [this message]
2023-03-24 11:03 ` [edk2-platforms][PATCH V3 3/5] Platform/Sgi: Add SSDT table for IO virtualization SoC expansion block Vivek Kumar Gautam
2023-04-26 16:17 ` Sami Mujawar
2023-03-24 11:03 ` [edk2-platforms][PATCH V3 4/5] Platform/Sgi: Initialize additional UART controllers Vivek Kumar Gautam
2023-04-26 16:17 ` Sami Mujawar
2023-04-27 5:28 ` Vivek Kumar Gautam
2023-03-24 11:03 ` [edk2-platforms][PATCH V3 5/5] Platform/Sgi: Enable SoC expansion block for RD-N2 variants Vivek Kumar Gautam
2023-04-26 16:17 ` Sami Mujawar
2023-03-30 9:46 ` [edk2-platforms][PATCH V3 0/5] Enable SoC expansion block and Virtio-P9 " PierreGondois
2023-03-30 9:52 ` Vivek Kumar Gautam
2023-04-27 7:18 ` Sami Mujawar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=933e5741-3dc9-d0ee-20a4-45819e9f5bde@arm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox