From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (EUR05-VI1-obe.outbound.protection.outlook.com [40.107.21.60]) by mx.groups.io with SMTP id smtpd.web11.6005.1634724628689823407 for ; Wed, 20 Oct 2021 03:10:29 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=9LoYSIrr; spf=pass (domain: arm.com, ip: 40.107.21.60, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IDlDUhn//K+qkHTTFw8ixvh6TTUYo9WYzocv473/UE8=; b=9LoYSIrrk/eHOb9aDxom48eWQsNmP+8ZMd+8TL85IFq3sxW78US9F7UGKsuEx/Hlyiq+wTmTNmzRR+TeRX33X/UMo+kj7RryU8GSAKIFxuFEx3Ca4SFX1C7jJJSNGlh+GsPUN5/kvkuHJH68L4NFF33syLdaIcwyJ2+FSN+JEPI= Received: from DB6PR0402CA0003.eurprd04.prod.outlook.com (2603:10a6:4:91::13) by PR2PR08MB4698.eurprd08.prod.outlook.com (2603:10a6:101:19::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.18; Wed, 20 Oct 2021 10:10:24 +0000 Received: from DB5EUR03FT035.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:91:cafe::e5) by DB6PR0402CA0003.outlook.office365.com (2603:10a6:4:91::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.16 via Frontend Transport; Wed, 20 Oct 2021 10:10:24 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT035.mail.protection.outlook.com (10.152.20.65) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15 via Frontend Transport; Wed, 20 Oct 2021 10:10:24 +0000 Received: ("Tessian outbound d5def7722ff7:v103"); Wed, 20 Oct 2021 10:10:24 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: eb15666db2702301 X-CR-MTA-TID: 64aa7808 Received: from 097089684a98.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 40B11EC2-F067-493A-B0A5-425EC71D97A4.1; Wed, 20 Oct 2021 10:10:17 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 097089684a98.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 20 Oct 2021 10:10:17 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jOPW6IT/bgcn8adk/CtOy7bQ6pC34usj2/YpMVdw+w+ax+LU7Vy5LGAZuDKobPB0352xpJ7A7m6TOJK8/N0/GgeWdabdGN6kNodIebKVe/HuiGQn+7jVp+1wHFomEmtOPoukxnOfY9OlI2XBN8xHxL43FZlNeHQdQvqvEU8bGbIyKFsSXFg/Y6W/GR9tAiba7UweQhu5AR1fT258el39azUTroAHOcSKPI8sJnBW2DCeIHi1xuZJhKhg2HrLG2yVutAgyf0BlM/DKsCDZFEaSKzDBICDB64Qcu+f1Scgv8dD7Zy0onCwUzZy/xiNxkHX1E8zqS5dlchKR/ZDr7SYWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IDlDUhn//K+qkHTTFw8ixvh6TTUYo9WYzocv473/UE8=; b=cIeZF6D5fCLJn9iaSaPlPrbbvSCCE0UE0B4yrW5hkfdEQqS8oV9FCHPAvlLjm9xLqNpCs5ofmFzZQcvq5kacyNxeS+PIdsU7FhJMEwLnSYxnyh/csjs6SLc218lJMGCU4pE+AZDdpbJWQjUUZfhKNqPGzzRnapEtfixZbm5hhVPQk2zPfNShrwwOCZ7gfhWu1+0TuibimDr7B6Thn9/MPgsGxeWzn07/AlExTRAZ5l08/8xQ7K/Rxkk1jhlzBl3EOxmK1NGAemLCDNwFytLJ4Wm9ki2Koh1mbXxvbthEr8dgEcmLqC1XLpSQejg9QScmbocVlphMWuIs/vhweFdBWg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IDlDUhn//K+qkHTTFw8ixvh6TTUYo9WYzocv473/UE8=; b=9LoYSIrrk/eHOb9aDxom48eWQsNmP+8ZMd+8TL85IFq3sxW78US9F7UGKsuEx/Hlyiq+wTmTNmzRR+TeRX33X/UMo+kj7RryU8GSAKIFxuFEx3Ca4SFX1C7jJJSNGlh+GsPUN5/kvkuHJH68L4NFF33syLdaIcwyJ2+FSN+JEPI= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by AM7PR08MB5383.eurprd08.prod.outlook.com (2603:10a6:20b:102::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.16; Wed, 20 Oct 2021 10:10:15 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::54b5:239d:9896:ee65]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::54b5:239d:9896:ee65%4]) with mapi id 15.20.4608.018; Wed, 20 Oct 2021 10:10:15 +0000 Subject: Re: [PATCH] DynamicTablesPkg: Fix unitialized variable use From: "Sami Mujawar" To: Moritz Fischer , devel@edk2.groups.io Cc: Alexei Fedorov , nd References: <20211020052118.1227640-1-moritzf@google.com> <86648b45-863a-9e27-6db1-7127bb8ed7ed@arm.com> Message-ID: <93442dd1-99e2-9538-237b-7eb9ef8b961e@arm.com> Date: Wed, 20 Oct 2021 11:10:13 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 In-Reply-To: <86648b45-863a-9e27-6db1-7127bb8ed7ed@arm.com> X-ClientProxiedBy: LO2P265CA0189.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a::33) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 Received: from [10.1.196.43] (217.140.106.52) by LO2P265CA0189.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.16 via Frontend Transport; Wed, 20 Oct 2021 10:10:15 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e04d47f8-702f-4e79-b011-08d993b1d553 X-MS-TrafficTypeDiagnostic: AM7PR08MB5383:|PR2PR08MB4698: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:4303;OLM:4303; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: XCFNHZABdQW0i2YYeg5EnFqH+SFYyCZ3J0dCHtfBJW3DJsdpZmOW2n/NujJ4z+G0Ur0jzJzDp4DzdWc87cm7CygK/49yMeDQJxNDMzdJXwhN+jUZ77twTeOHpfO6QFU0XJZe11etEoYrmL3DeWBLzcrheC1kcU4GQGwrocbnxfED9eNnK+3Pp7vuQ8RKGkIBnvsrH52wfStTmQxs5uuGE65450tzngTB2V5j1iIxl4QF5Mp4v00z4LIYkIvIU8kYcC3W+WuCYJcFqKAN4mXeX4wigntrS6hDN5SXx4vDv4E1gwHqKkG7hpOXXXEpr1WGmwSgXN3Qx4TPsLJ1lPjOMi4wexAeSuU9X6umilNooPKXTKplfuwd/z4GqeNMwCTXoREK4q6Pqe44XVwB/eDMgXX6mSR/9uHkOSGgCXWQQQCYkxrJPQqtibo+acUzmfZjyW5f7CfkPMlHndNRz7s0fakd3HS8vw09VsizxNzZRKZH03Ku35em3gUEBUSLF+Opa0Zl4t3n4SGsdTrwLQFckReE/61XtDtyROsS3H8sZixT7ZTzymwBDbPtVvg7H0slLHWp3p8v8lYTmmAViv55xfOA7tSSHuoq5FA068u4RL74kueE8q40IILyGKHMIoZcmtx1m6rHb9/XhD3fAo7G1e3ZOXE0Ls5Cr3Z0R1+fiLTgKhHwbkEhDX4JQw1+mJzVSh8FABxCyxMUZnXWKv+y34YZlXG832wyNATf6FyY61DbrNZRv1PT3sVxywfadNZDEWGJ8PBOTpW306nIGmAURA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(83380400001)(31696002)(16576012)(8676002)(316002)(36756003)(956004)(5660300002)(2616005)(186003)(31686004)(38100700002)(4326008)(38350700002)(54906003)(8936002)(53546011)(52116002)(508600001)(66476007)(66946007)(26005)(2906002)(6486002)(86362001)(44832011)(66556008)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR08MB5383 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT035.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 57a7766c-b5f4-482c-b5d5-08d993b1cfce X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: X8tBPQ3ThCIRsA9sOw1D9wcGzV/No+fbIk6CNnTNN6QD30mv6fTMBnqFdr+V5eWvRw/NaCimVdzZ36mSitjVbLbIKK8lmsHX1Tmy168yr142azBG3ASB8pmiRRPgpZNN2tl513NzF6rLKoR+bHzrWUjyvnhZrnUZF3d5LOqS/z64/B/FoojPnhpS5sUXzVgh4Vgg98k0nWjmGUqaDdv1v7pnGCG7HFKLZhKfneUnZIqo5ZjzIhSsH7OsEO4Vgq/U2OuzfXHazeegcfdlHQC2djf6t2hzm1bpltIQSE+ZbJHkjAKK29XuaHSJljx/6qqhOFwqNvEYZXQT8RnavqyJFisplC7vDqUNgy6//7i5eoszyIrc27ApA2XBW4ChcaI75nx6Pg7YZ+TN+L9Nj2Gs3DjBOBwU/rbArYtPdEI+x5cKj5q24PRnlYrAsBvbGInXy/j5CILdbCJXQGkuMDaUEhn/jxtRY+AA3+qod6WAlzKNHBktu/wyJIssL1s8VBGjWy8G6g5V3r7ypER3CzL2p9VJOiSFEIHyTZCeOWSMMTwxOVLLvGPBAayp1aJTbLjGZAYBOnLY9Ykbi3GQlEdBlHjBL+B81//SO+qxP/A9EqGuZVv1lAPh7U5a3ImXeVKppWA3QG/ZavQfu8Nr/vixVdmR3FksDshj0zZ6Z35dwID6IuXSwE0ZP7TON3IpTz17pqxOs5UC5vocr9UOyOSBWCCu9RyfU+w4rl0/HcTeGNA= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(83380400001)(508600001)(82310400003)(356005)(44832011)(31696002)(5660300002)(26005)(36860700001)(36756003)(186003)(70586007)(53546011)(70206006)(81166007)(2906002)(31686004)(4326008)(86362001)(2616005)(956004)(6486002)(8676002)(47076005)(336012)(54906003)(316002)(16576012)(8936002)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2021 10:10:24.7091 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e04d47f8-702f-4e79-b011-08d993b1d553 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT035.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR2PR08MB4698 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB Merged as 37a33f02aa1a..4fdf843c75d2 Thanks. Regards, Sami Mujawar On 20/10/2021 10:40 AM, Sami Mujawar wrote: > Hi Moritz, > > Thank you for this fix. > > Reviewed-by: Sami Mujawar > > Regards, > > Sami Mujawar > > On 20/10/2021 06:21 AM, Moritz Fischer wrote: >> In the success case we should return EFI_SUCCESS rather than returning >> a potentially unitialized value of Status. >> >> Cc: Sami Mujawar >> Cc: Alexei Fedorov >> Signed-off-by: Moritz Fischer >> --- >> .../Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git >> a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c >> b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c >> >> index 0bdb6c24c5bb..e9e1a85ede63 100644 >> --- >> a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c >> +++ >> b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c >> @@ -91,7 +91,7 @@ LinkRdNode ( >> *NewRdNode = RdNode; >> } >> - return Status; >> + return EFI_SUCCESS; >> error_handler: >> Status1 = AmlDeleteTree ((AML_NODE_HEADER*)RdNode); >