From mboxrd@z Thu Jan 1 00:00:00 1970 Subject: Re: [edk2-devel] [PATCH v1 04/10] DynamicTablesPkg: Add HexFromAscii() to AcpiHelperLib To: PierreGondois ,devel@edk2.groups.io From: "Sami Mujawar" X-Originating-Location: Great Shelford, England, GB (217.140.106.53) X-Originating-Platform: Windows Firefox 92 User-Agent: GROUPS.IO Web Poster MIME-Version: 1.0 Date: Wed, 22 Sep 2021 08:23:04 -0700 References: <20210623110525.6171-5-Pierre.Gondois@arm.com> In-Reply-To: <20210623110525.6171-5-Pierre.Gondois@arm.com> Message-ID: <9346.1632324184403895947@groups.io> Content-Type: multipart/alternative; boundary="2RBr3aL5UXpYT62LYVsa" --2RBr3aL5UXpYT62LYVsa Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi Pierre, Thank you for this patch. On Wed, Jun 23, 2021 at 04:05 AM, PierreGondois wrote: >=20 > + @return The corresponding integer (between 0-16). I have a minor suggestion to update the documentation for the value returne= d in error scenario. Other than that this patch looks good to me. With that changed, Reviewed-by: Sami Mujawar Regards, Sami Mujawar --2RBr3aL5UXpYT62LYVsa Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi Pierre,

Thank you for this patch.

On Wed, Jun 23, = 2021 at 04:05 AM, PierreGondois wrote:
+ @return The corresponding integer (between 0-16). I have a minor suggestion to update the documentation for the value returne= d in error scenario. Other than that this patch looks good to me.
With= that changed,

Reviewed-by: Sami Mujawar <sami.mujawar@arm.co= m>

Regards,

Sami Mujawar --2RBr3aL5UXpYT62LYVsa--