From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM04-CO1-obe.outbound.protection.outlook.com (NAM04-CO1-obe.outbound.protection.outlook.com [40.107.69.62]) by mx.groups.io with SMTP id smtpd.web10.14432.1600869497799651644 for ; Wed, 23 Sep 2020 06:58:17 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amdcloud.onmicrosoft.com header.s=selector2-amdcloud-onmicrosoft-com header.b=ePlKF0jI; spf=none, err=SPF record not found (domain: amd.com, ip: 40.107.69.62, mailfrom: thomas.lendacky@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ISIjdxiOVXNxM7PkDV9xNOMA7HI4HHgC6Y82CGTby5kSEJZwt3qDfonoFh2MGVVQKMykQmMTdM2qqHFO6WVxLZFGPcGGGvK7cwyjWt+dHh2DTzErdg5hRqPJ9QuwiB24oe85+1/vbT/dTtGYnGkveTeM++jW+dI7ZaVKW6JllZIZolMt6jQ/swpYkN4F3z6OkM8KJmCMqBbjOVeuMZip8CtFcKvE+8vEYaBn4eOQ/oz84spJAAHY70EXNsugKBu9ppAUiBZYfGmr4M3Guq0ufXOvNR/zgPgqLaXnBIZp5T+oBbXtLku2wOyQN9XnRsUcpZxqS/p1poglH2Ci3UreNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WpxM6gYM5H/L1wvfMcBlR29aD2O8YSbrA2t+p7eSLc4=; b=oPuYk7J+Nb9/5210VpMnOGPaKBxcAstR6E2isxbxwn0m2oq6Q+VcprjkaDareQuv9pFNrlZeyPDx1r7ip6i3z3r8OGJgNcdxyB7lQB0MQChzSdMy0X15B5veW/KLBki+DIEIAouUooRuoN3CV1dBmhHh9Hiy2UbRhrb3b/CdUel8bZE5zReW4LDOvL1gEPI04lSxkeic1XHFxdF0lvrS9gxTMGkH2nLHGZl9Gc+I+jEzRET7hJJC81SEHoyBbeyYOPKB3gGBDRfGZ15FLtLoXLnkTVXNi7N2vlAQJw6539Om4+6bceHa38obFIjmGZYp9RQk0IzK92bq91KgvdoWdg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector2-amdcloud-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WpxM6gYM5H/L1wvfMcBlR29aD2O8YSbrA2t+p7eSLc4=; b=ePlKF0jIIvmbi/xZ2vE7H/KgKbpPdxUkgeSdV17tOQpcXVhrPm87rt+NcGgPNoYZFMh9M/BmtwOIRnsx4kByMOnKALjBaVpdKAP1EVA+qayib6Ewu3S1rnqljrSDH7YFkRTlh6k8SKWkHbXAVXuQAq+E84pU8L5VzMsqVHcr6MY= Authentication-Results: amd.com; dkim=none (message not signed) header.d=none;amd.com; dmarc=none action=none header.from=amd.com; Received: from DM5PR12MB1355.namprd12.prod.outlook.com (2603:10b6:3:6e::7) by DM5PR1201MB0027.namprd12.prod.outlook.com (2603:10b6:4:59::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.24; Wed, 23 Sep 2020 13:58:16 +0000 Received: from DM5PR12MB1355.namprd12.prod.outlook.com ([fe80::299a:8ed2:23fc:6346]) by DM5PR12MB1355.namprd12.prod.outlook.com ([fe80::299a:8ed2:23fc:6346%3]) with mapi id 15.20.3391.024; Wed, 23 Sep 2020 13:58:16 +0000 Subject: Re: [PATCH 1/1] UefiCpuPkg/MpInitLib: Reduce reset vector memory pressure To: Laszlo Ersek , devel@edk2.groups.io Cc: Eric Dong , Ray Ni , Rahul Kumar , Brijesh Singh , Garrett Kirkendall References: <22eb2625-6ece-6f1d-43b2-4ca6aad54b9c@redhat.com> <58ed06b7-dc6e-61ab-1e82-ec14d10a700e@redhat.com> From: "Lendacky, Thomas" Message-ID: <934ea92f-4e83-37ae-cf3d-a8e252bfa68e@amd.com> Date: Wed, 23 Sep 2020 08:58:14 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 In-Reply-To: <58ed06b7-dc6e-61ab-1e82-ec14d10a700e@redhat.com> X-ClientProxiedBy: DM6PR18CA0032.namprd18.prod.outlook.com (2603:10b6:5:15b::45) To DM5PR12MB1355.namprd12.prod.outlook.com (2603:10b6:3:6e::7) Return-Path: thomas.lendacky@amd.com MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [10.236.30.118] (165.204.77.1) by DM6PR18CA0032.namprd18.prod.outlook.com (2603:10b6:5:15b::45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3412.20 via Frontend Transport; Wed, 23 Sep 2020 13:58:15 +0000 X-Originating-IP: [165.204.77.1] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: fffe78df-14a3-4998-8ed9-08d85fc8b80b X-MS-TrafficTypeDiagnostic: DM5PR1201MB0027: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9xiov969qYZELnAz+r/xGzngveDLuitsKahQ4aU4zfhkcp+JHYXw3hVDLg8GBhQWnXWASf1Dh06N5zWvdh6meOE//LeK40xA6jOLTBfHB3oIfgJ64/X4Wkx8wcdv+jg390rUfLnTOLEhmw8NK0C25KBeHOYrdjhQ/fi8Gkx+y3+RGjBYhMaWDYDG7cHRoUUAANGVbro/t/4rwkImIXZPBnSe3+9ukzuHhWGeY5teKIEv786yngEVVh0zpSvMXT3Rz1cHPoaYHI2LkYgJnttRuebCEIjqou5Pdd/cfnR2nyjmKghqiE1sZIaQ+FOaLer4CzkS6JbEKN9238g9WbvfdcccTj2iDOhduABbILiqfYNK+CcAPLS9+VAbYWXLrCyJmUgWc0i9gXnW4O84gKNcXmuSWoHzeZp5JbRIwBEs7b0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR12MB1355.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(6029001)(4636009)(366004)(39860400002)(346002)(396003)(376002)(136003)(186003)(4326008)(83380400001)(8676002)(8936002)(2906002)(53546011)(6486002)(54906003)(36756003)(52116002)(31686004)(26005)(316002)(31696002)(16526019)(86362001)(478600001)(66946007)(5660300002)(2616005)(66556008)(956004)(16576012)(66476007)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: An9epiHaYmEre0i37rmm78FfJrhrzCb/j3WekT0hL/YmoaxkXrFhP/31U+FaeE+DeRMBOq2IG2naORHl3eIpMLBh05A6cdx5aHpHkUm+7HDW3/lC7YfEf+cg8ZPaweq5Ro7PhHiXxzYRtKrBtcpsxullxv/nPC+AuKLbq08CWd+dHncVk7N81d+EP+dBKPUeENi9MKZ/i+dIxs41dGBkHi0pA+2FVDpA1Vo2mpB+Q/bG2URjM2MPmUCfDzDF3HyaA8YLuYXhj5wdtaFPE/r2yQIgzUgwUksUQd7RlwYpOODBBwS4gyXhn9Ihax34OaCwouQyLShywvdRf7VNRyZC8H2X5RUStNZidxM+QXgyxOsHzXm6W4Drg4pzP/VlG7hCmHkcznumZdOuddIb204Lwrky1ScU1V484Gd29pCNCyl6FVPdAnfedGPhqKDA1nD5LJ6lOIvinvyhpvpP6Gt1mZ+pi7c5pITGqzXOAuCjU5G7+GZJ1GwoKft3e8zUpIqVAnxKsj+Cw4yTSsy8CJCg27rIX2SnvXs8du3u/Ar6XU4D4sg2/jQJpX9IyG5/g/yNY3WeL3mKvs6jdu6sD3vSvfoWkKln6QStxgJmR/tBy9K0wpq1DRkzSGLUFabsV+fWny8vDVaWKFWqyAEtQNdGpw== X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: fffe78df-14a3-4998-8ed9-08d85fc8b80b X-MS-Exchange-CrossTenant-AuthSource: DM5PR12MB1355.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Sep 2020 13:58:16.1757 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: uBfGZVIbrEX9zeKvMUsH7eiVFUGSvEq1Uf3pQA795F/Qig8wPGHWOzsvbx4IAjXcoyiNwCslofLAniq2+Aom/A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1201MB0027 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 9/23/20 3:31 AM, Laszlo Ersek wrote: > On 09/23/20 10:14, Laszlo Ersek wrote: > >> (3) Even better... can you modify GetApResetVectorSize() to take >> &CpuMpData rather than &CpuMpData->AddressMap, and then check >> CpuMpData->SevEsIsEnabled? >> >> Hmmm, wait, that's not really simple, as we call GetApResetVectorSize() >> from MpInitLibInitialize() too, way before we set >> CpuMpData->SevEsIsEnabled from the PCD. >> >> So I guess we should pass a dedicated BOOLEAN parameter to >> GetApResetVectorSize(), called "SevEsIsEnabled". At the call site in >> MpInitLibInitialize(), we should pass in the PCD's value. At the call >> site in AllocateResetVector(), we should pass in >> CpuMpData->SevEsIsEnabled. >> >> The reason I'm suggesting (3) is that I don't feel comfortable with >> checking dynamic PCDs outside of entry point functions / initialization >> functions. > > You know what, never mind (3) -- I've just realized that > PcdCpuMaxLogicalProcessorNumber may be a dynamic PCD too. It might > require a lot of work to restrict all dynamic PCD accesses to the init > function only, and I couldn't necessarily justify all that work at the > moment (for myself or for anyone else). > > So please consider (1), (2) and (4). Yup, will do. Thanks, Tom > > Thanks! > Laszlo >