From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id BE08522361E4F for ; Thu, 8 Feb 2018 01:41:54 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1FA78806B5; Thu, 8 Feb 2018 09:47:39 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-94.phx2.redhat.com [10.3.116.94]) by smtp.corp.redhat.com (Postfix) with ESMTP id DE8975EDE6; Thu, 8 Feb 2018 09:47:37 +0000 (UTC) To: Ard Biesheuvel Cc: Jordan Justen , "Kinney, Michael D" , "edk2-devel@lists.01.org" , "Yao, Jiewen" References: <20180207225822.28876-1-michael.d.kinney@intel.com> <20180207225822.28876-6-michael.d.kinney@intel.com> <151807874262.22216.16754691005585782342@jljusten-skl> From: Laszlo Ersek Message-ID: <937f0d65-2131-43ea-72ae-acb98c9a0479@redhat.com> Date: Thu, 8 Feb 2018 10:47:36 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Thu, 08 Feb 2018 09:47:39 +0000 (UTC) Subject: Re: [Patch 05/10] OvmfPkg: Add SafeIntLib and BmpSupportLib to DSC files X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Feb 2018 09:41:55 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 02/08/18 10:32, Ard Biesheuvel wrote: > On 8 February 2018 at 09:25, Laszlo Ersek wrote: >> On 02/08/18 09:32, Jordan Justen wrote: >> >>> Given the wording from the contribution agreement, it appears that it >>> would also be fine to just use Mike's Signed-off-by if he is >>> authorized to contribute the code even though he didn't author it. >> >> So basically just >> >> """ >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Michael D Kinney >> """ >> >> implies Mike saying, "trust me guys, I got Microsoft's authorization (or >> whoever the original authors were) to contribute their code under the >> 2-clause BSDL". Is that right? >> >> Dunno why but this concept is hard for me to accept. :) "whoever the >> original authors were" is super vague to me. Let's say I want to verify >> that authorization myself: whom do I contact? Are the >> "https://github.com/Microsoft/MS_UEFI/..." references considered >> sufficient origin information? >> > > This is exactly the reason: if someone contributes code under a > suitable license, they should take full responsibility that the code > in question is actually covered by that license. OK. If that works, then patches #5 and #10 are Reviewed-by: Laszlo Ersek as they are in this series. (This keeps boggling my mind -- I honestly wonder whether responsibility *can* stop at the submitter, as opposed to "catching up" with the whole project --, so I'm pretty sure I'll forget about this interpretation again, and you'll have to remind me again. Please bear with me. :( ) > I refuse any responsibility for verifying the origin of code that > others contribute, and I'm sure your workload doesn't allow it either. It's definitely not that I'd take any responsibility for origin verification; I just figured that contributors could (or should) semi-formally support such efforts, *should* someone in the future feel like verifying the origin. Thanks Laszlo