From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.groups.io with SMTP id smtpd.web11.7501.1602578909582327057 for ; Tue, 13 Oct 2020 01:48:30 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=fL1m57Hr; spf=pass (domain: redhat.com, ip: 63.128.21.124, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1602578908; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=L1pkbEXAUC8RpmJcrgncM+4rOB51TcaqKovRUJA6BZE=; b=fL1m57HrClTURT6zQbfZ1DmR+UKHN4csZXWgI4NazjsxbH0PsAakUOVn2Lt6W2xYnnKO+b vK1lFmM6Qy2b7FzyjL4GceSynb2MllYlTLpuuy1Zk/8J0VIBZfChIXR/kR3ACUDLATJDZB 8xGlLSF64ajTNZxgEhUfI/pwwoGEeOk= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-506-LvIoHuD5MfCe5aGCSrhUOA-1; Tue, 13 Oct 2020 04:48:27 -0400 X-MC-Unique: LvIoHuD5MfCe5aGCSrhUOA-1 Received: by mail-wr1-f72.google.com with SMTP id u15so10606142wrn.4 for ; Tue, 13 Oct 2020 01:48:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=L1pkbEXAUC8RpmJcrgncM+4rOB51TcaqKovRUJA6BZE=; b=b1W3tKq3U+8kIugRi31gVOJ1JivIT3PveP4R+cqr1le7UitteF8QDpDkF9gyDn08tw pcC9zkEpy0YKf4aQqZYIUJGpD91INHqdZD5O/o9NtlRvJJzxwRg4Gr0NpccTLoDc6YmM c7vuFpEgMc2ODnj0RQ8gI7vbXrs6zs/pQTRqokebavzfhMyuR6+uYYW9GEMiy7yODe+Y AbpR8DxVaT0YRCMpMBNEXTC7xxC5DnLlkD7z/tpVQc8IOqLsfRNWKryOQk0p3XLWkAkn gqlqZjk+8yQS1BK0zidzud9DoEKigMPrYHpPuLoFPoINdKq/ITv24VMLhyD+d/HKL3sm QNvw== X-Gm-Message-State: AOAM533YfJjw8HyAx+gqON2gNAbiXlXJX+zW9HFWX1wC/UD5Uq+UywnP xeXXS7xvxTlqsK6vbxhpPU5Db5Y/tkTBoEQdaBX97snLrh09Hh7vpL/y8Qo789pAeqelNXpgDJw iOstBQqhbu1BR/w== X-Received: by 2002:a1c:26c3:: with SMTP id m186mr13836408wmm.115.1602578905556; Tue, 13 Oct 2020 01:48:25 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzIJmDgs3rbknxlKsKAHJq6DVJHHpQr+66q91AuZTZK63Xs7O4I8GnnijcLJKQkqi8rngxzBw== X-Received: by 2002:a1c:26c3:: with SMTP id m186mr13836396wmm.115.1602578905331; Tue, 13 Oct 2020 01:48:25 -0700 (PDT) Return-Path: Received: from [192.168.1.36] (106.red-83-59-162.dynamicip.rima-tde.net. [83.59.162.106]) by smtp.gmail.com with ESMTPSA id c68sm25656701wmd.34.2020.10.13.01.48.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Oct 2020 01:48:24 -0700 (PDT) Subject: Re: [edk2-devel] [Patch] Basetools: Fixed FMMT Linux build break issue To: "Feng, Bob C" , "devel@edk2.groups.io" Cc: Yunhua Feng , Liming Gao References: <20201013072339.20644-1-bob.c.feng@intel.com> <2c078f0b-1f6b-aef8-e8ec-732044e64925@redhat.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: <93808d6e-10a3-0cac-b4f3-e2ae6155e35c@redhat.com> Date: Tue, 13 Oct 2020 10:48:23 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit On 10/13/20 10:32 AM, Feng, Bob C wrote: > Hi Phil, > > Since the FMMT tool is in the edk2-staging repo, branch FceFmmt, the 950333853b5fe2b73a7b5148501458cc97a01481 is in there. Well this is confusing. Some contributors use the staging/ prefix in their patch subject. Maybe the contribution guideline could be updated. > > Thanks, > Bob > > -----Original Message----- > From: Philippe Mathieu-Daudé > Sent: Tuesday, October 13, 2020 4:02 PM > To: devel@edk2.groups.io; Feng, Bob C > Cc: Yunhua Feng ; Liming Gao > Subject: Re: [edk2-devel] [Patch] Basetools: Fixed FMMT Linux build break issue > > On 10/13/20 9:23 AM, Bob Feng wrote: >> Fixed the FMMT Linux build issue which was introduced by the commit >> 950333853b5fe2b73a7b5148501458cc97a01481 > > fatal: bad object 950333853b5fe2b73a7b5148501458cc97a01481 > >> >> Signed-off-by: Bob Feng >> Cc: Yunhua Feng >> Cc: Liming Gao >> --- >> .../Source/C/FMMT/FirmwareModuleManagement.c | 15 ++++----------- >> 1 file changed, 4 insertions(+), 11 deletions(-) >