Re: [edk2-devel] [PATCH v1 1/1] StandaloneMmPkg/Core: Output status in MMI handler assertion

["Laszlo Ersek" <lersek@redhat.com>]

On 1/31/24 05:44, Michael Kubacki wrote:
> From: Michael Kubacki <michael.kubacki@microsoft.com>
> 
> Currently, if a MMI handler returns an unexpected failure status
> code, ASSERT (FALSE) is used. It is more useful to use
> ASSERT_EFI_ERROR() which also outputs the status code value.
> 
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> ---
>  StandaloneMmPkg/Core/Mmi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/StandaloneMmPkg/Core/Mmi.c b/StandaloneMmPkg/Core/Mmi.c
> index 8252355a48eb..0de6fd17fc88 100644
> --- a/StandaloneMmPkg/Core/Mmi.c
> +++ b/StandaloneMmPkg/Core/Mmi.c
> @@ -208,7 +208,7 @@ MmiManage (
>          //
>          // Unexpected status code returned.
>          //
> -        ASSERT (FALSE);
> +        ASSERT_EFI_ERROR (Status);
>          break;
>      }
>    }

Reviewed-by: Laszlo Ersek <lersek@redhat.com>



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#114880): https://edk2.groups.io/g/devel/message/114880
Mute This Topic: https://groups.io/mt/104069723/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-