From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 93489AC1109 for ; Wed, 31 Jan 2024 11:26:54 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=//E5p12/IEtOUOv+eloqywo7rIazqO5fmw23Jl9lswA=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1706700413; v=1; b=rGOuxxd9IZWJ3e+VaEuK8I8MKnQacocJJ0MEOFuiovFlsnf/k3pjJaxL1ewppmIJQzZrSI2a fRdnfEKHZvWhOAGt2mAxUwzvwDgOVMW7BzwaR4w2kvs/YSeX7jlI+fBbnK5fWrLNvnhNx0g3Gp6 1+X3NOIvxco453NOZaNDoX8g= X-Received: by 127.0.0.2 with SMTP id qfVhYY7687511xo7n3EgCYJb; Wed, 31 Jan 2024 03:26:53 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web10.11827.1706700412498726166 for ; Wed, 31 Jan 2024 03:26:52 -0800 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-518-ABYxVA2qP-u7rJYrRefh3Q-1; Wed, 31 Jan 2024 06:26:48 -0500 X-MC-Unique: ABYxVA2qP-u7rJYrRefh3Q-1 X-Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 26E6A85A588; Wed, 31 Jan 2024 11:26:48 +0000 (UTC) X-Received: from [10.39.192.35] (unknown [10.39.192.35]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 440D240C95AD; Wed, 31 Jan 2024 11:26:47 +0000 (UTC) Message-ID: <9389723b-80a0-6c11-d630-6f80ab216087@redhat.com> Date: Wed, 31 Jan 2024 12:26:46 +0100 MIME-Version: 1.0 Subject: Re: [edk2-devel] [PATCH v1 1/1] StandaloneMmPkg/Core: Output status in MMI handler assertion To: devel@edk2.groups.io, mikuback@linux.microsoft.com Cc: Ard Biesheuvel , Sami Mujawar , Ray Ni References: <20240131044422.1837-1-mikuback@linux.microsoft.com> From: "Laszlo Ersek" In-Reply-To: <20240131044422.1837-1-mikuback@linux.microsoft.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: CNC1MO5WXxtK0zL6qWk14hHEx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=rGOuxxd9; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 1/31/24 05:44, Michael Kubacki wrote: > From: Michael Kubacki >=20 > Currently, if a MMI handler returns an unexpected failure status > code, ASSERT (FALSE) is used. It is more useful to use > ASSERT_EFI_ERROR() which also outputs the status code value. >=20 > Cc: Ard Biesheuvel > Cc: Sami Mujawar > Cc: Ray Ni > Signed-off-by: Michael Kubacki > --- > StandaloneMmPkg/Core/Mmi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/StandaloneMmPkg/Core/Mmi.c b/StandaloneMmPkg/Core/Mmi.c > index 8252355a48eb..0de6fd17fc88 100644 > --- a/StandaloneMmPkg/Core/Mmi.c > +++ b/StandaloneMmPkg/Core/Mmi.c > @@ -208,7 +208,7 @@ MmiManage ( > // > // Unexpected status code returned. > // > - ASSERT (FALSE); > + ASSERT_EFI_ERROR (Status); > break; > } > } Reviewed-by: Laszlo Ersek -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114880): https://edk2.groups.io/g/devel/message/114880 Mute This Topic: https://groups.io/mt/104069723/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-