From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by mx.groups.io with SMTP id smtpd.web11.70058.1674725809337420461
 for <devel@edk2.groups.io>;
 Thu, 26 Jan 2023 01:36:49 -0800
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: thomas.abraham@arm.com)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
	by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CDE004B3;
	Thu, 26 Jan 2023 01:37:30 -0800 (PST)
Received: from [10.57.75.31] (unknown [10.57.75.31])
	by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A855C3F71E;
	Thu, 26 Jan 2023 01:36:47 -0800 (PST)
Message-ID: <93933c40-3c59-efb0-6180-3962058635d0@arm.com>
Date: Thu, 26 Jan 2023 09:36:46 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.13.0
Subject: Re: [PATCH edk2-platforms 5/5] Platform/ARM/Sgi: Add VariableFlashInfoLib to SgiPlatformMm.dsc.inc
To: Pierre.Gondois@arm.com, devel@edk2.groups.io
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>,
 Sami Mujawar <sami.mujawar@arm.com>,
 Leif Lindholm <quic_llindhol@quicinc.com>, Wenyi Xie <xiewenyi2@huawei.com>,
 Ilias Apalodimas <ilias.apalodimas@linaro.org>,
 Omkar Anand Kulkarni <omkar.kulkarni@arm.com>,
 Pranav Madhu <pranav.madhu@arm.com>,
 Sayanta Pattanayak <Sayanta.Pattanayak@arm.com>
References: <20230125102802.663790-1-Pierre.Gondois@arm.com>
 <20230125102802.663790-6-Pierre.Gondois@arm.com>
From: "Thomas Abraham" <thomas.abraham@arm.com>
In-Reply-To: <20230125102802.663790-6-Pierre.Gondois@arm.com>
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit



On 25/01/2023 10:28, Pierre.Gondois@arm.com wrote:
> From: Pierre Gondois <pierre.gondois@arm.com>
> 
> Building the following images with the SECURE_STORAGE_ENABLE flag
> fails due to VariableFlashInfoLib being missing:
>   - Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc
>   - Platform/ARM/SgiPkg/PlatformStandaloneMm2.dsc
> 
> Add the missing library.
> 
> Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
> ---
>   Platform/ARM/SgiPkg/SgiPlatformMm.dsc.inc | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/Platform/ARM/SgiPkg/SgiPlatformMm.dsc.inc b/Platform/ARM/SgiPkg/SgiPlatformMm.dsc.inc
> index f9a516b341f0..343794c59143 100644
> --- a/Platform/ARM/SgiPkg/SgiPlatformMm.dsc.inc
> +++ b/Platform/ARM/SgiPkg/SgiPlatformMm.dsc.inc
> @@ -72,6 +72,7 @@ [LibraryClasses.common.MM_STANDALONE]
>     TimerLib|MdePkg/Library/BaseTimerLibNullTemplate/BaseTimerLibNullTemplate.inf
>     VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf
>     SafeIntLib|MdePkg/Library/BaseSafeIntLib/BaseSafeIntLib.inf
> +  VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVariableFlashInfoLib.inf
>   !endif
>   
>   ################################################################################

Thanks for this fix.

Reviewed-by: Thomas Abraham <thomas.abraham@arm.com>