From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-in6.apple.com (mail-out6.apple.com [17.151.62.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id A7B231A1EE0 for ; Wed, 5 Oct 2016 12:48:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; d=apple.com; s=mailout2048s; c=relaxed/simple; q=dns/txt; i=@apple.com; t=1475696924; h=From:Sender:Reply-To:Subject:Date:Message-id:To:Cc:MIME-version:Content-type: Content-transfer-encoding:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-reply-to:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=h9/EH1P9ZzfotLvLsLjbQyw0Cl61fNc1ktmHfG3LmoE=; b=DrC98STMjeB0/TXmcl7t0uEMi84Kn7OG3fRpIBFcsyZlSeTY8o/BbG600Em29V/r qw6YKQzzg+nov/UZt+6wxFwtDrdkm/xIyk8M7UO+F8tr9/ChwctVwfSSbe6VdsOQ pJGEDOIvfm8vF4LsyRyUVV+h7vSBpE5kM/dnaWMyWp9zQwbjNdli1D+bNNEFLZ6e g3OnQkCV11KPx5gkjilFQpk7tk3d8Fqjot1ifaEggMDbA2pIjiL0TTzEefwHpKp8 1GlWeEY0bYWxOpf+ulY/cJqBOt19Aw9s/eGccYbkNulp+i1E0pVcgH1C2u/sT6GT U7tMMShKzqNoEjP7IppO0A==; Received: from relay6.apple.com (relay6.apple.com [17.128.113.90]) by mail-in6.apple.com (Apple Secure Mail Relay) with SMTP id AA.71.06862.B1955F75; Wed, 5 Oct 2016 12:48:44 -0700 (PDT) X-AuditID: 11973e15-349ff70000001ace-a0-57f5591b5990 Received: from nwk-mmpp-sz13.apple.com (nwk-mmpp-sz13.apple.com [17.128.115.216]) by relay6.apple.com (Apple SCV relay) with SMTP id 96.E4.23613.B1955F75; Wed, 5 Oct 2016 12:48:43 -0700 (PDT) MIME-version: 1.0 Received: from [17.153.37.250] by nwk-mmpp-sz13.apple.com (Oracle Communications Messaging Server 8.0.1.1.0 64bit (built Jun 15 2016)) with ESMTPSA id <0OEL00ADBB16A570@nwk-mmpp-sz13.apple.com>; Wed, 05 Oct 2016 12:48:43 -0700 (PDT) Sender: afish@apple.com From: Andrew Fish In-reply-to: Date: Wed, 05 Oct 2016 12:48:42 -0700 Cc: "Shah, Tapan" , "Carsey, Jaben" , Supreeth Venkatesh , edk2-devel-01 , Leif Lindholm Message-id: <93F01BC9-4B02-467E-B900-65C6775BB0F3@apple.com> References: To: Daniil Egranov X-Mailer: Apple Mail (2.3226) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrFLMWRmVeSWpSXmKPExsUi2FAYpSsT+TXcYMYGEYstrbfYLfYcOsps sbHpD6vFov6vbBb7DvWzWkzc+IPZgc1jzbw1jB67djWyeyze85LJo3v2P5YAligum5TUnMyy 1CJ9uwSujKfPrzMWzFKp+PWhh6WBsUWui5GTQ0LAROLWutdsXYxcHEICexklWg70scEkHr07 xA6ROMQo8ez+YlaQBK+AoMSPyfdYuhg5OJgF5CUOnpcFCTMLaEl8f9TKAlH/jlHi9eYDjCAJ YQFxiXdnNjFD2CkSz6Y2gcXZBJQlVsz/wA5icwpYS7x+dw3MZhFQlbh+aw0jyCBmgeuMEl8W fGSEWGwj8f3/DlaIDRuYJP4e+gXWISKgLfHw/XZGkIskBGQlZv/yAqmREHjMJnHnyDO2CYzC s5AcPgvh8FlIDl/AyLyKUSg3MTNHNzPPTC+xoCAnVS85P3cTIygyptuJ7mA8s8rqEKMAB6MS D6+BxtdwIdbEsuLK3EOM0hwsSuK83B8+hwsJpCeWpGanphakFsUXleakFh9iZOLglGpgTN7u /Uo/4sb0isk/GKf2ntnX02q4/bXCovMWyvfPXwnc+mEft3fGM0v7iKqSioSfHWW7Hu8sF034 yGCr5bg4/O4p3gsn1E4rPxML5c5lXi/1ISB/isC7oJUlvpuuaeyySbsp6rfa6u73kh03nTOO OL892ho69dxPw+2HCs13WOt+WvTeqqJHS4mlOCPRUIu5qDgRANPhFNRtAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrIIsWRmVeSWpSXmKPExsUi2FB8Q1c68mu4wazf8hZbWm+xW+w5dJTZ YmPTH1aLRf1f2Sz2HepntZi48QezA5vHmnlrGD127Wpk91i85yWTR/fsfywBLFFcNimpOZll qUX6dglcGU+fX2csmKVS8etDD0sDY4tcFyMnh4SAicSjd4fYIWwxiQv31rN1MXJxCAkcYpR4 dn8xK0iCV0BQ4sfkeyxdjBwczALyEgfPy4KEmQW0JL4/amWBqH/HKPF68wFGkISwgLjEuzOb mCHsFIlnU5vA4mwCyhIr5n8AW8YpYC3x+t01MJtFQFXi+q01jCCDmAWuM0p8WfCREWKxjcT3 /ztYITZsYJL4e+gXWIeIgLbEw/fbGUEukhCQlZj9y2sCo+AsJLfOQrh1FpJbFzAyr2IUKErN Saw000ssKMhJ1UvOz93ECA7wwqgdjA3LrQ4xCnAwKvHw3lD9Gi7EmlhWXJkLDAwOZiUR3rfh QCHelMTKqtSi/Pii0pzU4kOMyUAPTGSWEk3OB0ZfXkm8oYmJgYmxsZmxsbmJOWnCSuK8uy9/ ChcSSE8sSc1OTS1ILYLZwsTBKdXAKNu/5ec7hgX/fDZ7cba+npWaecToQdp/8YOiS5ezTpv0 esUyxTwBoyST4ObZosXlb6/qHhM7uKrMUUoheVJmtc3NoD0d041Cl/zYW3Z1rrPrFO0j/2+I 3XNh/SpyO1Xz57upnwvCFQXv6n/ZU16h9V3m1fGDHAnz5toY91vzhii3MvwrYXPOUGIpzkg0 1GIuKk4EAIxaskq0AgAA Subject: Re: Assert in ShellPkg with latest tianocore edk2 source on the Reference Platform X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Oct 2016 19:48:44 -0000 Content-transfer-encoding: 7BIT Content-type: text/plain; CHARSET=US-ASCII > On Oct 5, 2016, at 12:24 PM, Daniil Egranov wrote: > > I have the same ASSERT issue on Juno platform even the EnglishDxe.inf is included to the platform build. If UefiShellLib has such dependency on the protocol then according to EDKII Module Writer's Guide you need to specify the dependency on protocol in the module .inf to ensure the drivers proper load sequence. > > 8.6 Dependency Expressions > A dependency expression specifies the protocols that the DXE driver requires to > execute. In EDK II, it is specified in the [Depex] section of INF file. > The Dependency Expression is for DXE Drivers that are dispatched by the DXE Core. A UEFI Driver from an option ROM or an Application does not get dispatched by the dispatch and the Depex will not help. The Depex ends up being a section in the FV and it has nothing to do with the PE/COFF image of the an application or option ROM. IMHO the shell should try as hard as possible to function and should not ASSERT if some newer Protocol is missing. Thanks, Andre wFish > The following dependency in UefiShellLib.inf fixes ASSERT problem: > > [Depex] > gEfiUnicodeCollation2ProtocolGuid > > > Thanks, > > Daniil > > > On 10/05/2016 11:02 AM, Shah, Tapan wrote: >> It's possible. But I think gEfiUnicodeCollation2ProtocolGuid protocol is necessary for even other Shell libraries other than UefiShellLib in order to have Shell parser and other command line processing to work properly. That's why I added ASSERT if UefiShellLib fails to locate the protocol. >> Reference platform should have EnglishDxe module to have this protocol installed properly. >> >> MdeModulePkg/Universal/Disk/UnicodeCollation/EnglishDxe/EnglishDxe.inf >> >> -----Original Message----- >> From: Carsey, Jaben [mailto:jaben.carsey@intel.com] >> Sent: Wednesday, October 05, 2016 10:41 AM >> To: Supreeth Venkatesh ; edk2-devel-01 ; Shah, Tapan >> Cc: Leif Lindholm ; Carsey, Jaben >> Subject: RE: Assert in ShellPkg with latest tianocore edk2 source on the Reference Platform >> >> Tapan, >> >> Could this be a side effect of your patch? Should we allow the UefiShellLib to continue without this protocol and then return an error only when the OpenFile is called? >> >> Also, it looks like we never properly initialize mUnicodeCollationProtocol. We check for NULL in Constructor, but nothing else... >> >> -Jaben >> >>> -----Original Message----- >>> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of >>> Supreeth Venkatesh >>> Sent: Tuesday, October 04, 2016 3:51 PM >>> To: edk2-devel-01 >>> Cc: Leif Lindholm >>> Subject: [edk2] Assert in ShellPkg with latest tianocore edk2 source >>> on the Reference Platform >>> Importance: High >>> >>> All, >>> >>> Recently, I updated to latest edk2 master (yesterday's) and I am >>> actually encountering assert in >>> ShellPkg/Library/UefiShellLib/UefiShellLib.c >>> >>> if (mUnicodeCollationProtocol == NULL) { >>> Status = gBS->LocateProtocol (&gEfiUnicodeCollation2ProtocolGuid, >>> NULL, (VOID**)&mUnicodeCollationProtocol); >>> ASSERT_EFI_ERROR (Status); >>> } >>> >>> It was working few weeks back and has now stopped working. >>> It's probably because the platform is unable to locate this protocol >>> "UnicodeCollationProtocol". >>> Is Anyone else facing the same issue? >>> Does the new ShellPkg requires additional packages/infs to be included >>> in the platform description file to work with latest changes to get >>> past this error? >>> >>> Thanks, >>> Supreeth >>> IMPORTANT NOTICE: The contents of this email and any attachments are >>> confidential and may also be privileged. If you are not the intended >>> recipient, please notify the sender immediately and do not disclose >>> the contents to any other person, use it for any purpose, or store or >>> copy the information in any medium. Thank you. >>> _______________________________________________ >>> edk2-devel mailing list >>> edk2-devel@lists.01.org >>> https://lists.01.org/mailman/listinfo/edk2-devel >> _______________________________________________ >> edk2-devel mailing list >> edk2-devel@lists.01.org >> https://lists.01.org/mailman/listinfo/edk2-devel > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel