From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web10.34756.1675622049376289146 for ; Sun, 05 Feb 2023 10:34:09 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@linux.microsoft.com header.s=default header.b=QUl5W89M; spf=pass (domain: linux.microsoft.com, ip: 13.77.154.182, mailfrom: mikuback@linux.microsoft.com) Received: from [192.168.4.22] (unknown [47.201.8.94]) by linux.microsoft.com (Postfix) with ESMTPSA id E704020C7E08; Sun, 5 Feb 2023 10:34:07 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com E704020C7E08 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1675622048; bh=7h3YMxoEDIBMdA0t5JEH14Mlkj4X9+iHswc3QZ2WnIQ=; h=Date:Subject:From:To:Cc:Reply-To:References:In-Reply-To:From; b=QUl5W89MGgXtwWGif3SpYnQz+454o124yxhxPkTNRSzp6S8ULLzowFaNk4QIcGzMQ K3/OJHvCHkC4F8mGsxT8GO8j3ryz0Hp7RLuRHfWX/mUuokHHYmC2v8gEwJqCwiDO65 GlOsu8aT0q0J+6z1z20pjqSj+9+vyNyyr3FoAcx8= Message-ID: <93c5b688-aa28-2d3c-7ee0-1c6916a2d327@linux.microsoft.com> Date: Sun, 5 Feb 2023 13:34:06 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 6.2; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.13.1 Subject: Re: [edk2-devel] [PATCH v1 1/1] .devcontainer/devcontainer.json: Add devcontainer file From: "Michael Kubacki" To: devel@edk2.groups.io, Michael D Kinney , Leif Lindholm , Andrew Fish , "Gao, Liming" Cc: Chris Fernald , Oliver Steffen , Sean Brogan Reply-To: devel@edk2.groups.io, mikuback@linux.microsoft.com References: <173C1FA3C96CC3CD.14781@groups.io> <173DE310BC2140E3.21537@groups.io> In-Reply-To: <173DE310BC2140E3.21537@groups.io> Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable With the soft freeze starting soon, I wanted to bring attention to this=20 patch again. It has not received feedback in 2+ weeks on the list. It is simple and intended to help users more easily use Tianocore=20 containers. Can you please review and include this in the stable tag? Thanks, Michael On 1/26/2023 9:44 AM, Michael Kubacki wrote: > I've seen interest on the patch but no R-b yet. I believe those in the=20 > TO line might be the best to provide that since this is a new directory. >=20 > If anyone is interested in being a maintainer/reviewer, let me know and= =20 > I'll update the file. >=20 > Thanks, > Michael >=20 > On 1/20/2023 3:51 PM, Michael Kubacki wrote: >> From: Michael Kubacki >> >> Tianocore maintains container images in the tianocore/containers repo >> and stores container images within the GitHub container registry. >> >> https://github.com/tianocore/containers >> >> This change adds a devcontainer.json file to the edk2 repo. This >> file's metadata and settings to configurate a development container >> for a given well-defined tool and runtime stack. >> >> More information about the devcontainer.json file is available here: >> https://containers.dev/implementors/json_reference/ >> >> This file is recognized by popular tools such as GitHub Codespaces >> and VS Code. In VS Code in particular, it makes it much easier for >> a user to be aware a dev container exists (via UI notifications) >> and to load the container. >> >> A minimal number of VS Code extensions are specified that are useful >> for edk2 development or to assist in complying with CI checks in >> place in edk2. >> >> Cc: Andrew Fish >> Cc: Chris Fernald >> Cc: Leif Lindholm >> Cc: Michael D Kinney >> Cc: Oliver Steffen >> Signed-off-by: Michael Kubacki >> --- >> =C2=A0 .devcontainer/devcontainer.json | 16 ++++++++++++++++ >> =C2=A0 Maintainers.txt=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0 5 +++++ >> =C2=A0 2 files changed, 21 insertions(+) >> >> diff --git a/.devcontainer/devcontainer.json=20 >> b/.devcontainer/devcontainer.json >> new file mode 100644 >> index 000000000000..592bb8cf6626 >> --- /dev/null >> +++ b/.devcontainer/devcontainer.json >> @@ -0,0 +1,16 @@ >> +{ >> +=C2=A0 "image": "ghcr.io/tianocore/containers/fedora-35-dev:latest", >> +=C2=A0 "postCreateCommand": "git config --global --add safe.directory *= &&=20 >> pip install --upgrade -r pip-requirements.txt", >> +=C2=A0 "customizations": { >> +=C2=A0=C2=A0=C2=A0 "vscode": { >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "extensions": [ >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "DavidAnson.vscode-markdownl= int", >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "ms-azuretools.vscode-docker= ", >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "ms-vscode-remote.remote-con= tainers", >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "ms-vscode.cpptools", >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "walonli.edk2-vscode", >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "zachflower.uncrustify" >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ] >> +=C2=A0=C2=A0=C2=A0 } >> +=C2=A0 } >> +} >> diff --git a/Maintainers.txt b/Maintainers.txt >> index 68f603b48398..4aa7973d5156 100644 >> --- a/Maintainers.txt >> +++ b/Maintainers.txt >> @@ -117,6 +117,11 @@ M: Michael Kubacki = =20 >> [makubacki] >> =C2=A0 R: Michael D Kinney [mdkinney] >> =C2=A0 R: Liming Gao [lgao4] >> +.devcontainer/ >> +F: .devcontainer/ >> +M: Michael Kubacki [makubacki] >> +R: Chris Fernald [cfernald] >> + >> =C2=A0 .github/ >> =C2=A0 F: .github/ >> =C2=A0 M: Sean Brogan [spbrogan] >=20 >=20 >=20 >=20