From: "Laszlo Ersek" <lersek@redhat.com>
To: devel@edk2.groups.io, liming.gao@intel.com
Cc: "Wu, Jiaxin" <jiaxin.wu@intel.com>,
"Ye, Ting" <ting.ye@intel.com>,
"Fu, Siyuan" <siyuan.fu@intel.com>
Subject: Re: [edk2-devel] [Patch v5 2/3] NetworkPkg: Add DSC/FDF include segment files to NetworkPkg.
Date: Tue, 14 May 2019 16:33:06 +0200 [thread overview]
Message-ID: <93c84dac-4a98-37cd-e66e-08ab35679d0b@redhat.com> (raw)
In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E444638@SHSMSX104.ccr.corp.intel.com>
Hi Liming,
On 05/08/19 02:14, Liming Gao wrote:
> Sure. Thanks for your detail review.
I've just noticed that commit 1e948802e755 ("NetworkPkg: Add DSC/FDF
include segment files to NetworkPkg.", 2019-05-08) does not carry my
Reviewed-by tag.
But I worked with you across five iterations of this patch series,
spending a lot of energy on the review. I gave my R-b here:
http://mid.mail-archive.com/5cc12fc5-451a-2924-5179-73c1f192681a@redhat.com
https://edk2.groups.io/g/devel/message/40131
Honestly, this makes me feel like I should just abandon the edk2 project
for good. I mean if you wanted to intentionally humiliate a reviewer,
you couldn't do much better than this.
Laszlo
next prev parent reply other threads:[~2019-05-14 14:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-07 14:27 [Patch v5 0/3] Add package level include DSC/FDF in NetworkPkg Liming Gao
2019-05-07 14:27 ` [Patch v5 1/3] NetworkPkg DSC: Add the required ARM library to pass ARM build Liming Gao
2019-05-07 14:27 ` [Patch v5 2/3] NetworkPkg: Add DSC/FDF include segment files to NetworkPkg Liming Gao
2019-05-07 14:53 ` [edk2-devel] " Siyuan, Fu
2019-05-07 18:27 ` Laszlo Ersek
2019-05-07 18:37 ` Laszlo Ersek
2019-05-08 0:14 ` Liming Gao
2019-05-14 14:33 ` Laszlo Ersek [this message]
2019-05-14 15:03 ` Liming Gao
2019-05-07 14:27 ` [Patch v5 3/3] NetworkPkg: Add package level include DSC file Liming Gao
2019-05-07 14:53 ` [edk2-devel] " Siyuan, Fu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=93c84dac-4a98-37cd-e66e-08ab35679d0b@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox