From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com)
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by groups.io with SMTP; Tue, 14 May 2019 07:33:21 -0700
Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mx1.redhat.com (Postfix) with ESMTPS id 43EFF7E459;
	Tue, 14 May 2019 14:33:11 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-233.rdu2.redhat.com [10.10.120.233])
	by smtp.corp.redhat.com (Postfix) with ESMTP id DB77F1001E6F;
	Tue, 14 May 2019 14:33:07 +0000 (UTC)
Subject: Re: [edk2-devel] [Patch v5 2/3] NetworkPkg: Add DSC/FDF include segment files to NetworkPkg.
To: devel@edk2.groups.io, liming.gao@intel.com
Cc: "Wu, Jiaxin" <jiaxin.wu@intel.com>, "Ye, Ting" <ting.ye@intel.com>,
 "Fu, Siyuan" <siyuan.fu@intel.com>
References: <20190507142705.20092-1-liming.gao@intel.com>
 <20190507142705.20092-3-liming.gao@intel.com>
 <d16cab6d-4cab-e1b9-6adc-dd045347e7e8@redhat.com>
 <4A89E2EF3DFEDB4C8BFDE51014F606A14E444638@SHSMSX104.ccr.corp.intel.com>
From: "Laszlo Ersek" <lersek@redhat.com>
Message-ID: <93c84dac-4a98-37cd-e66e-08ab35679d0b@redhat.com>
Date: Tue, 14 May 2019 16:33:06 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E444638@SHSMSX104.ccr.corp.intel.com>
X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Tue, 14 May 2019 14:33:16 +0000 (UTC)
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

Hi Liming,

On 05/08/19 02:14, Liming Gao wrote:
> Sure. Thanks for your detail review.

I've just noticed that commit 1e948802e755 ("NetworkPkg: Add DSC/FDF
include segment files to NetworkPkg.", 2019-05-08) does not carry my
Reviewed-by tag.

But I worked with you across five iterations of this patch series,
spending a lot of energy on the review. I gave my R-b here:

  http://mid.mail-archive.com/5cc12fc5-451a-2924-5179-73c1f192681a@redhat.com
  https://edk2.groups.io/g/devel/message/40131

Honestly, this makes me feel like I should just abandon the edk2 project
for good. I mean if you wanted to intentionally humiliate a reviewer,
you couldn't do much better than this.

Laszlo