* [edk2-devel] [edk2-platforms][PATCH 0/3] AmpereAltraPkg: Remove Max Frequency config
@ 2024-08-15 7:12 Nhi Pham via groups.io
2024-08-15 7:12 ` [edk2-devel] [edk2-platforms][PATCH 1/3] AmpereAltraPkg/AcpiConfigDxe: Remove Max Frequency config option Nhi Pham via groups.io
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: Nhi Pham via groups.io @ 2024-08-15 7:12 UTC (permalink / raw)
To: devel; +Cc: quic_llindhol, chuong, rebecca, nhi
This patch series aims to remove the maximum (turbo) frequency since the
CPU nominal frequency is equivalient to the max frequency.
Nhi Pham (3):
AmpereAltraPkg/AcpiConfigDxe: Remove Max Frequency config option
AmpereAltraPkg/PlatformInfoDxe: Correct CPU frequency info
AmpereAltraPkg/SystemFirmwareInterfaceLib: Remove unused
MailboxMsgTurboConfig()
Silicon/Ampere/AmpereAltraPkg/Include/AcpiConfigNVDataStruct.h | 4 +-
Silicon/Ampere/AmpereAltraPkg/Include/Library/SystemFirmwareInterfaceLib.h | 25 ------
Silicon/Ampere/AmpereAltraPkg/Drivers/AcpiConfigDxe/AcpiConfigVfr.vfr | 13 ---
Silicon/Ampere/AmpereAltraPkg/Drivers/AcpiConfigDxe/AcpiConfigDxe.c | 83 --------------------
Silicon/Ampere/AmpereAltraPkg/Drivers/PlatformInfoDxe/PlatformInfoDxe.c | 2 +-
Silicon/Ampere/AmpereAltraPkg/Library/SystemFirmwareInterfaceLib/SystemFirmwareInterfaceLib.c | 43 ----------
Silicon/Ampere/AmpereAltraPkg/Drivers/AcpiConfigDxe/AcpiConfigStrings.uni | 3 -
7 files changed, 2 insertions(+), 171 deletions(-)
--
2.25.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120347): https://edk2.groups.io/g/devel/message/120347
Mute This Topic: https://groups.io/mt/107909933/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 6+ messages in thread
* [edk2-devel] [edk2-platforms][PATCH 1/3] AmpereAltraPkg/AcpiConfigDxe: Remove Max Frequency config option
2024-08-15 7:12 [edk2-devel] [edk2-platforms][PATCH 0/3] AmpereAltraPkg: Remove Max Frequency config Nhi Pham via groups.io
@ 2024-08-15 7:12 ` Nhi Pham via groups.io
2024-08-15 7:12 ` [edk2-devel] [edk2-platforms][PATCH 2/3] AmpereAltraPkg/PlatformInfoDxe: Correct CPU frequency info Nhi Pham via groups.io
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Nhi Pham via groups.io @ 2024-08-15 7:12 UTC (permalink / raw)
To: devel; +Cc: quic_llindhol, chuong, rebecca, nhi
Beginning with SCP version 1.08, the CPU nominal frequency is
equivalient to the maximum (turbo) frequency. Hence, the max frequency
config option can be eliminated from the ACPI Configuration screen.
Signed-off-by: Nhi Pham <nhi@os.amperecomputing.com>
---
Silicon/Ampere/AmpereAltraPkg/Include/AcpiConfigNVDataStruct.h | 4 +-
Silicon/Ampere/AmpereAltraPkg/Drivers/AcpiConfigDxe/AcpiConfigVfr.vfr | 13 ---
Silicon/Ampere/AmpereAltraPkg/Drivers/AcpiConfigDxe/AcpiConfigDxe.c | 83 --------------------
Silicon/Ampere/AmpereAltraPkg/Drivers/AcpiConfigDxe/AcpiConfigStrings.uni | 3 -
4 files changed, 1 insertion(+), 102 deletions(-)
diff --git a/Silicon/Ampere/AmpereAltraPkg/Include/AcpiConfigNVDataStruct.h b/Silicon/Ampere/AmpereAltraPkg/Include/AcpiConfigNVDataStruct.h
index a56bfa9aa694..58574015c642 100644
--- a/Silicon/Ampere/AmpereAltraPkg/Include/AcpiConfigNVDataStruct.h
+++ b/Silicon/Ampere/AmpereAltraPkg/Include/AcpiConfigNVDataStruct.h
@@ -18,9 +18,7 @@ typedef struct {
UINT32 EnableApeiSupport;
UINT32 AcpiCppcEnable;
UINT32 AcpiLpiEnable;
- UINT32 AcpiTurboSupport;
- UINT32 AcpiTurboMode;
- UINT32 Reserved[4];
+ UINT32 Reserved[6];
} ACPI_CONFIG_VARSTORE_DATA;
#pragma pack()
diff --git a/Silicon/Ampere/AmpereAltraPkg/Drivers/AcpiConfigDxe/AcpiConfigVfr.vfr b/Silicon/Ampere/AmpereAltraPkg/Drivers/AcpiConfigDxe/AcpiConfigVfr.vfr
index 3962aa227037..0d775172ce81 100644
--- a/Silicon/Ampere/AmpereAltraPkg/Drivers/AcpiConfigDxe/AcpiConfigVfr.vfr
+++ b/Silicon/Ampere/AmpereAltraPkg/Drivers/AcpiConfigDxe/AcpiConfigVfr.vfr
@@ -51,19 +51,6 @@ formset
option text = STRING_TOKEN(STR_ACPI_COMMON_ENABLE), value = 1, flags = DEFAULT;
endoneof;
- grayoutif ideqval AcpiConfigNVData.AcpiTurboSupport == 0;
- oneof
- varid = AcpiConfigNVData.AcpiTurboMode,
- prompt = STRING_TOKEN(STR_ACPI_TURBO_PROMPT),
- help = STRING_TOKEN(STR_ACPI_TURBO_HELP),
- option text = STRING_TOKEN(STR_ACPI_COMMON_ENABLE), value = 1, flags = DEFAULT;
- option text = STRING_TOKEN(STR_ACPI_COMMON_DISABLE), value = 0, flags = 0;
- suppressif ideqval AcpiConfigNVData.AcpiTurboSupport > 0;
- option text = STRING_TOKEN(STR_ACPI_UNSUPPORTED), value = 2, flags = 0;
- endif;
- endoneof;
- endif;
-
endform;
endformset;
diff --git a/Silicon/Ampere/AmpereAltraPkg/Drivers/AcpiConfigDxe/AcpiConfigDxe.c b/Silicon/Ampere/AmpereAltraPkg/Drivers/AcpiConfigDxe/AcpiConfigDxe.c
index 6ba39ad4409b..4536010a6f0d 100644
--- a/Silicon/Ampere/AmpereAltraPkg/Drivers/AcpiConfigDxe/AcpiConfigDxe.c
+++ b/Silicon/Ampere/AmpereAltraPkg/Drivers/AcpiConfigDxe/AcpiConfigDxe.c
@@ -338,79 +338,6 @@ DriverCallback (
return EFI_SUCCESS;
}
-STATIC
-EFI_STATUS
-AcpiNVDataUpdate (
- IN ACPI_CONFIG_PRIVATE_DATA *PrivateData
- )
-{
- EFI_STATUS Status;
- PLATFORM_INFO_HOB *PlatformHob;
- UINT32 TurboSupport;
-
- ASSERT (PrivateData != NULL);
-
- PlatformHob = PrivateData->PlatformHob;
- TurboSupport = PlatformHob->TurboCapability[0] + PlatformHob->TurboCapability[1];
-
- if (TurboSupport == 0) {
- PrivateData->Configuration.AcpiTurboMode = 2; // Unsupported mode
- PrivateData->Configuration.AcpiTurboSupport = 0;
- } else {
- PrivateData->Configuration.AcpiTurboSupport = 1;
- }
-
- Status = gRT->SetVariable (
- AcpiVarstoreDataName,
- &gAcpiConfigFormSetGuid,
- ACPI_VARSTORE_ATTRIBUTES,
- sizeof (ACPI_CONFIG_VARSTORE_DATA),
- &PrivateData->Configuration
- );
- if (EFI_ERROR (Status)) {
- DEBUG ((DEBUG_ERROR, "%a %d gRT->SetVariable() failed \n", __FUNCTION__, __LINE__));
- return Status;
- }
-
- return EFI_SUCCESS;
-}
-
-STATIC
-EFI_STATUS
-UpdateTurboModeConfig (
- IN ACPI_CONFIG_PRIVATE_DATA *PrivateData
- )
-{
- EFI_STATUS Status;
- PLATFORM_INFO_HOB *PlatformHob;
- BOOLEAN EnableTurbo;
-
- ASSERT (PrivateData != NULL);
-
- if (PrivateData->Configuration.AcpiTurboSupport != 0) {
- PlatformHob = PrivateData->PlatformHob;
- EnableTurbo = (PrivateData->Configuration.AcpiTurboMode != 0) ? TRUE : FALSE;
-
- if (PlatformHob->TurboCapability[0] != 0) {
- Status = MailboxMsgTurboConfig (0, EnableTurbo);
- if (EFI_ERROR (Status)) {
- return Status;
- }
- }
-
- if (PlatformHob->TurboCapability[1] != 0) {
- Status = MailboxMsgTurboConfig (1, EnableTurbo);
- if (EFI_ERROR (Status)) {
- return Status;
- }
- }
- } else {
- DEBUG ((DEBUG_INFO, "%a: Turbo mode is unsupported! \n", __FUNCTION__));
- }
-
- return EFI_SUCCESS;
-}
-
STATIC
EFI_STATUS
UpdateCPPCConfig (
@@ -519,11 +446,6 @@ UpdateAcpiOnReadyToBoot (
return;
}
- Status = UpdateTurboModeConfig (mPrivateData);
- if (EFI_ERROR (Status)) {
- return;
- }
-
//
// Close DSDT Table
//
@@ -719,10 +641,5 @@ AcpiConfigEntryPoint (
return Status;
}
- Status = AcpiNVDataUpdate (mPrivateData);
- if (EFI_ERROR (Status)) {
- return Status;
- }
-
return EFI_SUCCESS;
}
diff --git a/Silicon/Ampere/AmpereAltraPkg/Drivers/AcpiConfigDxe/AcpiConfigStrings.uni b/Silicon/Ampere/AmpereAltraPkg/Drivers/AcpiConfigDxe/AcpiConfigStrings.uni
index 21a6188518fd..143672262744 100644
--- a/Silicon/Ampere/AmpereAltraPkg/Drivers/AcpiConfigDxe/AcpiConfigStrings.uni
+++ b/Silicon/Ampere/AmpereAltraPkg/Drivers/AcpiConfigDxe/AcpiConfigStrings.uni
@@ -22,6 +22,3 @@
#string STR_ACPI_LPI_PROMPT #language en-US "LPI Support"
#string STR_ACPI_LPI_HELP #language en-US "Enables or Disables System ability to LPI (Lower Power Idle)"
-
-#string STR_ACPI_TURBO_PROMPT #language en-US "Max Performance"
-#string STR_ACPI_TURBO_HELP #language en-US "Enables or Disables System ability to Max Performance"
--
2.25.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120348): https://edk2.groups.io/g/devel/message/120348
Mute This Topic: https://groups.io/mt/107909935/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [edk2-devel] [edk2-platforms][PATCH 2/3] AmpereAltraPkg/PlatformInfoDxe: Correct CPU frequency info
2024-08-15 7:12 [edk2-devel] [edk2-platforms][PATCH 0/3] AmpereAltraPkg: Remove Max Frequency config Nhi Pham via groups.io
2024-08-15 7:12 ` [edk2-devel] [edk2-platforms][PATCH 1/3] AmpereAltraPkg/AcpiConfigDxe: Remove Max Frequency config option Nhi Pham via groups.io
@ 2024-08-15 7:12 ` Nhi Pham via groups.io
2024-08-15 7:12 ` [edk2-devel] [edk2-platforms][PATCH 3/3] AmpereAltraPkg/SystemFirmwareInterfaceLib: Remove unused MailboxMsgTurboConfig() Nhi Pham via groups.io
2024-08-22 6:58 ` [edk2-devel] [edk2-platforms][PATCH 0/3] AmpereAltraPkg: Remove Max Frequency config Chuong Tran
3 siblings, 0 replies; 6+ messages in thread
From: Nhi Pham via groups.io @ 2024-08-15 7:12 UTC (permalink / raw)
To: devel; +Cc: quic_llindhol, chuong, rebecca, nhi
Given that the max frequency is always active, the CPU frequency showned
on the CPU Information screen should be retrieved using the
CpuGetMaxFreq() function. The function will prioritize obtaining the max
frequency over the CPU normal frequency.
Signed-off-by: Nhi Pham <nhi@os.amperecomputing.com>
---
Silicon/Ampere/AmpereAltraPkg/Drivers/PlatformInfoDxe/PlatformInfoDxe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Silicon/Ampere/AmpereAltraPkg/Drivers/PlatformInfoDxe/PlatformInfoDxe.c b/Silicon/Ampere/AmpereAltraPkg/Drivers/PlatformInfoDxe/PlatformInfoDxe.c
index 82d2cf131c16..4b677765cd0e 100644
--- a/Silicon/Ampere/AmpereAltraPkg/Drivers/PlatformInfoDxe/PlatformInfoDxe.c
+++ b/Silicon/Ampere/AmpereAltraPkg/Drivers/PlatformInfoDxe/PlatformInfoDxe.c
@@ -156,7 +156,7 @@ UpdatePlatformInfoScreen (
);
/* CPU clock */
- UnicodeSPrint (Str, sizeof (Str), L"%dMHz", PlatformHob->CpuClk / MHZ_SCALE_FACTOR);
+ UnicodeSPrint (Str, sizeof (Str), L"%dMHz", CpuGetMaxFreq (0) / MHZ_SCALE_FACTOR);
HiiSetString (
HiiHandle,
STRING_TOKEN (STR_PLATFORM_INFO_CPUCLK_VALUE),
--
2.25.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120349): https://edk2.groups.io/g/devel/message/120349
Mute This Topic: https://groups.io/mt/107909936/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [edk2-devel] [edk2-platforms][PATCH 3/3] AmpereAltraPkg/SystemFirmwareInterfaceLib: Remove unused MailboxMsgTurboConfig()
2024-08-15 7:12 [edk2-devel] [edk2-platforms][PATCH 0/3] AmpereAltraPkg: Remove Max Frequency config Nhi Pham via groups.io
2024-08-15 7:12 ` [edk2-devel] [edk2-platforms][PATCH 1/3] AmpereAltraPkg/AcpiConfigDxe: Remove Max Frequency config option Nhi Pham via groups.io
2024-08-15 7:12 ` [edk2-devel] [edk2-platforms][PATCH 2/3] AmpereAltraPkg/PlatformInfoDxe: Correct CPU frequency info Nhi Pham via groups.io
@ 2024-08-15 7:12 ` Nhi Pham via groups.io
2024-08-22 6:58 ` [edk2-devel] [edk2-platforms][PATCH 0/3] AmpereAltraPkg: Remove Max Frequency config Chuong Tran
3 siblings, 0 replies; 6+ messages in thread
From: Nhi Pham via groups.io @ 2024-08-15 7:12 UTC (permalink / raw)
To: devel; +Cc: quic_llindhol, chuong, rebecca, nhi
Since configuring the max frequency is unnecessary, its configuration
functions is unused, so remove it.
Signed-off-by: Nhi Pham <nhi@os.amperecomputing.com>
---
Silicon/Ampere/AmpereAltraPkg/Include/Library/SystemFirmwareInterfaceLib.h | 25 ------------
Silicon/Ampere/AmpereAltraPkg/Library/SystemFirmwareInterfaceLib/SystemFirmwareInterfaceLib.c | 43 --------------------
2 files changed, 68 deletions(-)
diff --git a/Silicon/Ampere/AmpereAltraPkg/Include/Library/SystemFirmwareInterfaceLib.h b/Silicon/Ampere/AmpereAltraPkg/Include/Library/SystemFirmwareInterfaceLib.h
index ce96c2a6b4b6..b91b7c1f862f 100644
--- a/Silicon/Ampere/AmpereAltraPkg/Include/Library/SystemFirmwareInterfaceLib.h
+++ b/Silicon/Ampere/AmpereAltraPkg/Include/Library/SystemFirmwareInterfaceLib.h
@@ -153,14 +153,6 @@
#define MAILBOX_BOOT_PROGRESS_COMMAND_SET 1
#define MAILBOX_BOOT_PROGRESS_STAGE_UEFI 8
-//
-// Parameters for Set Configuration
-// Param0: Configuration type
-// 20: Turbo configuration
-// Param1: Unused
-//
-#define MAILBOX_SET_CONFIGURATION_TURBO 20
-
/**
Read a register which is not accessible from the non-secure world
by sending a mailbox message to the SMpro processor.
@@ -262,21 +254,4 @@ MailboxMsgSetBootProgress (
IN UINT32 Checkpoint
);
-/**
- Configure the Turbo (Max Performance) mode.
-
- @param[in] Socket Active socket index.
- @param[in] Enable Enable/Disable the Turbo (Max performance) mode.
-
- @retval EFI_SUCCESS Configure the Turbo successfully.
- @retval EFI_INVALID_PARAMETER A parameter is invalid.
- @retval Otherwise Errors returned from the MailboxWrite() functions.
-**/
-EFI_STATUS
-EFIAPI
-MailboxMsgTurboConfig (
- IN UINT8 Socket,
- IN BOOLEAN Enable
- );
-
#endif /* SYSTEM_FIRMWARE_INTERFACE_LIB_H_ */
diff --git a/Silicon/Ampere/AmpereAltraPkg/Library/SystemFirmwareInterfaceLib/SystemFirmwareInterfaceLib.c b/Silicon/Ampere/AmpereAltraPkg/Library/SystemFirmwareInterfaceLib/SystemFirmwareInterfaceLib.c
index 9cab653418fb..dacfd36d1691 100644
--- a/Silicon/Ampere/AmpereAltraPkg/Library/SystemFirmwareInterfaceLib/SystemFirmwareInterfaceLib.c
+++ b/Silicon/Ampere/AmpereAltraPkg/Library/SystemFirmwareInterfaceLib/SystemFirmwareInterfaceLib.c
@@ -283,46 +283,3 @@ MailboxMsgSetBootProgress (
return Status;
}
-
-/**
- Configure the Turbo (Max Performance) mode.
-
- @param[in] Socket Active socket index.
- @param[in] Enable Enable/Disable the Turbo (Max performance) mode.
-
- @retval EFI_SUCCESS Configure the Turbo successfully.
- @retval EFI_INVALID_PARAMETER A parameter is invalid.
- @retval Otherwise Errors returned from the MailboxWrite() functions.
-**/
-EFI_STATUS
-EFIAPI
-MailboxMsgTurboConfig (
- IN UINT8 Socket,
- IN BOOLEAN Enable
- )
-{
- EFI_STATUS Status;
- MAILBOX_MESSAGE_DATA Message;
-
- if (Socket >= GetNumberOfSupportedSockets ()) {
- return EFI_INVALID_PARAMETER;
- }
-
- Message.Data = MAILBOX_USER_MESSAGE_ENCODE (
- MAILBOX_USER_MESSAGE_SUBTYPE_SET_CONFIGURATION,
- MAILBOX_SET_CONFIGURATION_TURBO,
- 0
- );
-
- //
- // The Turbo configuration is written into the extended data 0.
- // The extended data 1 is unused.
- //
- Message.ExtendedData[0] = Enable ? 1 : 0;
- Message.ExtendedData[1] = 0;
-
- Status = MailboxWrite (Socket, PMproDoorbellChannel1, &Message);
- ASSERT_EFI_ERROR (Status);
-
- return Status;
-}
--
2.25.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120350): https://edk2.groups.io/g/devel/message/120350
Mute This Topic: https://groups.io/mt/107909938/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [edk2-devel] [edk2-platforms][PATCH 0/3] AmpereAltraPkg: Remove Max Frequency config
2024-08-15 7:12 [edk2-devel] [edk2-platforms][PATCH 0/3] AmpereAltraPkg: Remove Max Frequency config Nhi Pham via groups.io
` (2 preceding siblings ...)
2024-08-15 7:12 ` [edk2-devel] [edk2-platforms][PATCH 3/3] AmpereAltraPkg/SystemFirmwareInterfaceLib: Remove unused MailboxMsgTurboConfig() Nhi Pham via groups.io
@ 2024-08-22 6:58 ` Chuong Tran
2024-08-23 2:50 ` Nhi Pham via groups.io
3 siblings, 1 reply; 6+ messages in thread
From: Chuong Tran @ 2024-08-22 6:58 UTC (permalink / raw)
To: Nhi Pham, devel; +Cc: quic_llindhol, chuong, rebecca
For this series:
Reviewed-by: Chuong Tran <chuong@os.amperecomputing.com>
Thanks,
Chuong
On 8/15/2024 2:12 PM, Nhi Pham wrote:
> This patch series aims to remove the maximum (turbo) frequency since the
> CPU nominal frequency is equivalient to the max frequency.
>
> Nhi Pham (3):
> AmpereAltraPkg/AcpiConfigDxe: Remove Max Frequency config option
> AmpereAltraPkg/PlatformInfoDxe: Correct CPU frequency info
> AmpereAltraPkg/SystemFirmwareInterfaceLib: Remove unused
> MailboxMsgTurboConfig()
>
> Silicon/Ampere/AmpereAltraPkg/Include/AcpiConfigNVDataStruct.h | 4 +-
> Silicon/Ampere/AmpereAltraPkg/Include/Library/SystemFirmwareInterfaceLib.h | 25 ------
> Silicon/Ampere/AmpereAltraPkg/Drivers/AcpiConfigDxe/AcpiConfigVfr.vfr | 13 ---
> Silicon/Ampere/AmpereAltraPkg/Drivers/AcpiConfigDxe/AcpiConfigDxe.c | 83 --------------------
> Silicon/Ampere/AmpereAltraPkg/Drivers/PlatformInfoDxe/PlatformInfoDxe.c | 2 +-
> Silicon/Ampere/AmpereAltraPkg/Library/SystemFirmwareInterfaceLib/SystemFirmwareInterfaceLib.c | 43 ----------
> Silicon/Ampere/AmpereAltraPkg/Drivers/AcpiConfigDxe/AcpiConfigStrings.uni | 3 -
> 7 files changed, 2 insertions(+), 171 deletions(-)
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120393): https://edk2.groups.io/g/devel/message/120393
Mute This Topic: https://groups.io/mt/107909933/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [edk2-devel] [edk2-platforms][PATCH 0/3] AmpereAltraPkg: Remove Max Frequency config
2024-08-22 6:58 ` [edk2-devel] [edk2-platforms][PATCH 0/3] AmpereAltraPkg: Remove Max Frequency config Chuong Tran
@ 2024-08-23 2:50 ` Nhi Pham via groups.io
0 siblings, 0 replies; 6+ messages in thread
From: Nhi Pham via groups.io @ 2024-08-23 2:50 UTC (permalink / raw)
To: Chuong Tran OS, devel@edk2.groups.io
Cc: quic_llindhol@quicinc.com, Chuong Tran OS, Rebecca Cran OS
[-- Attachment #1: Type: text/plain, Size: 2257 bytes --]
Pushed as debfeb1f3052..7dad9da43942
Thanks,
Nhi
________________________________
From: Chuong Tran OS <chuong@amperemail.onmicrosoft.com>
Sent: Thursday, August 22, 2024 1:58 PM
To: Nhi Pham OS <nhi@os.amperecomputing.com>; devel@edk2.groups.io <devel@edk2.groups.io>
Cc: quic_llindhol@quicinc.com <quic_llindhol@quicinc.com>; Chuong Tran OS <chuong@os.amperecomputing.com>; Rebecca Cran OS <rebecca@os.amperecomputing.com>
Subject: Re: [edk2-platforms][PATCH 0/3] AmpereAltraPkg: Remove Max Frequency config
For this series:
Reviewed-by: Chuong Tran <chuong@os.amperecomputing.com>
Thanks,
Chuong
On 8/15/2024 2:12 PM, Nhi Pham wrote:
> This patch series aims to remove the maximum (turbo) frequency since the
> CPU nominal frequency is equivalient to the max frequency.
>
> Nhi Pham (3):
> AmpereAltraPkg/AcpiConfigDxe: Remove Max Frequency config option
> AmpereAltraPkg/PlatformInfoDxe: Correct CPU frequency info
> AmpereAltraPkg/SystemFirmwareInterfaceLib: Remove unused
> MailboxMsgTurboConfig()
>
> Silicon/Ampere/AmpereAltraPkg/Include/AcpiConfigNVDataStruct.h | 4 +-
> Silicon/Ampere/AmpereAltraPkg/Include/Library/SystemFirmwareInterfaceLib.h | 25 ------
> Silicon/Ampere/AmpereAltraPkg/Drivers/AcpiConfigDxe/AcpiConfigVfr.vfr | 13 ---
> Silicon/Ampere/AmpereAltraPkg/Drivers/AcpiConfigDxe/AcpiConfigDxe.c | 83 --------------------
> Silicon/Ampere/AmpereAltraPkg/Drivers/PlatformInfoDxe/PlatformInfoDxe.c | 2 +-
> Silicon/Ampere/AmpereAltraPkg/Library/SystemFirmwareInterfaceLib/SystemFirmwareInterfaceLib.c | 43 ----------
> Silicon/Ampere/AmpereAltraPkg/Drivers/AcpiConfigDxe/AcpiConfigStrings.uni | 3 -
> 7 files changed, 2 insertions(+), 171 deletions(-)
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120397): https://edk2.groups.io/g/devel/message/120397
Mute This Topic: https://groups.io/mt/107909933/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
[-- Attachment #2: Type: text/html, Size: 4477 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-08-23 2:50 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-15 7:12 [edk2-devel] [edk2-platforms][PATCH 0/3] AmpereAltraPkg: Remove Max Frequency config Nhi Pham via groups.io
2024-08-15 7:12 ` [edk2-devel] [edk2-platforms][PATCH 1/3] AmpereAltraPkg/AcpiConfigDxe: Remove Max Frequency config option Nhi Pham via groups.io
2024-08-15 7:12 ` [edk2-devel] [edk2-platforms][PATCH 2/3] AmpereAltraPkg/PlatformInfoDxe: Correct CPU frequency info Nhi Pham via groups.io
2024-08-15 7:12 ` [edk2-devel] [edk2-platforms][PATCH 3/3] AmpereAltraPkg/SystemFirmwareInterfaceLib: Remove unused MailboxMsgTurboConfig() Nhi Pham via groups.io
2024-08-22 6:58 ` [edk2-devel] [edk2-platforms][PATCH 0/3] AmpereAltraPkg: Remove Max Frequency config Chuong Tran
2024-08-23 2:50 ` Nhi Pham via groups.io
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox