From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web12.21947.1581479007012976068 for ; Tue, 11 Feb 2020 19:43:27 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: liming.gao@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Feb 2020 19:43:26 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,428,1574150400"; d="scan'208";a="251777488" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga002.jf.intel.com with ESMTP; 11 Feb 2020 19:43:25 -0800 Received: from shsmsx603.ccr.corp.intel.com (10.109.6.143) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 11 Feb 2020 19:43:25 -0800 Received: from shsmsx606.ccr.corp.intel.com (10.109.6.216) by SHSMSX603.ccr.corp.intel.com (10.109.6.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 12 Feb 2020 11:42:50 +0800 Received: from shsmsx606.ccr.corp.intel.com ([10.109.6.216]) by SHSMSX606.ccr.corp.intel.com ([10.109.6.216]) with mapi id 15.01.1713.004; Wed, 12 Feb 2020 11:42:50 +0800 From: "Liming Gao" To: "Liu, Zhiguang" , "devel@edk2.groups.io" CC: "Feng, Bob C" Subject: Re: [PATCH] BaseTools: remove -DNO_MSABI_VA_FUNCS option in CLANGPDB tool chain Thread-Topic: [PATCH] BaseTools: remove -DNO_MSABI_VA_FUNCS option in CLANGPDB tool chain Thread-Index: AQHV4UV2jdeUzdHqs0ihK7rz1la7qKgW6nDQ Date: Wed, 12 Feb 2020 03:42:50 +0000 Message-ID: <93d5b2b58425497a9b83840c0b406ec6@intel.com> References: <20200212014021.26772-1-zhiguang.liu@intel.com> In-Reply-To: <20200212014021.26772-1-zhiguang.liu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.2.0.6 dlp-product: dlpe-windows dlp-reaction: no-action x-originating-ip: [10.239.127.36] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao > -----Original Message----- > From: Liu, Zhiguang > Sent: Wednesday, February 12, 2020 9:40 AM > To: devel@edk2.groups.io > Cc: Feng, Bob C ; Gao, Liming > Subject: [PATCH] BaseTools: remove -DNO_MSABI_VA_FUNCS option in CLANGPDB= tool chain >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2524 >=20 > remove -DNO_MSABI_VA_FUNCS option in CLANGPDB tool chain After CLANGPDB i= s > switched to GNU mode, to use MS ABI version of GCC built-in macros for > variable argument lists as same as CLANG38 tool chain. >=20 > Cc: Bob Feng > Cc: Liming Gao >=20 > Signed-off-by: Zhiguang Liu > --- > BaseTools/Conf/tools_def.template | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def= .template > index 837107a19f..2b17d3b297 100755 > --- a/BaseTools/Conf/tools_def.template > +++ b/BaseTools/Conf/tools_def.template > @@ -2759,7 +2759,7 @@ DEFINE CLANGPDB_IA32_TARGET =3D -target i6= 86-unknown-windows-gnu > DEFINE CLANGPDB_X64_TARGET =3D -target x86_64-unknown-windows-= gnu >=20 > DEFINE CLANGPDB_WARNING_OVERRIDES =3D -Wno-parentheses-equality -Wno-= tautological-compare -Wno-tautological-constant-out- > of-range-compare -Wno-empty-body -Wno-unused-const-variable -Wno-varargs = -Wno-unknown-warning-option -Wno-microsoft-enum- > forward-reference > -DEFINE CLANGPDB_ALL_CC_FLAGS =3D DEF(GCC48_ALL_CC_FLAGS) DEF(CLA= NGPDB_WARNING_OVERRIDES) -DNO_MSABI_VA_FUNCS > -fno-stack-protector -funsigned-char -ftrap-function=3Dundefined_behavior= _has_been_optimized_away_by_clang -Wno-address -Wno- > shift-negative-value -Wno-unknown-pragmas -Wno-incompatible-library-redec= laration -Wno-null-dereference -mno-implicit-float -mms- > bitfields -mno-stack-arg-probe -nostdlib -nostdlibinc > +DEFINE CLANGPDB_ALL_CC_FLAGS =3D DEF(GCC48_ALL_CC_FLAGS) DEF(CLA= NGPDB_WARNING_OVERRIDES) -fno-stack-protector - > funsigned-char -ftrap-function=3Dundefined_behavior_has_been_optimized_aw= ay_by_clang -Wno-address -Wno-shift-negative-value - > Wno-unknown-pragmas -Wno-incompatible-library-redeclaration -Wno-null-der= eference -mno-implicit-float -mms-bitfields -mno-stack- > arg-probe -nostdlib -nostdlibinc >=20 > ########################### > # CLANGPDB IA32 definitions > -- > 2.16.2.windows.1