From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from duck.fensystems.co.uk (duck.fensystems.co.uk [212.13.204.60])
 by mx.groups.io with SMTP id smtpd.web12.6962.1573749373976783427
 for <devel@edk2.groups.io>;
 Thu, 14 Nov 2019 08:36:14 -0800
Authentication-Results: mx.groups.io;
 dkim=missing; spf=none, err=permanent DNS error (domain: ipxe.org, ip: 212.13.204.60, mailfrom: mcb30@ipxe.org)
Received: from pudding.home (unknown [213.205.198.23])
	by duck.fensystems.co.uk (Postfix) with ESMTPSA id 21DFCA15D;
	Thu, 14 Nov 2019 16:43:37 +0000 (GMT)
Subject: Re: [edk2-devel] [edk2-platforms][PATCH 1/8] Platform/RPi: Add model family detection
To: devel@edk2.groups.io, pete@akeo.ie
Cc: ard.biesheuvel@linaro.org, leif.lindholm@linaro.org, philmd@redhat.com
References: <20191114160740.10072-1-pete@akeo.ie>
 <20191114160740.10072-2-pete@akeo.ie>
From: "Michael Brown" <mcb30@ipxe.org>
Message-ID: <93ee6d22-1482-7c57-64ce-9524d70612dc@ipxe.org>
Date: Thu, 14 Nov 2019 16:36:10 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.8.0
MIME-Version: 1.0
In-Reply-To: <20191114160740.10072-2-pete@akeo.ie>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-GB
Content-Transfer-Encoding: 7bit

On 14/11/2019 16:07, Pete Batard wrote:
> +typedef
> +EFI_STATUS
> +(EFIAPI *GET_MODEL_FAMILY) (
> +  UINT32 *ModelFamily
> +  );
> +
>   typedef
>   EFI_STATUS
>   (EFIAPI *GET_FIRMWARE_REVISION) (
> @@ -143,6 +150,7 @@ typedef struct {
>     GET_MODEL             GetModel;
>     GET_MODEL_REVISION    GetModelRevision;
>     GET_MODEL_NAME        GetModelName;
> +  GET_MODEL_FAMILY      GetModelFamily;
>     GET_FIRMWARE_REVISION GetFirmwareRevision;
>     GET_MANUFACTURER_NAME GetManufacturerName;
>     GET_CPU_NAME          GetCpuName;

Is the RASPBERRY_PI_FIRMWARE_PROTOCOL structure expected to be 
externally consumed at any point?  If so, then adding a field in the 
middle of the structure without changing the associated GUID would break 
the ABI.

It's great to see the Pi 4 heading towards having UEFI support; I'm 
looking forward to trying it out as soon as it's ready.

Thanks,

Michael